search

microsoft / vscode-webview-ui-toolkit

A component library for building webview-based extensions in Visual Studio Code.
MIT License
2k stars 138 forks source link

A11y_VscodeWebviewUiToolkit_AllComponents_DataGrid_Keyboard: The column headers of data grid "with variable column widths" are not resizable using the keyboard with any key combination like "ctrl + shift + right arrow" #184

Closed Shivamd1 closed 3 years ago

Shivamd1 commented 3 years ago

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_VscodeWebviewUiToolkit_Aug2021;#Webview UI Toolkit for Visual Studio Code;#Win32;#FTP;#DesktopApp;#WCAG2.1.1;#Keyboard;#AINotInScope;

Environment Details:

Application Name: Vscode Webview Ui Toolkit Windows Version: Win10

Repro Steps:

  1. Launch VS Code
  2. Open WebView UI Toolkit: All Component extension
  3. Tab to data grid "with variable column widths" and check if it is resizable using the keyboard with any key combination like "ctrl + shift + right arrow"

Actual:

The column headers of data grid "with variable column widths" are not resizable using the keyboard with any key combination like "ctrl + shift + right arrow"

Expected:

The column headers of data grid "with variable column widths" should be resizable using the keyboard with any key combination like "ctrl + shift + right arrow"

User Impact:

Keyboard only users will face difficulty in resizing the column headers width

hawkticehurst commented 3 years ago

@Shivamd1 Oh I think there was a misunderstanding here, "variable column width" is supposed to be from the perspective of the developer, not the user.

By default, the data grid columns take up an equal amount of space and variable column width just means that a developer can manually adjust each column width to some specific value. At no point can the user ever adjust the column widths––the data grid sizing is static for them.

daviddossett commented 3 years ago

"Variable column widths" --> "Custom column widths" for clarity?

hawkticehurst commented 3 years ago

Oh, I like that. I can update it in the sample extension, docs, and Storybook.

Shivamd1 commented 3 years ago

@hawkticehurst Will check this one with our SME and get back to you.

hawkticehurst commented 3 years ago

@Shivamd1 Any updates on this issue?

daviddossett commented 3 years ago

@Shivamd1 can we close this issue given the clarification above? To refresh, the column widths are not intended to be resizable with a mouse or keyboard.

Shivamd1 commented 3 years ago

@daviddossett @hawkticehurst As per discussion with SME the column headers are not meant for the users hence closing the bug

fsteffi commented 1 year ago

GithubTags:#Closed;