search

microsoft / vscode-webview-ui-toolkit

A component library for building webview-based extensions in Visual Studio Code.
MIT License
2k stars 138 forks source link

A11y_VscodeWebviewUiToolkit_AllComponents_Links_Keyboard: The keyboard focus is not visible after "default" link on pressing tab key #185

Closed Shivamd1 closed 3 years ago

Shivamd1 commented 3 years ago

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#SH_VscodeWebviewUiToolkit_Aug2021;#Webview UI Toolkit for Visual Studio Code;#Win32;#FTP;#DesktopApp;#WCAG2.4.7;#Keyboard;#AINotInScope;

Environment Details:

Application Name: Vscode Webview Ui Toolkit Windows Version: Win10

Repro Steps:

  1. Launch VS Code
  2. Open WebView UI Toolkit: All Component extension
  3. Tab to "links" and tab to default link
  4. Now hit tab key and check if focus is visible

Actual:

The keyboard focus is not visible after "default" link on pressing tab key. It goes on disabled link.

Similar issue is observed with scenarios:

  1. Read only number field
  2. Text Area

Expected:

The keyboard focus should be visible after "default" link on pressing tab key. The keyboard focus should go on next actionable control and not on disabled link.

User Impact:

Keyboard only low vision users will face difficulty in viewing the keyboard focus.

hawkticehurst commented 3 years ago

@Shivamd1 I just realized that this is also a case of a component state that we should remove from the toolkit.

I must have accidentally included "disabled" styling to the link at some point during development when in fact the disabled functionality does not exist on this component (nor does it exist in vanilla HTML anchor tags either). That's the reason the focus state is still functionally applied to the "disabled" link and it does not skip over to the next actionable control.

I will be removing any code and documentation regarding this disabled state. Thanks for the catch!

hawkticehurst commented 3 years ago

@Shivamd1 Just pushed a fix to this problem, can we get a review/confirmation to close this issue?

Shivamd1 commented 3 years ago

@hawkticehurst Please provide the latest build to verify

Shivamd1 commented 3 years ago

issue does not reproduces closing the bug

fsteffi commented 1 year ago

GithubTags:#Closed;