search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.96k stars 29.18k forks source link

Layout: waterfall for restoring default views #100059

Open bpasero opened 4 years ago

bpasero commented 4 years ago

Looks like https://github.com/microsoft/vscode/commit/9e0ab5ca6b9d9aa19666a808b06bdb315fd212aa introduced a waterfall in that everything below editor restore will have to wait for default views to restore. Imho e.g. a panel should not need to wait to restore if a default view is only for sidebar and vice versa.

One possible fix is to move the logic of restoring default views into the restoring of sidebar and panel itself and not have it as a separate thing.

bpasero commented 4 years ago

I started a PR for discussion in https://github.com/microsoft/vscode/pull/100058

sbatten commented 4 years ago

the PR was merged, was this resolved?

bpasero commented 4 years ago

I believe some parts of the description of the PR still apply, but I have not looked into that code lately if it changed:

This change tries to minimize the impact of waterfall, but could probably still be improved. For example, why does the panel have to wait to restore for the default views if no default view exists that lives in a panel?

This PR is trying to be a start but I think you should take this over and revisit the waterfall we now have. Ideally:

if a default view is only sidebar or only panel, it does not block the restoring of the panel or sidebar if we have 2 default views for sidebar and panel, things can be as today