search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.67k stars 29.44k forks source link

persistent notification covers the settings button when panel is on the right #103829

Open LER0ever opened 4 years ago

LER0ever commented 4 years ago

This is a UX nitpicking. Currently whenever there is a long-running notification that cannot be dismissed, the "Settings" gear icon will be covered and not clickable if the user moves the panel to the right.

Steps to Reproduce:

  1. Move panel to the right (Ctrl-P: "View: Move Panel Right")
  2. Let, for example, the C++ extension to install the required dependencies, just like the screenshot below.

image

Does this issue occur when all extensions are disabled?: Yes/No No, because then there will be no such notifications at all...

sbatten commented 3 years ago

@misolori should we just offset it by the activity bar width or do you have something better?

miguelsolorio commented 3 years ago

@sbatten yea I'd say activity bar (48x) + 8px (the current offset)

sbatten commented 3 years ago

I think the notification center which originates from the status bar, needs to remain in place and it is dismissible. However, the toasts need to be moved or be dismissible. This creates a bit of awkardness I think.

image

image