microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.6k stars 29.03k forks source link

Unable to set view visibility to hidden #104092

Closed miguelsolorio closed 4 years ago

miguelsolorio commented 4 years ago

Testing #103833

I'm using our tree view sample for this and have the following views set to hidden:

        "views": {
            "package-explorer": [
                {
                    "id": "nodeDependencies",
                    "name": "Node Dependencies",
                    "icon": "media/dep.svg",
                    "contextualTitle": "Package Explorer",
                    "visibility": "hidden"
                }
            ],
            "explorer": [
                {
                    "id": "jsonOutline",
                    "name": "Json Outline",
                    "when": "jsonOutlineEnabled",
                    "visibility": "hidden"
                },
                {
                    "id": "ftpExplorer",
                    "name": "FTP Explorer",
                    "visibility": "hidden"
                },
                {
                    "id": "fileExplorer",
                    "name": "File Explorer",
                    "visibility": "hidden"
                },
                {
                    "id": "testView",
                    "name": "Test View",
                    "visibility": "hidden"
                }
            ]
        },

Yet, when I run the extension they are all still visible:

image

image

alexr00 commented 4 years ago

@misolori did you try using a fresh --user-data-dir?

miguelsolorio commented 4 years ago

I believe this is because of #104100, launched my extension first then modified settings and they didn't change.