microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.09k stars 29.26k forks source link

Very hard to spot where object's members end and next local variable begins #10618

Closed alexdima closed 8 years ago

alexdima commented 8 years ago

_rule children stop before beforePush but this is very difficult to see unless one collapses to really check

object-limit

rozzzly commented 8 years ago

Just throwing in my 2¢ here: the solution seems obvious to me, just implement the traditional "tree view" ui pattern, complete with "guides" that make obvious the (sub|sibling|parent)node relationships obvious. You know something like this. Collapsed:

  *  fileA
 [+] folder1
 [+] folder2

Expanded:

  *  fileA
 [-]folder1
  |   * fileA1
  |  [+]subdir1
  |  [-]subdir2
  |   |   * fileC
  |   |   * FileD
  |   *  FileE
 [+] folder2
// the * would be a file icon;  Not suggesting using `+/-` current triangle is fine

Now one of the best parts about VSCode is its minimalistic ui. But guides wouldn't have to look like something out of Windows 98. Make the indent deeper; the debug variable inspector looks like its indent for subnodes are maybe 1px.. try 4px? The file browser widget in the sidebar looks fine as far as that, hierarchy isn't nearly as confusing. Even better, add a simple vertical bar (eg: how blockquotes are styled on github) that is slightly darker (or lighter if dark theme) than the background, 2px perhaps 3px wide.

Considering that now extensible icons are on this month's roadmap (#10600) this might be a good opportunity to unify these implementations. Indentation in the object inspector for the console is somewhere inbetween that of the file tree, and the object inspector in the debug sidebar. Seems to me like a good thing to abstract. And as you can see, considering it's apparently worth 2¢, my opinion is quite valuable... :stuck_out_tongue_winking_eye:

isidorn commented 8 years ago

We are now using the same indentation we use in the explorer. So 4px more. It should make things more obvious.

@rozzzly thanks for your suggestion but that is a seperate feature request. We are introducing icons to vscode in the August release and if you think your suggestion is the right way to go then please create a new feature request - thanks.