microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.73k stars 29.09k forks source link

Zombie mouse highlight in Explorer #107180

Closed Neutrino-Sunset closed 4 years ago

Neutrino-Sunset commented 4 years ago

Issue Type: Bug

Click any node in the Explorer with the mouse.

Use the keyboard to select a different Explorer node.

The node previously clicked with the mouse is still highlighted as the selected node, but if you perform any operation with the keyboard e.g. F2 (rename), delete; it is actually the node selected with the keyboard that is the selected one.

Focus0

Focus1

Focus3

VS Code version: Code 1.49.1 (58bb7b2331731bf72587010e943852e13e6fd3cf, 2020-09-16T23:27:51.792Z) OS version: Windows_NT x64 10.0.18362

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: enabled
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.86GB (8.50GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
Extensions (16) Extension|Author (truncated)|Version ---|---|--- ng-template|Ang|0.901.9 EditorConfig|Edi|0.15.1 LogFileHighlighter|emi|2.9.0 vscode-great-icons|emm|2.1.56 vscode-jasmine-test-adapter|hbe|1.7.0 vscode-test-explorer|hbe|2.19.1 classic-asp|ili|0.0.4 vscode-nuget-package-manager|jmr|1.1.6 csharp|ms-|1.22.0 debugger-for-chrome|msj|4.12.10 nativescript|Tel|0.11.0 subtle-brackets|raf|3.0.0 rewrap|stk|1.13.0 insert-special-symbol|swi|1.3.0 indent-one-space|use|0.2.6 html-css-class-completion|Zig|1.19.0
isidorn commented 4 years ago

This is how our tree works. We have focus and a selection. We will not change this. Closing as designed.

Neutrino-Sunset commented 4 years ago

Can you not provide any rationale to explain why such a nonsensical design is a good idea?

Neutrino-Sunset commented 4 years ago

Out of the focus and the selection which is which? Presumably the focus is the one you can move, same as any other control? But then what is the selection since that is the highlight that you can't actually do anything with. No keyboard shortcuts affect it, it literally does nothing yet is more promenent than the focused item.

Neutrino-Sunset commented 4 years ago

And how come clicking a file in the Explorer with the mouse both opens the file and 'selects' it (where 'selects' means gives it a really promenent highlight but doesn't actually do anything), but opening a file with the keyboard doesn't 'select' it?

How does that make sense?

How do I 'select' a file with the keyboard then? If for no other reason than opening a folder I never look in, 'select' a file in there and then close the folder again, which seems to be the only way to hide the additional 'selected' file node.

Neutrino-Sunset commented 4 years ago

My config shows list.select is bound to Enter.

So how come using the keyboard to focus a file in the Explorer and pressing Enter opens the file but leaves the selection highlight highlighting whichever file I last opened using the mouse?

And you're saying it's supposed to be that way? I don't believe you.