microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.36k stars 28.92k forks source link

Prompted to restart to update multiple times for every monthly version #107530

Closed jasonlewicki closed 3 years ago

jasonlewicki commented 4 years ago

Steps to Reproduce:

  1. Seems like just having vscode open will eventually prompt for an update of the same version

Does this issue occur when all extensions are disabled?: Yes

Every few days the gear has a new notification, saying that I should restart to update vscode. More often than not it's the same version that was already updated several times prior (unless an actual new update has been released). The release page for the month shows as well.

kieferrm commented 4 years ago

@jasonlewicki to clarify. What you see is (as an example):

jasonlewicki commented 4 years ago

@kaiwood ahh, ok I think i see what's going on. The monthly updates have minor updates. What I'm seeing on my end is:

"Hey, restart to update" restarts tab popup that says: "Welcome to the AUGUST 2020 update! and in very small print is the incremental update version"

then a few days later: "Hey, restart to update" restarts tab popup that says: "Welcome to the AUGUST 2020 update! and in very small print is the incremental update version"

I guess, for my perspective, to make it not feel like groundhog day, it would be great to have the release notes say so, and/or when this update was released (and in larger font). Because right now it just looks like the same August update over and over..

June updated 3 times for instance.

Thanks

kieferrm commented 4 years ago

For reference, this is what a minor version update looks like:

image

kieferrm commented 4 years ago

@gregvanl do you remember why we chose to not highlight the incremental version number more?

jasonlewicki commented 4 years ago

The highlight might depend on if the client had already installed a previous major/minor version.

gregvanl commented 3 years ago

@kieferrm I know we decided to leave the version in the main header as major.minor and I don't think users would notice if we changed the point release value. The current bold Update X.YY.Z in a separate section below the main header is quite visible and is a good balance between alerting users and letting them ignore point release details. We could increase the font size by making these H2s or adding update-specific CSS but right now we're just using standard Markdown paragraphs with bold text.

gregvanl commented 3 years ago

Closing as bolded point release values just below main header seems like a good balance.