Closed jrieken closed 3 years ago
Context key dump as of now
That context key list makes me
@meganrogge We gotta tighten up those when
clauses for our UpArrow and DownArrow commands, and make sure they are only handled when the editor has text focus. Let me know if you need some help there.
and make sure they are only handled when the editor has text focus. Let me know if you need some help there.
You also need to know if the suggest widget shows or not because the editor keeps focus when suggest shows.
@jrieken That's why I said text focus 😉 I believe the editor has a method to return whether that's true.
Wouldn't it then mean you cannot use the arrow keys to navigate between lines? Should this be a less prominent short cut?
We already avoid that: our commands only get invoked when you're at the top of bottom of the viewport. This is the same that happens in Search, where there's already multi-line history aware input box.