microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.66k stars 28.68k forks source link

Cannot arrow select suggestions in SCM input #109145

Closed jrieken closed 3 years ago

jrieken commented 3 years ago
jrieken commented 3 years ago

Context key dump as of now

Context keys ``` ReposManagerStateContext: "RepositoriesLoaded" acceptSuggestionOnEnter: true accessibilityModeEnabled: false activeEditor: "workbench.editors.textDiffEditor" activeEditorAvailableEditorIds: "" activeEditorGroupEmpty: false activeEditorGroupIndex: 1 activeEditorGroupLast: true activeEditorIsReadonly: true activePanel: "" activeViewlet: "workbench.view.scm" addToWorkspaceFolderRecommendations: false addToWorkspaceRecommendations: false atEndOfWord: false autoSaveAfterShortDelayContext: false azFuncTree.active: true azFuncTree.canMove: true azFuncTree.defaultViewLocation: true azureStorage.active: true azureStorage.canMove: true azureStorage.defaultViewLocation: true breakpointSelected: false breakpointsExist: true canNavigateBack: true canNavigateForward: false canNavigateToLastEditLocation: true canRedo: false canReopenClosedEditor: true canUndo: false codespaces.explorer.active: true codespaces.explorer.canMove: false codespaces.explorer.defaultViewLocation: true codespaces.explorerDetails.canMove: false codespaces.explorerDetails.defaultViewLocation: true config.azureFunctions.enableJavaRemoteDebugging: false config.azureFunctions.enableRemoteDebugging: false config.azureFunctions.showExplorer: true config.azureStorage.showExplorer: true config.breadcrumbs.enabled: true config.diffEditor.ignoreTrimWhitespace: true config.editor.columnSelection: false config.editor.minimap.enabled: false config.editor.renderControlCharacters: false config.editor.renderWhitespace: "boundary" config.editor.suggest.insertMode: "insert" config.emmet.triggerExpansionOnTab: false config.files.autoSave: "onFocusChange" config.git.allowForcePush: false config.git.allowNoVerifyCommit: false config.git.enabled: true config.git.openDiffOnClick: true config.git.showInlineOpenFileAction: true config.git.untrackedChanges: "mixed" config.gitlens.advanced.fileHistoryFollowsRenames: true config.gitlens.advanced.fileHistoryShowAllBranches: false config.gitlens.fileAnnotations.command: "blame+heatmap" config.gitlens.fileAnnotations.diffCommand: "blame" config.gitlens.menus.editorGroup.blame: true config.gitlens.menus.editorGroup.compare: false config.gitlens.menus.scm.authors: true config.gitlens.menus.scmGroup.compare: true config.gitlens.menus.scmGroup.openClose: true config.gitlens.menus.scmGroup.stash: true config.gitlens.menus.scmGroupInline.stash: true config.gitlens.menus.scmItem.clipboard: true config.gitlens.menus.scmItem.compare: true config.gitlens.menus.scmItem.history: true config.gitlens.menus.scmItem.remote: true config.gitlens.menus.scmItem.stash: true config.gitlens.views.branches.avatars: true config.gitlens.views.branches.branches.layout: "tree" config.gitlens.views.branches.files.layout: "auto" config.gitlens.views.commits.avatars: true config.gitlens.views.commits.files.layout: "auto" config.gitlens.views.commits.showBranchComparison: "working" config.gitlens.views.compare.avatars: true config.gitlens.views.compare.enabled: undefined config.gitlens.views.compare.files.layout: "auto" config.gitlens.views.contributors.avatars: true config.gitlens.views.contributors.files.layout: "auto" config.gitlens.views.fileHistory.avatars: true config.gitlens.views.lineHistory.avatars: true config.gitlens.views.lineHistory.enabled: false config.gitlens.views.remotes.avatars: true config.gitlens.views.remotes.branches.layout: "tree" config.gitlens.views.remotes.files.layout: "auto" config.gitlens.views.repositories.autoRefresh: true config.gitlens.views.repositories.avatars: true config.gitlens.views.repositories.enabled: false config.gitlens.views.repositories.files.layout: "auto" config.gitlens.views.search.avatars: true config.gitlens.views.search.files.layout: "auto" config.gitlens.views.stashes.files.layout: "auto" config.gitlens.views.tags.avatars: true config.gitlens.views.tags.branches.layout: "tree" config.gitlens.views.tags.files.layout: "auto" config.gitlens.views.welcome.enabled: true config.remote.SSH.enableWebAccess: undefined config.remote.SSH.useLocalServer: true config.window.nativeTabs: false config.workbench.activityBar.visible: true config.workbench.editor.enablePreview: false config.workbench.editor.showTabs: false config.workbench.sideBar.location: "left" config.workbench.statusBar.visible: true conflictsSources: "" customEditors: "" customExecutionSupported: true debugConfigurationType: "node" debugSetVariableSupported: false debugState: "inactive" debugUx: "default" debuggersAvailable: true detailsContainers.canMove: false detailsContainers.defaultViewLocation: true dirtyWorkingCopies: false dockerContainers.active: true dockerContainers.canMove: true dockerContainers.defaultViewLocation: true dockerImages.active: true dockerImages.canMove: true dockerImages.defaultViewLocation: true dockerNetworks.active: true dockerNetworks.canMove: true dockerNetworks.defaultViewLocation: true dockerRegistries.active: true dockerRegistries.canMove: true dockerRegistries.defaultViewLocation: true dockerVolumes.active: true dockerVolumes.canMove: true dockerVolumes.defaultViewLocation: true editorAreaVisible: true editorColumnSelection: false editorFocus: false editorHasCodeActionsProvider: true editorHasCodeLensProvider: false editorHasCompletionItemProvider: true editorHasDeclarationProvider: false editorHasDefinitionProvider: false editorHasDocumentFormattingProvider: false editorHasDocumentHighlightProvider: false editorHasDocumentSelectionFormattingProvider: false editorHasDocumentSymbolProvider: false editorHasHoverProvider: true editorHasImplementationProvider: false editorHasMultipleDocumentFormattingProvider: false editorHasMultipleDocumentSelectionFormattingProvider: false editorHasMultipleSelections: false editorHasReferenceProvider: false editorHasRenameProvider: false editorHasSelection: false editorHasSignatureHelpProvider: false editorHasTypeDefinitionProvider: false editorHoverVisible: false editorId: "vs.editor.ICodeEditor:5" editorIsOpen: true editorLangId: "scminput" editorReadonly: false editorSimpleInput: true editorTabMovesFocus: false editorTextFocus: false emptyWorkspaceSupport: true enableSyncActivityViews: false enableSyncMergesView: false explorerResourceAvailableEditorIds: "" explorerResourceIsFolder: true explorerResourceIsRoot: true explorerResourceMoveableToTrash: false explorerResourceReadonly: false explorerViewletCompressedFirstFocus: true explorerViewletCompressedFocus: false explorerViewletCompressedLastFocus: true explorerViewletVisible: false expressionSelected: false extensions.recommendedList.canMove: false extensions.recommendedList.defaultViewLocation: true focusedCustomEditorIsEditable: false focusedSessionIsAttach: false focusedView: "workbench.scm" forwardedPortsViewEnabled: true git.state: "initialized" gitOpenRepositoryCount: "1" gitRebaseInProgress: false github:activePullRequest.canMove: true github:activePullRequest.defaultViewLocation: true github:authenticated: true github:focusedReview: false github:hasGitHubRemotes: true github:inReviewMode: false github:initialized: true github:login.canMove: true github:login.defaultViewLocation: true gitlens.views.branches.active: true gitlens.views.branches.canMove: true gitlens.views.branches.defaultViewLocation: true gitlens.views.commits.active: true gitlens.views.commits.canMove: true gitlens.views.commits.defaultViewLocation: true gitlens.views.compare.active: true gitlens.views.compare.canMove: true gitlens.views.compare.defaultViewLocation: true gitlens.views.contributors.active: true gitlens.views.contributors.canMove: true gitlens.views.contributors.defaultViewLocation: true gitlens.views.fileHistory.active: true gitlens.views.fileHistory.canMove: true gitlens.views.fileHistory.defaultViewLocation: true gitlens.views.lineHistory.canMove: true gitlens.views.lineHistory.defaultViewLocation: true gitlens.views.remotes.active: true gitlens.views.remotes.canMove: true gitlens.views.remotes.defaultViewLocation: true gitlens.views.repositories.canMove: true gitlens.views.repositories.defaultViewLocation: true gitlens.views.search.active: true gitlens.views.search.canMove: true gitlens.views.search.defaultViewLocation: true gitlens.views.stashes.active: true gitlens.views.stashes.canMove: true gitlens.views.stashes.defaultViewLocation: true gitlens.views.tags.active: true gitlens.views.tags.canMove: true gitlens.views.tags.defaultViewLocation: true gitlens.views.welcome.active: true gitlens.views.welcome.canMove: true gitlens.views.welcome.defaultViewLocation: true gitlens:activeFileStatus: "tracked|blameable|revision|remotes|" gitlens:canToggleCodeLens: true gitlens:enabled: true gitlens:hasRemotes: true gitlens:views:compare:keepResults: false gitlens:views:fileHistory:cursorFollowing: null gitlens:views:fileHistory:editorFollowing: null gitlens:views:search:keepResults: false gitlens:vsls: false hasGallery: true hasLocalServer: true hasNextTabstop: false hasOtherSuggestions: false hasPrevTabstop: false hasRemoteServer: false hasSymbols: false hasWebFileSystemAccess: false hasWebServer: false inCommandsPicker: false inDebugMode: false inFileSymbolsPicker: false inFilesPicker: false inQuickOpen: false inSnippetMode: false inZenMode: false inputFocus: true isCenteredLayout: false isComposing: false isDevelopment: false isFileSystemResource: true isFullscreen: false isInEmbeddedEditor: false isLinux: false isMac: true isMacNative: true isWeb: false isWindows: false issues:github.active: true issues:github.canMove: true issues:github.defaultViewLocation: true jsBrowserBreakpoints.canMove: true jsBrowserBreakpoints.defaultViewLocation: true jumpToCursorSupported: false listAutomaticKeyboardNavigation: true listSupportsKeyboardNavigation: true loadedScriptsSupported: false multiCursorModifier: "ctrlCmd" multipleEditorGroups: false notificationCenterVisible: false notificationToastsVisible: false npm.active: true npm.canMove: true npm.defaultViewLocation: true openEditorsVisible: true outline.active: true outline.canMove: true outline.defaultViewLocation: true panelFocus: false panelPosition: "bottom" pr:github.active: true pr:github.canMove: true pr:github.defaultViewLocation: true prStatus:github.canMove: true prStatus:github.defaultViewLocation: true problemsFilterFocus: false problemsView.smallLayout: false processExecutionSupported: true refactorPreview.canMove: false refactorPreview.defaultViewContainerLocation: true refactorPreview.defaultViewLocation: true refactorPreview.enabled: false references-view.tree.canMove: true references-view.tree.defaultViewLocation: true remote-containers:showDetails: false remoteConnectionState: "" remoteName: "" resource: u {scheme: "file", authority: "", path: "/Users/jrieken/Code/vscode", query: "", fragment: "", …} resourceDirname: "/Users/jrieken/Code" resourceExtname: "" resourceFilename: "vscode" resourceLangId: null resourcePath: "/Users/jrieken/Code/vscode" resourceScheme: "file" resourceSet: true restartFrameSupported: false saveConflictResolutionContext: false scm.providerCount: 1 scmInputIsInFirstLine: true scmInputIsInLastLine: true scmProvider: "scm0" scmRepository: h {provider: p, disposable: {…}, storageService: e, _selected: true, _onDidChangeSelection: c, …} shellExecutionSupported: true sideBarFocus: true sideBarVisible: true splitEditorsVertically: false sshHosts.active: true sshHosts.canMove: false sshHosts.defaultViewLocation: true stepBackSupported: false stepIntoTargetsSupported: false suggestWidgetDetailsVisible: false suggestWidgetMultipleSuggestions: false suggestWidgetVisible: false suggestionCanResolve: true suggestionHasInsertAndReplaceRange: false suggestionMakesTextEdit: true syncEnabled: false syncStatus: "idle" targetsContainers.active: true targetsContainers.canMove: false targetsContainers.defaultViewLocation: true taskRunning: false terminal.active: true terminal.canMove: true terminal.defaultViewContainerLocation: true terminal.defaultViewLocation: true terminal.visible: false terminalA11yTreeFocus: false terminalFindFocused: false terminalFindInputFocused: false terminalFindVisible: false terminalFocus: false terminalIsOpen: false terminalProcessSupported: true terminalTextSelected: false textCompareEditorActive: true textCompareEditorVisible: true textInputFocus: true timeline.active: true timeline.canMove: true timeline.defaultViewLocation: false timelineHasProvider: true treeView.azFuncTree.enableCollapseAll: false treeView.azFuncTree.enableRefresh: false treeView.azFuncTree.toggleCollapseAll: false treeView.azureStorage.enableCollapseAll: false treeView.azureStorage.enableRefresh: false treeView.azureStorage.toggleCollapseAll: false treeView.codespaces.explorer.enableCollapseAll: false treeView.codespaces.explorer.enableRefresh: false treeView.codespaces.explorer.toggleCollapseAll: false treeView.codespaces.explorerDetails.enableCollapseAll: false treeView.codespaces.explorerDetails.enableRefresh: false treeView.codespaces.explorerDetails.toggleCollapseAll: false treeView.detailsContainers.enableCollapseAll: false treeView.detailsContainers.enableRefresh: false treeView.detailsContainers.toggleCollapseAll: false treeView.dockerContainers.enableCollapseAll: false treeView.dockerContainers.enableRefresh: false treeView.dockerContainers.toggleCollapseAll: false treeView.dockerImages.enableCollapseAll: false treeView.dockerImages.enableRefresh: false treeView.dockerImages.toggleCollapseAll: false treeView.dockerNetworks.enableCollapseAll: false treeView.dockerNetworks.enableRefresh: false treeView.dockerNetworks.toggleCollapseAll: false treeView.dockerRegistries.enableCollapseAll: true treeView.dockerRegistries.enableRefresh: false treeView.dockerRegistries.toggleCollapseAll: false treeView.dockerVolumes.enableCollapseAll: false treeView.dockerVolumes.enableRefresh: false treeView.dockerVolumes.toggleCollapseAll: false treeView.github:login.enableCollapseAll: false treeView.github:login.enableRefresh: false treeView.github:login.toggleCollapseAll: false treeView.gitlens.views.branches.enableCollapseAll: true treeView.gitlens.views.branches.enableRefresh: false treeView.gitlens.views.branches.toggleCollapseAll: false treeView.gitlens.views.commits.enableCollapseAll: true treeView.gitlens.views.commits.enableRefresh: false treeView.gitlens.views.commits.toggleCollapseAll: false treeView.gitlens.views.compare.enableCollapseAll: true treeView.gitlens.views.compare.enableRefresh: false treeView.gitlens.views.compare.toggleCollapseAll: false treeView.gitlens.views.contributors.enableCollapseAll: true treeView.gitlens.views.contributors.enableRefresh: false treeView.gitlens.views.contributors.toggleCollapseAll: false treeView.gitlens.views.fileHistory.enableCollapseAll: true treeView.gitlens.views.fileHistory.enableRefresh: false treeView.gitlens.views.fileHistory.toggleCollapseAll: false treeView.gitlens.views.lineHistory.enableCollapseAll: false treeView.gitlens.views.lineHistory.enableRefresh: false treeView.gitlens.views.lineHistory.toggleCollapseAll: false treeView.gitlens.views.remotes.enableCollapseAll: true treeView.gitlens.views.remotes.enableRefresh: false treeView.gitlens.views.remotes.toggleCollapseAll: false treeView.gitlens.views.repositories.enableCollapseAll: false treeView.gitlens.views.repositories.enableRefresh: false treeView.gitlens.views.repositories.toggleCollapseAll: false treeView.gitlens.views.search.enableCollapseAll: true treeView.gitlens.views.search.enableRefresh: false treeView.gitlens.views.search.toggleCollapseAll: false treeView.gitlens.views.stashes.enableCollapseAll: true treeView.gitlens.views.stashes.enableRefresh: false treeView.gitlens.views.stashes.toggleCollapseAll: false treeView.gitlens.views.tags.enableCollapseAll: true treeView.gitlens.views.tags.enableRefresh: false treeView.gitlens.views.tags.toggleCollapseAll: false treeView.gitlens.views.welcome.enableCollapseAll: false treeView.gitlens.views.welcome.enableRefresh: false treeView.gitlens.views.welcome.toggleCollapseAll: false treeView.issues:github.enableCollapseAll: true treeView.issues:github.enableRefresh: false treeView.issues:github.toggleCollapseAll: false treeView.jsBrowserBreakpoints.enableCollapseAll: false treeView.jsBrowserBreakpoints.enableRefresh: false treeView.jsBrowserBreakpoints.toggleCollapseAll: false treeView.npm.enableCollapseAll: true treeView.npm.enableRefresh: false treeView.npm.toggleCollapseAll: false treeView.pr:github.enableCollapseAll: true treeView.pr:github.enableRefresh: false treeView.pr:github.toggleCollapseAll: false treeView.prStatus:github.enableCollapseAll: true treeView.prStatus:github.enableRefresh: false treeView.prStatus:github.toggleCollapseAll: false treeView.references-view.tree.enableCollapseAll: false treeView.references-view.tree.enableRefresh: false treeView.references-view.tree.toggleCollapseAll: false treeView.sshHosts.enableCollapseAll: false treeView.sshHosts.enableRefresh: false treeView.sshHosts.toggleCollapseAll: false treeView.targetsContainers.enableCollapseAll: false treeView.targetsContainers.enableRefresh: false treeView.targetsContainers.toggleCollapseAll: false treeView.vscode-docker.views.dockerContexts.enableCollapseAll: false treeView.vscode-docker.views.dockerContexts.enableRefresh: false treeView.vscode-docker.views.dockerContexts.toggleCollapseAll: false treeView.vscode-docker.views.help.enableCollapseAll: false treeView.vscode-docker.views.help.enableRefresh: false treeView.vscode-docker.views.help.toggleCollapseAll: false treeView.workbench.views.sync.localActivity.enableCollapseAll: true treeView.workbench.views.sync.localActivity.enableRefresh: true treeView.workbench.views.sync.localActivity.toggleCollapseAll: false treeView.workbench.views.sync.machines.enableCollapseAll: false treeView.workbench.views.sync.machines.enableRefresh: true treeView.workbench.views.sync.machines.toggleCollapseAll: false treeView.workbench.views.sync.merges.enableCollapseAll: false treeView.workbench.views.sync.merges.enableRefresh: false treeView.workbench.views.sync.merges.toggleCollapseAll: false treeView.workbench.views.sync.remoteActivity.enableCollapseAll: true treeView.workbench.views.sync.remoteActivity.enableRefresh: true treeView.workbench.views.sync.remoteActivity.toggleCollapseAll: false typescript.isManagedFile: true updateState: "idle" userDataSyncAccountStatus: "available" userDataSyncTurningOn: false vscode-docker.views.dockerContexts.active: true vscode-docker.views.dockerContexts.canMove: true vscode-docker.views.dockerContexts.defaultViewLocation: true vscode-docker.views.help.active: true vscode-docker.views.help.canMove: true vscode-docker.views.help.defaultViewLocation: true vscode-docker:aciContext: false vscode-docker:contextLocked: true vscode-docker:newCliPresent: true vscode-docker:newSdkContext: false vscode-js-profile-flame.realtime.canMove: true vscode-js-profile-flame.realtime.defaultViewLocation: true vsonline:command-enabled:addEnvironment: true vsonline:command-enabled:authCallbackForUITest: false vsonline:command-enabled:changeEnvironmentSettings: true vsonline:command-enabled:checkoutPRInEnvironment: true vsonline:command-enabled:connect: true vsonline:command-enabled:createDevContainer: true vsonline:command-enabled:createPlan: true vsonline:command-enabled:deleteEnvironment: true vsonline:command-enabled:deletePlan: true vsonline:command-enabled:disconnectEnvironment: true vsonline:command-enabled:disconnectSuspend: true vsonline:command-enabled:downloadExportedEnvironment: false vsonline:command-enabled:environmentsList: true vsonline:command-enabled:exportEnvironment: false vsonline:command-enabled:exportLogs: true vsonline:command-enabled:getAccessToken: false vsonline:command-enabled:getAzureToken: false vsonline:command-enabled:getExportEnvironmentUrl: false vsonline:command-enabled:getPorts: true vsonline:command-enabled:goHome: false vsonline:command-enabled:openInBrowser: true vsonline:command-enabled:openInInsiders: false vsonline:command-enabled:openInNewWindow: true vsonline:command-enabled:openInStable: false vsonline:command-enabled:openInVisualStudio: true vsonline:command-enabled:openPortInBrowser: true vsonline:command-enabled:portForwarding: true vsonline:command-enabled:refresh: true vsonline:command-enabled:registerLocalEnvironment: true vsonline:command-enabled:reloadServer: true vsonline:command-enabled:removeRecentFolder: true vsonline:command-enabled:restoreLocalEnvironment: true vsonline:command-enabled:selectPlan: true vsonline:command-enabled:selectShutdownEnvironment: true vsonline:command-enabled:shutdownEnvironment: true vsonline:command-enabled:signInAndUpdateEnvList: true vsonline:command-enabled:signOut: false vsonline:command-enabled:unregisterEnvironment: true vsonline:command-enabled:unshareServer: true vsonline:command-enabled:vmconnect: true vsonline:running-in-vsonline: false webviewHasOwnEditFunctions: false workbench.debug.breakPointsView.active: true workbench.debug.breakPointsView.canMove: true workbench.debug.breakPointsView.defaultViewLocation: true workbench.debug.callStackView.active: true workbench.debug.callStackView.canMove: true workbench.debug.callStackView.defaultViewLocation: true workbench.debug.loadedScriptsView.canMove: true workbench.debug.loadedScriptsView.defaultViewLocation: true workbench.debug.variablesView.active: true workbench.debug.variablesView.canMove: true workbench.debug.variablesView.defaultViewLocation: true workbench.debug.watchExpressionsView.active: true workbench.debug.watchExpressionsView.canMove: true workbench.debug.watchExpressionsView.defaultViewLocation: true workbench.debug.welcome.active: false workbench.debug.welcome.canMove: false workbench.debug.welcome.defaultViewLocation: true workbench.explorer.fileView.active: true workbench.explorer.fileView.canMove: false workbench.explorer.fileView.defaultViewLocation: true workbench.explorer.fileView.visible: false workbench.explorer.openEditorsView.active: true workbench.explorer.openEditorsView.canMove: true workbench.explorer.openEditorsView.defaultViewLocation: true workbench.panel.markers.defaultViewContainerLocation: true workbench.panel.markers.view.active: true workbench.panel.markers.view.canMove: true workbench.panel.markers.view.defaultViewLocation: true workbench.panel.markers.view.visible: false workbench.panel.output.active: true workbench.panel.output.canMove: true workbench.panel.output.defaultViewContainerLocation: true workbench.panel.output.defaultViewLocation: true workbench.panel.repl.defaultViewContainerLocation: true workbench.panel.repl.view.active: true workbench.panel.repl.view.canMove: true workbench.panel.repl.view.defaultViewLocation: true workbench.scm.active: true workbench.scm.canMove: true workbench.scm.defaultViewLocation: true workbench.scm.repositories.active: true workbench.scm.repositories.canMove: true workbench.scm.repositories.defaultViewLocation: true workbench.scm.visible: true workbench.view.debug.defaultViewContainerLocation: true workbench.view.explorer.defaultViewContainerLocation: true workbench.view.extension.azure.defaultViewContainerLocation: true workbench.view.extension.dockerView.defaultViewContainerLocation: true workbench.view.extension.github-pull-requests.defaultViewContainerLocation: true workbench.view.extension.gitlens.defaultViewContainerLocation: true workbench.view.extension.references-view.defaultViewContainerLocation: true workbench.view.extension.test.defaultViewContainerLocation: true workbench.view.extensions.defaultViewContainerLocation: true workbench.view.remote.defaultViewContainerLocation: true workbench.view.scm.defaultViewContainerLocation: true workbench.view.search.active: true workbench.view.search.canMove: true workbench.view.search.defaultViewContainerLocation: true workbench.view.search.defaultViewLocation: true workbench.view.sync.defaultViewContainerLocation: true workbench.views.extensions.builtinFeatureExtensions.canMove: false workbench.views.extensions.builtinFeatureExtensions.defaultViewLocation: true workbench.views.extensions.builtinProgrammingLanguageExtensions.canMove: false workbench.views.extensions.builtinProgrammingLanguageExtensions.defaultViewLocation: true workbench.views.extensions.builtinThemeExtensions.canMove: false workbench.views.extensions.builtinThemeExtensions.defaultViewLocation: true workbench.views.extensions.disabled.canMove: false workbench.views.extensions.disabled.defaultViewLocation: true workbench.views.extensions.enabled.canMove: false workbench.views.extensions.enabled.defaultViewLocation: true workbench.views.extensions.installed.canMove: false workbench.views.extensions.installed.defaultViewLocation: true workbench.views.extensions.marketplace.canMove: false workbench.views.extensions.marketplace.defaultViewLocation: true workbench.views.extensions.otherRecommendations.canMove: false workbench.views.extensions.otherRecommendations.defaultViewLocation: true workbench.views.extensions.popular.canMove: false workbench.views.extensions.popular.defaultViewLocation: true workbench.views.extensions.searchBuiltin.canMove: false workbench.views.extensions.searchBuiltin.defaultViewLocation: true workbench.views.extensions.searchDisabled.canMove: false workbench.views.extensions.searchDisabled.defaultViewLocation: true workbench.views.extensions.searchEnabled.canMove: false workbench.views.extensions.searchEnabled.defaultViewLocation: true workbench.views.extensions.searchInstalled.canMove: false workbench.views.extensions.searchInstalled.defaultViewLocation: true workbench.views.extensions.searchOutdated.canMove: false workbench.views.extensions.searchOutdated.defaultViewLocation: true workbench.views.extensions.workspaceRecommendations.canMove: false workbench.views.extensions.workspaceRecommendations.defaultViewLocation: true workbench.views.service.panel.2f9d96b2-849b-49de-8d54-a0bc2dde43ee.defaultViewContainerLocation: true workbench.views.sync.localActivity.canMove: false workbench.views.sync.localActivity.defaultViewLocation: true workbench.views.sync.machines.canMove: false workbench.views.sync.machines.defaultViewLocation: true workbench.views.sync.merges.canMove: false workbench.views.sync.merges.defaultViewLocation: true workbench.views.sync.remoteActivity.canMove: false workbench.views.sync.remoteActivity.defaultViewLocation: true workbenchState: "folder" workspaceFolderCount: 1 workspaceFolderRecommendations: true workspaceRecommendations: false ```
joaomoreno commented 3 years ago

That context key list makes me

gif

joaomoreno commented 3 years ago

@meganrogge We gotta tighten up those when clauses for our UpArrow and DownArrow commands, and make sure they are only handled when the editor has text focus. Let me know if you need some help there.

jrieken commented 3 years ago

and make sure they are only handled when the editor has text focus. Let me know if you need some help there.

You also need to know if the suggest widget shows or not because the editor keeps focus when suggest shows.

joaomoreno commented 3 years ago

@jrieken That's why I said text focus 😉 I believe the editor has a method to return whether that's true.

jrieken commented 3 years ago

Wouldn't it then mean you cannot use the arrow keys to navigate between lines? Should this be a less prominent short cut?

joaomoreno commented 3 years ago

We already avoid that: our commands only get invoked when you're at the top of bottom of the viewport. This is the same that happens in Search, where there's already multi-line history aware input box.

joaomoreno commented 3 years ago

@meganrogge : https://github.com/microsoft/vscode/blob/8fcf778ba251131780f2a110d311161f39b97b03/src/vs/workbench/contrib/preferences/browser/preferences.contribution.ts#L568-L568