Native wayland support with newest electron

toger5 commented 3 years ago

Native wayland support would be great to run vs code without XWayland as described in https://github.com/microsoft/vscode/issues/77752.

Recently electron merged the chrome version with the ozone backend needed: https://github.com/electron/electron/pull/26022

This would allow for:

Kinetic scrolling (maybe this is more elegantly implemented on the elctron side)
Better touch support (touch scrolling)
better dpi scaling

deepak1556 commented 3 years ago

Thanks for opening the issue, agree with the benefits. The electron PR only got the basic compilation bits, there will be follow-up PRs to make it feature complete. VSCode will consume those binaries once they are available.

Upstream issue: https://github.com/electron/electron/issues/10915

kriive commented 3 years ago

Ozone has now landed in stable chrome (87) and in electron 11.0.1! I tried to compile vscode in electron-11.x.x branch, targeting electron 11.0.1. It compiles fine, but if I launch code as follows: code-oss --verbose --log=TRACE --enable-features=UseOzonePlatform --ozone-platform=wayland it shows a window for half a second and then crashes without any log. If I leave out the ozone cli commands vscode starts ok, without crashing.

EDIT: if I run it through gdb it now segfaults. [Thread 1 "code-oss" received signal SIGSEGV, Segmentation fault. 0x00005555576c1630 in ?? ()]

tyalie commented 3 years ago

There's also a Wayland debug flag (WAYLAND_DEBUG=1). Maybe you can find more there.

kriive commented 3 years ago

Thanks, this is the output given: WAYLAND_DEBUG=1 gdb --args ./code-oss --enable-features=UseOzonePlatform --ozone-platform=wayland https://pastebin.com/raw/ALk3JGz6

This is what happens

vially commented 3 years ago

As far as I'm aware the official builds for Electron 11 do not have Wayland support. The initial Wayland support (https://github.com/electron/electron/pull/26022) will only land in Electron 12.

So unless you're using an unofficial Electron build which has backported the Wayland fixes (e.g.: electron-ozone from the AUR) I think it's expected for the build to crash.

deepak1556 commented 3 years ago

@vially is correct, the initial experimental support landed only in electron 12, once I merge https://github.com/microsoft/vscode/pull/110759 to master , the exploration builds of vscode will start using electron 12. Can check again on the crash after that change.

12101111 commented 3 years ago

electron-11 compile from my Gentoo Linux overlay works without any issue ( And works with musl libc! )

kriive commented 3 years ago

Uhm, @12101111 are you launching vscode with --enable-features=UseOzonePlatform --ozone-platform=wayland?

kriive commented 3 years ago

@vially is correct, the initial experimental support landed only in electron 12, once I merge #110759 to master , the exploration builds of vscode will start using electron 12. Can check again on the crash after that change.

Good to know, thank you so much!

As far as I'm aware the official builds for Electron 11 do not have Wayland support. The initial Wayland support (electron/electron#26022) will only land in Electron 12.

So unless you're using an unofficial Electron build which has backported the Wayland fixes (e.g.: electron-ozone from the AUR) I think it's expected for the build to crash.

And thank you for the info!

12101111 commented 3 years ago

Uhm, @12101111 are you launching vscode with --enable-features=UseOzonePlatform --ozone-platform=wayland?

Yes

Pajn commented 3 years ago

Now that the exploration builds should support wayland, is there any place to download them? I can only find insider builds but if I'm understanding correctly those aren't on electron 12 yet?

kriive commented 3 years ago

If you're using RPM based systems, you can find the exploration builds here: https://packages.microsoft.com/yumrepos/vscode/

I guess that even the today's exploration build is still on 11.0.3. I managed to patch vscode to build an electron 12.0.0-beta.4 version and it kinda works (menubar doesn't).

EDIT: my patch is this one. Use it at your own risk

andrewnicolalde commented 3 years ago

I'm getting a weird crash when running code-exploration --enable-features=UseOzonePlatform --ozone-platform=wayland --verbose in Sway 1.5, though I'm unsure if this is just to be expected considering the new nature of wayland support.

code-exploration --enable-features=UseOzonePlatform --ozone-platform=wayland --verbose
Warning: 'enable-features' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'ozone-platform' is not in the list of known options, but still passed to Electron/Chromium.
(electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
[main 2020-12-13T14:35:28.324Z] Starting VS Code
[main 2020-12-13T14:35:28.325Z] from: /usr/share/code-exploration/resources/app
[main 2020-12-13T14:35:28.325Z] args: {
  _: [],
  diff: false,
  add: false,
  goto: false,
  'new-window': false,
  'reuse-window': false,
  wait: false,
  help: false,
  'list-extensions': false,
  'show-versions': false,
  version: false,
  verbose: true,
  status: false,
  'prof-startup': false,
  'disable-extensions': false,
  'disable-gpu': false,
  telemetry: false,
  debugRenderer: false,
  logExtensionHostCommunication: false,
  'skip-release-notes': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'skip-add-to-recently-opened': false,
  'unity-launch': false,
  'open-url': false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false,
  force: false,
  'do-not-sync': false,
  trace: false,
  'force-user-env': false,
  'force-disable-user-env': false,
  'open-devtools': false,
  'no-proxy-server': false,
  nolazy: false,
  'force-renderer-accessibility': false,
  'ignore-certificate-errors': false,
  'allow-insecure-localhost': false,
  logsPath: '/home/andrew/.config/Code - Exploration/logs/20201213T143528'
}
[main 2020-12-13T14:35:28.330Z] Resolving machine identifier...
[main 2020-12-13T14:35:28.331Z] Resolved machine identifier: bb3b0470594badc6a8aba91361ba24a17978b8bf84ea4bd0721c4174f673105f
[main 2020-12-13T14:35:28.343Z] [storage state.vscdb] open(/home/andrew/.config/Code - Exploration/User/globalStorage/state.vscdb, retryOnBusy: true)
[main 2020-12-13T14:35:28.345Z] lifecycle (main): phase changed (value: 2)
[main 2020-12-13T14:35:28.346Z] windowsManager#open
[main 2020-12-13T14:35:28.346Z] windowsManager#open pathsToOpen [
  {
    backupPath: '/home/andrew/.config/Code - Exploration/Backups/1607019742540',
    remoteAuthority: undefined
  }
]
[main 2020-12-13T14:35:28.346Z] window#validateWindowState: validating window state on 2 display(s) { mode: 1, x: 448, y: 145, width: 1024, height: 768 }
[main 2020-12-13T14:35:28.347Z] window#validateWindowState: multi-monitor working area { x: 0, y: 0, width: 3840, height: 2160 }
[main 2020-12-13T14:35:28.347Z] window#ctor: using window state { mode: 1, x: 448, y: 145, width: 1024, height: 768 }
[8243:1213/143528.366040:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.
[main 2020-12-13T14:35:28.399Z] windowsManager#open used window count 1 (workspacesToOpen: 0, foldersToOpen: 0, emptyToRestore: 1, emptyToOpen: 0)
[main 2020-12-13T14:35:28.400Z] lifecycle (main): phase changed (value: 3)
[main 2020-12-13T14:35:28.401Z] update#setState idle
[main 2020-12-13T14:35:28.401Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
(node:8213) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
[main 2020-12-13T14:35:28.459Z] [storage state.vscdb] getItems(): 54 rows
[main 2020-12-13T14:35:28.460Z] [storage state.vscdb] Trace (event): SELECT * FROM ItemTable
[main 2020-12-13T14:35:28.516Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[main 2020-12-13T14:35:28.560Z] [storage state.vscdb] updateItems(): insert(Map(3) {storage.serviceMachineId => 4f7c4aca-8d4a-4e7d-a6c5-e6a091df382e, telemetry.lastSessionDate => Sun, 13 Dec 2020 14:34:40 GMT, telemetry.currentSessionDate => Sun, 13 Dec 2020 14:35:28 GMT}), delete(Set(0) {})
[main 2020-12-13T14:35:28.560Z] [storage state.vscdb] Trace (event): BEGIN TRANSACTION
[main 2020-12-13T14:35:28.561Z] [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('storage.serviceMachineId','4f7c4aca-8d4a-4e7d-a6c5-e6a091df382e'),('telemetry.lastSessionDate','Sun, 13 Dec 2020 14:34:40 GMT'),('telemetry.currentSessionDate','Sun, 13 Dec 2020 14:35:28 GMT')
[main 2020-12-13T14:35:28.561Z] [storage state.vscdb] Trace (event): END TRANSACTION
[8213:1213/143528.799098:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] open(/home/andrew/.config/Code - Exploration/User/workspaceStorage/1607019742540/state.vscdb, retryOnBusy: true)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
(node:8275) Electron: Loading non-context-aware native module in renderer: '/usr/share/code-exploration/resources/app/node_modules.asar.unpacked/vscode-sqlite3/build/Release/sqlite.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
[8213:1213/143528.828713:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): PRAGMA user_version = 1;", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.853143:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): CREATE TABLE IF NOT EXISTS ItemTable (key TEXT UNIQUE ON CONFLICT REPLACE, value BLOB)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.853518:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): SELECT * FROM ItemTable", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.853570:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] getItems(): 20 rows", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.854459:INFO:CONSOLE(1779)] "%cTRACE color: #888 lifecycle: starting up (startup kind: 1)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.854487:INFO:CONSOLE(1779)] "%cTRACE color: #888 lifecycle: phase changed (value: 2)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.856587:INFO:CONSOLE(1779)] "%cTRACE color: #888 Skipping initializing user data in desktop", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.923841:INFO:CONSOLE(1779)] "%cTRACE color: #888 Layout#layout, height: 1012, width: 622", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143528.969421:INFO:CONSOLE(1779)] "%cTRACE color: #888 workbench configuration {"_":[],"verbose":true,"logsPath":"/home/andrew/.config/Code - Exploration/logs/20201213T143528","appRoot":"/usr/share/code-exploration/resources/app","machineId":"bb3b0470594badc6a8aba91361ba24a17978b8bf84ea4bd0721c4174f673105f","nodeCachedDataDir":"/home/andrew/.config/Code - Exploration/CachedData/d530b3b27d0f52a0290cdb53031ba60f02927c60","mainPid":8213,"execPath":"/usr/share/code-exploration/code-exploration","userEnv":{"VSCODE_IPC_HOOK":"/run/user/1000/vscode-7b2f73f9-1.53.0-exploration-main.sock","VSCODE_NLS_CONFIG":"{\"locale\":\"en-us\",\"availableLanguages\":{},\"_languagePackSupport\":true}"},"isInitialStartup":true,"backupPath":"/home/andrew/.config/Code - Exploration/Backups/1607019742540","windowId":1,"sessionId":"window:1","logLevel":0,"colorScheme":{"dark":false,"highContrast":false},"autoDetectHighContrast":true,"perfEntries":["main:started",1607870128215,"main:appReady",1607870128271,"willLoadMainBundle",1607870128272,"didLoadMainBundle",1607870128313,"main:loadWindow",1607870128394],"partsSplashPath":"/home/andrew/.config/Code - Exploration/rapid_render.json","os":{"release":"5.9.13-200.fc33.x86_64"}}", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.028412:INFO:CONSOLE(1779)] "%cTRACE color: #888 lifecycle: phase changed (value: 3)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.028974:INFO:CONSOLE(1779)] "%cTRACE color: #888 Created Spdlogger", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
(node:8275) Electron: Loading non-context-aware native module in renderer: '/usr/share/code-exploration/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
[main 2020-12-13T14:35:29.065Z] menubarService#updateMenubar 1
[8213:1213/143529.071797:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.228913:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Initializing accounts", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.228948:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Getting accounts for microsoft", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:29.231Z] RequestService#request https://update.code.visualstudio.com/api/update/linux-x64/exploration/d530b3b27d0f52a0290cdb53031ba60f02927c60
[main 2020-12-13T14:35:29.240Z] [storage state.vscdb] updateItems(): insert(Map(11) {workbench.activity.placeholderViewlets => [{"id":"workbench.view.explorer","themeIcon":{"id":"explorer-view-icon"},"name":"Explorer","views":[{},{"when":"timelineHasProvider"}]},{"id":"workbench.view.search","themeIcon":{"id":"search-view-icon"},"name":"Search","views":[{}]},{"id":"workbench.view.scm","themeIcon":{"id":"source-control-view-icon"},"name":"Source Control","views":[{"when":"scm.providerCount && scm.providerCount != '0'"},{}]},{"id":"workbench.view.debug","themeIcon":{"id":"run-view-icon"},"name":"Run","views":[{"when":"debugUx == 'simple'"},{"when":"debugUx == 'default'"},{"when":"debugUx == 'default'"},{"when":"debugUx == 'default'"},{"when":"loadedScriptsSupported && debugUx == 'default'"},{"when":"breakpointsExist || debugUx == 'default'"}]},{"id":"workbench.view.remote","themeIcon":{"id":"remote-explorer-view-icon"},"name":"Remote Explorer","views":[]},{"id":"workbench.view.extensions","themeIcon":{"id":"extensions-view-icon"},"name":"Extensions","views":[{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"recommendedExtensions && workbenchState != 'empty'"},{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"recommendedExtensions"},{"when":"defaultExtensionViews && !config.extensions.showRecommendationsOnlyOnDemand"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"searchMarketplaceExtensions"},{"when":"searchInstalledExtensions"},{"when":"searchEnabledExtensions"},{"when":"searchDisabledExtensions"},{"when":"searchOutdatedExtensions"},{"when":"searchBuiltInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"}]},{"id":"workbench.view.extension.references-view"},{"id":"workbench.view.sync","themeIcon":{"id":"settings-sync-view-icon"},"name":"Settings Sync","views":[]}], nps/lastSessionDate => Sun Dec 13 2020, nps/sessionCount => 6, cpp.1.lastSessionDate => Sun Dec 13 2020, cpp.1.sessionCount => 6, java.2.lastSessionDate => Sun Dec 13 2020, java.2.sessionCount => 6, javascript.1.lastSessionDate => Sun Dec 13 2020, javascript.1.sessionCount => 6, typescript.1.lastSessionDate => Sun Dec 13 2020, typescript.1.sessionCount => 6}), delete(Set(0) {})
[main 2020-12-13T14:35:29.241Z] [storage state.vscdb] Trace (event): BEGIN TRANSACTION
[main 2020-12-13T14:35:29.241Z] [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('workbench.activity.placeholderViewlets','[{"id":"workbench.view.explorer","themeIcon":{"id":"explorer-view-icon"},"name":"Explorer","views":[{},{"when":"timelineHasProvider"}]},{"id":"workbench.view.search","themeIcon":{"id":"search-view-icon"},"name":"Search","views":[{}]},{"id":"workbench.view.scm","themeIcon":{"id":"source-control-view-icon"},"name":"Source Control","views":[{"when":"scm.providerCount && scm.providerCount != ''0''"},{}]},{"id":"workbench.view.debug","themeIcon":{"id":"run-view-icon"},"name":"Run","views":[{"when":"debugUx == ''simple''"},{"when":"debugUx == ''default''"},{"when":"debugUx == ''default''"},{"when":"debugUx == ''default''"},{"when":"loadedScriptsSupported && debugUx == ''default''"},{"when":"breakpointsExist || debugUx == ''default''"}]},{"id":"workbench.view.remote","themeIcon":{"id":"remote-explorer-view-icon"},"name":"Remote Explorer","views":[]},{"id":"workbench.view.extensions","themeIcon":{"id":"extensions-view-icon"},"name":"Extensions","views":[{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"recommendedExtensions && workbenchState != ''empty''"},{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"recommendedExtensions"},{"when":"defaultExtensionViews && !config.extensions.showRecommendationsOnlyOnDemand"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"searchMarketplaceExtensions"},{"when":"searchInstalledExtensions"},{"when":"searchEnabledExtensions"},{"when":"searchDisabledExtensions"},{"when":"searchOutdatedExtensions"},{"when":"searchBuiltInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"}]},{"id":"workbench.view.extension.references-view"},{"id":"workbench.view.sync","themeIcon":{"id":"settings-sync-view-icon"},"name":"Settings Sync","views":[]}]'),('nps/lastSessionDate','Sun Dec 13 2020'),('nps/sessionCount','6'),('cpp.1.lastSessionDate','Sun Dec 13 2020'),('cpp.1.sessionCount','6'),('java.2.lastSessionDate','Sun Dec 13 2020'),('java.2.sessionCount','6'),('javascript.1.lastSessionDate','Sun Dec 13 2020'),('javascript.1.sessionCount','6'),('typescript.1.lastSessionDate','Sun Dec 13 2020'),('typescript.1.sessionCount','6')
[main 2020-12-13T14:35:29.242Z] [storage state.vscdb] Trace (event): END TRANSACTION
[8213:1213/143529.244652:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.244725:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.245881:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/output_1_20201213T143528", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:29.426Z] [storage state.vscdb] updateItems(): insert(Map(1) {workbench.activity.placeholderViewlets => [{"id":"workbench.view.explorer","themeIcon":{"id":"explorer-view-icon"},"name":"Explorer","views":[{"when":"openEditorsVisible"},{},{},{"when":"timelineHasProvider"},{}]},{"id":"workbench.view.search","themeIcon":{"id":"search-view-icon"},"name":"Search","views":[{}]},{"id":"workbench.view.scm","themeIcon":{"id":"source-control-view-icon"},"name":"Source Control","views":[{"when":"scm.providerCount && scm.providerCount != '0'"},{}]},{"id":"workbench.view.debug","themeIcon":{"id":"run-view-icon"},"name":"Run","views":[{"when":"debugUx == 'simple'"},{"when":"debugUx == 'default'"},{"when":"debugUx == 'default'"},{"when":"debugUx == 'default'"},{"when":"loadedScriptsSupported && debugUx == 'default'"},{"when":"breakpointsExist || debugUx == 'default'"},{"when":"debugConfigurationType == 'pwa-chrome'"}]},{"id":"workbench.view.remote","themeIcon":{"id":"remote-explorer-view-icon"},"name":"Remote Explorer","views":[]},{"id":"workbench.view.extensions","themeIcon":{"id":"extensions-view-icon"},"name":"Extensions","views":[{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"recommendedExtensions && workbenchState != 'empty'"},{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"recommendedExtensions"},{"when":"defaultExtensionViews && !config.extensions.showRecommendationsOnlyOnDemand"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"searchMarketplaceExtensions"},{"when":"searchInstalledExtensions"},{"when":"searchEnabledExtensions"},{"when":"searchDisabledExtensions"},{"when":"searchOutdatedExtensions"},{"when":"searchBuiltInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"}]},{"id":"workbench.view.extension.references-view","iconUrl":{"$mid":1,"path":"/usr/share/code-exploration/resources/app/extensions/ms-vscode.references-view/media/container-icon.svg","scheme":"file"},"name":"References","views":[{"when":"reference-list.isActive"}]},{"id":"workbench.view.sync","themeIcon":{"id":"settings-sync-view-icon"},"name":"Settings Sync","views":[{"when":"enableSyncMergesView"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == 'available' && syncStatus != 'uninitialized'"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == 'available' && syncStatus != 'uninitialized'"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == 'available' && syncStatus != 'uninitialized'"}]}]}), delete(Set(0) {})
[main 2020-12-13T14:35:29.427Z] [storage state.vscdb] Trace (event): BEGIN TRANSACTION
[main 2020-12-13T14:35:29.427Z] [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('workbench.activity.placeholderViewlets','[{"id":"workbench.view.explorer","themeIcon":{"id":"explorer-view-icon"},"name":"Explorer","views":[{"when":"openEditorsVisible"},{},{},{"when":"timelineHasProvider"},{}]},{"id":"workbench.view.search","themeIcon":{"id":"search-view-icon"},"name":"Search","views":[{}]},{"id":"workbench.view.scm","themeIcon":{"id":"source-control-view-icon"},"name":"Source Control","views":[{"when":"scm.providerCount && scm.providerCount != ''0''"},{}]},{"id":"workbench.view.debug","themeIcon":{"id":"run-view-icon"},"name":"Run","views":[{"when":"debugUx == ''simple''"},{"when":"debugUx == ''default''"},{"when":"debugUx == ''default''"},{"when":"debugUx == ''default''"},{"when":"loadedScriptsSupported && debugUx == ''default''"},{"when":"breakpointsExist || debugUx == ''default''"},{"when":"debugConfigurationType == ''pwa-chrome''"}]},{"id":"workbench.view.remote","themeIcon":{"id":"remote-explorer-view-icon"},"name":"Remote Explorer","views":[]},{"id":"workbench.view.extensions","themeIcon":{"id":"extensions-view-icon"},"name":"Extensions","views":[{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"recommendedExtensions && workbenchState != ''empty''"},{"when":"defaultExtensionViews && !hasInstalledExtensions"},{"when":"recommendedExtensions"},{"when":"defaultExtensionViews && !config.extensions.showRecommendationsOnlyOnDemand"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"defaultExtensionViews && hasInstalledExtensions"},{"when":"searchMarketplaceExtensions"},{"when":"searchInstalledExtensions"},{"when":"searchEnabledExtensions"},{"when":"searchDisabledExtensions"},{"when":"searchOutdatedExtensions"},{"when":"searchBuiltInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"},{"when":"builtInExtensions"}]},{"id":"workbench.view.extension.references-view","iconUrl":{"$mid":1,"path":"/usr/share/code-exploration/resources/app/extensions/ms-vscode.references-view/media/container-icon.svg","scheme":"file"},"name":"References","views":[{"when":"reference-list.isActive"}]},{"id":"workbench.view.sync","themeIcon":{"id":"settings-sync-view-icon"},"name":"Settings Sync","views":[{"when":"enableSyncMergesView"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == ''available'' && syncStatus != ''uninitialized''"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == ''available'' && syncStatus != ''uninitialized''"},{"when":"enableSyncActivityViews && userDataSyncAccountStatus == ''available'' && syncStatus != ''uninitialized''"}]}]')
[8213:1213/143529.427878:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:29.427Z] [storage state.vscdb] Trace (event): END TRANSACTION
[8213:1213/143529.476183:INFO:CONSOLE(1779)] "%cTRACE color: #888 CommandService#executeCommand extension.js-debug.clearAutoAttachVariables", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.476609:INFO:CONSOLE(1779)] "%cTRACE color: #888 CommandService#executeCommand setContext", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.476743:INFO:CONSOLE(1779)] "%cTRACE color: #888 CommandService#executeCommand setContext", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.479744:INFO:CONSOLE(1779)] "%cTRACE color: #888 CommandService#executeCommand setContext", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.486441:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/exthost1", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.569346:INFO:CONSOLE(1779)] "%cTRACE color: #888 MainThreadTreeViews#$registerTreeViewDataProvider jsBrowserBreakpoints [object Object]", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.573886:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Updated accounts for microsoft", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.573918:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Getting accounts for github", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.573943:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.576646:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] updateItems(): insert(Map(1) {terminal.integrated.environmentVariableCollections => []}), delete(Set(0) {})", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.577532:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): BEGIN TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.577692:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('terminal.integrated.environmentVariableCollections','[]')", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.578160:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): END TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.596771:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Updated accounts for github", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:29.697Z] menubarService#updateMenubar 1
[8213:1213/143529.709350:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.898808:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.898957:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.899190:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/output_1_20201213T143528", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143529.899273:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/exthost1", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.577391:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] updateItems(): insert(Map(1) {terminal.integrated.environmentVariableCollections => [{"extensionIdentifier":"vscode.git","collection":[["VSCODE_GIT_IPC_HANDLE",{"value":"/run/user/1000/vscode-git-057dd012a2.sock","type":1}],["GIT_ASKPASS",{"value":"/usr/share/code-exploration/resources/app/extensions/git/dist/askpass.sh","type":1}],["VSCODE_GIT_ASKPASS_NODE",{"value":"/usr/share/code-exploration/code-exploration","type":1}],["VSCODE_GIT_ASKPASS_MAIN",{"value":"/usr/share/code-exploration/resources/app/extensions/git/dist/askpass-main.js","type":1}]]}]}), delete(Set(0) {})", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.578409:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.578925:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): BEGIN TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.579468:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('terminal.integrated.environmentVariableCollections','[{"extensionIdentifier":"vscode.git","collection":[["VSCODE_GIT_IPC_HANDLE",{"value":"/run/user/1000/vscode-git-057dd012a2.sock","type":1}],["GIT_ASKPASS",{"value":"/usr/share/code-exploration/resources/app/extensions/git/dist/askpass.sh","type":1}],["VSCODE_GIT_ASKPASS_NODE",{"value":"/usr/share/code-exploration/code-exploration","type":1}],["VSCODE_GIT_ASKPASS_MAIN",{"value":"/usr/share/code-exploration/resources/app/extensions/git/dist/askpass-main.js","type":1}]]}]')", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.580181:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): END TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143530.778909:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:31.406Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
(node:8213) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
[8213:1213/143531.429480:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.429697:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.522253:INFO:CONSOLE(1779)] "%cTRACE color: #888 lifecycle: phase changed (value: 4)", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.522635:INFO:CONSOLE(1779)] "%cTRACE color: #888 RequestService#request https://vscodeexperiments.azureedge.net/experiments/vscode-experiments.json", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:31.535Z] resolveShellEnv(): skipped (VSCODE_CLI is set)
[main 2020-12-13T14:35:31.602Z] Shared process: IPC ready
[8213:1213/143531.608372:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.608420:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
(node:8339) Electron: Loading non-context-aware native module in renderer: '/usr/share/code-exploration/resources/app/node_modules.asar.unpacked/spdlog/build/Release/spdlog.node'. This is deprecated, see https://github.com/electron/electron/issues/18397.
[main 2020-12-13T14:35:31.625Z] Shared process: init ready
[8213:1213/143531.678777:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.679068:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.679498:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.679989:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.680334:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.680590:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.680995:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.681305:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.681466:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.681789:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.682045:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.682441:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.683324:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.683359:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.687828:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.691725:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Account status changed from uninitialized to unavailable", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.692295:INFO:CONSOLE(1779)] "%cTRACE color: #888 Settings Sync: Accounts are initialized", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.717212:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/sharedprocess.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.763893:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.763923:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/userDataSync.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:31.951Z] menubarService#updateMenubar 1
[8213:1213/143531.960935:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143531.961061:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143532.153451:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/telemetry.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143532.153602:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/sharedprocess.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143532.153775:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [ADDED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/userDataSync.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143532.153890:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/main.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143532.154016:INFO:CONSOLE(1779)] "%cTRACE color: #888 [File Watcher (node.js)] >> normalized [CHANGED] /home/andrew/.config/Code - Exploration/logs/20201213T143528/renderer1.log", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143552.301275:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] updateItems(): insert(Map(1) {memento/workbench.parts.editor => {"editorpart.state":{"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.welcomePageInput","value":"{}"}],"mru":[0],"preview":0},"size":990}],"size":574},"orientation":0,"width":574,"height":990},"activeGroup":0,"mostRecentActiveGroups":[0]}}}), delete(Set(0) {})", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143552.304286:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): BEGIN TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143552.304443:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('memento/workbench.parts.editor','{"editorpart.state":{"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.welcomePageInput","value":"{}"}],"mru":[0],"preview":0},"size":990}],"size":574},"orientation":0,"width":574,"height":990},"activeGroup":0,"mostRecentActiveGroups":[0]}}')", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[8213:1213/143552.305608:INFO:CONSOLE(1779)] "%cTRACE color: #888 [storage state.vscdb] Trace (event): END TRANSACTION", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
[main 2020-12-13T14:35:52.411Z] [storage state.vscdb] updateItems(): insert(Map(2) {workbench.grid.width => 622, workbench.grid.height => 1012}), delete(Set(0) {})
[main 2020-12-13T14:35:52.412Z] [storage state.vscdb] Trace (event): BEGIN TRANSACTION
[main 2020-12-13T14:35:52.412Z] [storage state.vscdb] Trace (event): INSERT INTO ItemTable VALUES ('workbench.grid.width','622'),('workbench.grid.height','1012')
[main 2020-12-13T14:35:52.413Z] [storage state.vscdb] Trace (event): END TRANSACTION
[main 2020-12-13T14:35:58.409Z] update#checkForUpdates, state =  idle
[main 2020-12-13T14:35:58.410Z] update#setState checking for updates
[main 2020-12-13T14:35:58.410Z] RequestService#request https://update.code.visualstudio.com/api/update/linux-x64/exploration/d530b3b27d0f52a0290cdb53031ba60f02927c60
[main 2020-12-13T14:35:58.447Z] update#setState idle
[8213:1213/143612.499578:INFO:CONSOLE(1779)] "%cTRACE color: #888 Layout#layout, height: 1012, width: 941", source: file:///usr/share/code-exploration/resources/app/out/vs/workbench/workbench.desktop.main.js (1779)
http://: Invalid host name.
Unexpected crash report id length
Failed to get crash dump id.
Report Id:

VSCode crashes when I move the cursor into the window, and the terminal it's launched from displays this as soon as I do:

http://: Invalid host name.
Unexpected crash report id length
Failed to get crash dump id.
Report Id:

Here is a video of this happening: https://www.youtube.com/watch?v=7JOz1q59qGc

The text in the window is crisp, which is not the case on XWayland applications on hi-DPI displays on sway, so it does actually appear to be launching in Wayland!

I'd be more than happy to help by providing additional info :)

kriive commented 3 years ago

@andrewnicolalde as far as I understand, the latest code-exploration build is still on 11.0.3, thus it doesn't have the Ozone code path properly enabled.

theGeekyLad commented 3 years ago

Any idea when we can see VS Code with Electron 12 and the partial Wayland support?

ghost commented 3 years ago

@theGeekyLad Wait at least until Electron 12 itself is released. It's in beta right now.

LyesSaadi commented 3 years ago

According to this document, Electron 12 will be released the 2nd of March 2021 :cry:.

a0n commented 3 years ago

Really looking forward to this!

adrusi commented 3 years ago

While we're all waiting for native wayland support, a bit of a workaround:

Run code-server and use it from Firefox, which has native wayland support. Ideally run it in an SSB (firefox's equivalent of chrome's PWAs) to avoid keybinding conflicts. That'll require enabling browser.ssb.enabled in about:config and running code-server with SSL (I achieve this by importing a root cert into firefox, but there are alternatives).

If you don't require access to the marketplace or proprietary extensions, this should suffice until the Electron 12 builds are ready.

Jamesxu182 commented 3 years ago

For someone who is using archlinux and wayland. I created an aur package called "visual-studio-code-wayland", which basically builds vscode with electron 12. it is inspired by the patch from @kriive above. please see here: https://aur.archlinux.org/packages/visual-studio-code-wayland.

tyalie commented 3 years ago

I should definitely switch to Arch one day all the best packages are there 😂

SaucySauce commented 3 years ago

I've been on GNOME Shell Wayland since 3.32, with each passing release the environment gets better. 3.38 is about perfect.

I should definitely switch to Arch one day all the best packages are there joy

That's the beauty of Arch. It sucked me in 4 years ago and still counting. No stability issues too and I run it on both a Macbook Pro older than fortnite players and a first gen Ryzen desktop.

Short of Electron being stuck to Xwayland like Discord and Etcher, most of the apps I run are perfectly Wayland compatible, short of a GS DE related bug with telegram.

I recommend something like RebornOS or EndeavourOS if you can't be bothered by the vanilla install, I'm exclusively on the latter as of the last 12 months.

memeplex commented 3 years ago

Short of Electron being stuck to Xwayland like Discord and Etcher, most of the apps I run are perfectly Wayland compatible

I would hold my horses a bit though, last time I checked Chromium on Wayland was far from polished. For example, touchpad scrolling was completely unusable, like some sort of bad mapping to page up/down. Issues for stuff like this are still open in Chromium tracker. One thing is that they enabled the runtime toggle, another thing is that it's ready for production. Don't know how many of these Chromium shortcomings will be inherited by Electron, but I wouldn't get too excited yet.

adamcstephens commented 3 years ago

Please keep updates on topic. This isn't the place to discuss linux distributions or wayland support in other apps.

CyanoKobalamyne commented 3 years ago

I'm using VS Code with Electron 12 beta on Wayland (sway) on Arch (the aforementioned AUR package). Pretty much everything seems to be working so far... except for the menubar, which cannot be accessed either with the mouse or with Alt keyboard shortcuts. (This was also mentioned by @kriive earlier in this thread.) Is this some limitation of the current Wayland implementation of Electron itself or a bug in VS Code?

4ndv commented 3 years ago

I'm using VS Code with Electron 12 beta on Wayland (sway) on Arch (the aforementioned AUR package). Pretty much everything seems to be working so far... except for the menubar, which cannot be accessed either with the mouse or with Alt keyboard shortcuts. (This was also mentioned by @kriive earlier in this thread.) Is this some limitation of the current Wayland implementation of Electron itself or a bug in VS Code?

Broken menubar (and right-click menu) seems to be an electron bug. Hyper (electron terminal emulator) when built along electron 12 beta 16 is also having broken menus.

4ndv commented 3 years ago

Found a solution for missing titlebar and non-working menu:

Add this to your settings.json:

"window.titleBarStyle": "custom",

It will enable non-native titlebar, which also includes non-native menus.

paulcarroty commented 3 years ago

The branch electron-12.x.y arrived.

kriive commented 3 years ago

Found a solution for missing titlebar and non-working menu:

Add this to your settings.json:
"window.titleBarStyle": "custom",
It will enable non-native titlebar, which also includes non-native menus.

This solution works like a charm. Just compile the electron-12.x.y branch as @paulcarroty has pointed out, change the settings and you're good to go! This is what it looks like on a 4K display on HiDPI! 🥳

memeplex commented 3 years ago

This solutions works like a charm.

Let's call this a workaround, please, a proper solution involves rendering CSD using your platform theme, not Windows 10's.

4ndv commented 3 years ago

This solutions works like a charm.

Let's call this a workaround, please, a proper solution involves rendering CSD using your platform theme, not Windows 10's.

Sure, but it's mostly related to electron, not vscode. And for now - this is better than nothing. And it's still better than running blurry vscode under XWayland with fractional scaling (like in my case).

memeplex commented 3 years ago

It might be worth developing a CSD solution that at least allows to customize the headerbar color according to the editor theme. I've asked upstream how are they planning to implement CSD, whether they will provide a customizable headerbar somehow or just default to the system wide theme.

carwyn commented 3 years ago

I've tried compiling the electron-12.x.y branch and added "window.titleBarStyle": "custom", and it's working fairly well. But, the extensions marketplace isn't working. Is this something that's meant to/able to work with custom builds or have I broken something?

If I can get this working I'll be able to test the Wayland build daily ... but I need my extensions! ;)

CyanoKobalamyne commented 3 years ago

@carwyn The Microsoft extensions marketplace (if you're referring to that) is not available in Code OSS (which is what this repository hosts) either under Wayland or X11. There is more information on this page: https://github.com/microsoft/vscode/wiki/Differences-between-the-repository-and-Visual-Studio-Code.

paulcarroty commented 3 years ago

@carwyn open-vsx.org for alternative, VSCodium uses it by default.

memeplex commented 3 years ago

The discussion about upstream CSD support has moved to a more specific issue https://github.com/electron/electron/issues/27522.

deepak1556 commented 3 years ago

Update on the delay for exploration builds based on Electron 12, with electron 12 the default process policy is changed which will break the native modules loaded inside the vscode renderer on reloads. We are actively working on that under https://github.com/microsoft/vscode/issues/92164, most of the problematic modules have been moved out of the renderer. So we will be able to revisit electron 12 adoption in March.

TemporalAgent7 commented 3 years ago

Electron 12 (with initial Wayland support) released a week ago; any news on when we might get it in VSCode?

lrazovic commented 3 years ago

Electron 12 (with initial Wayland support) released a week ago; any news on when we might get it in VSCode?

There is the branch electron-12.x.y that compiles with the latest stable electron, and works without major problems passing the flags --enable-features=UseOzonePlatform --ozone-platform=wayland

iMonZ commented 3 years ago

The discussion about upstream CSD support has moved to a more specific issue electron/electron#27522.

This needs to be fixed before Wayland will work properly.

toger5 commented 3 years ago

@iMonZ Why is this important for vs code? Vs code has excellent client side decoration support. That can just be the default until electron is updated (Than the option to use ssd can be added back in to the linux build)

flying-sheep commented 3 years ago

Does VS Code use the theme’s window buttons? Correct appearance, side, order, and choice of buttons?

If not, it does not have CSDs that can be considered excellent for Linux.

sigmaSd commented 3 years ago

Hello,

Here is a method to build vscode with wayland: (using gitpod)

Sign up in https://gitpod.io/
fork this repo
in your fork checkout electron-12.x.y branch and add 2 files:

.gitpod.Dockerfile with this content:
```
FROM gitpod/workspace-full
```
.gitpod.yml with this content:
```
image:
file: .gitpod.Dockerfile
```
goto https://gitpod.io/settings/ and enable feature preview (so you have acess to sudo)
go to https://gitpod.io/#https://github.com/($giuthubname)/visual-studio-code-wayland/tree/electron-12.x.y (change $githubname)
run these commands:
- sudo apt-get update
- sudo apt-get install build-essential g++ libx11-dev libxkbfile-dev libsecret-1-dev python-is-python3
- yarn run gulp vscode-linux-x64-build-deb
Now that you have a deb file (in .build/linux/deb/amd64/deb/) you can download it (if the downloading freezes you can use python -m http.server)

Extract the data folder from the deb, to run with wayland use: ./usr/share/code-oss/bin/code-oss --enable-features=UseOzonePlatform --ozone-platform=wayland

Beryesa commented 3 years ago

Hi! What is the status of the issue? Electron 12 released a short while ago https://www.electronjs.org/releases/stable https://www.electronjs.org/blog/electron-12-0

lrazovic commented 3 years ago

Works continues on the electron-12.x.y branch. You can follow this PR https://github.com/microsoft/vscode/pull/120034 by @deepak1556 to stay updated on the status of the update, I doubt it will be finished before the March release, also because it's not in the current iteration plan, you probably have to wait for the April release, but I'm happy to be proven wrong.

rohmishra commented 3 years ago

Does VS Code use the theme’s window buttons? Correct appearance, side, order, and choice of buttons?

If not, it does not have CSDs that can be considered excellent for Linux.

VSCode has its own style for window buttons so matching them would make no sense as it might look out of place compared to rest of the app and depending on the theme, even be illegible. That said, it should match the decoration location (left/right) and options (I for example dont have restore/maximize on gtk apps but vscode gives me one anyways)

flying-sheep commented 3 years ago

If your theme engine can’t adapt its buttons to the background colors of the title bar, it’s not a good one.

Don’t prevent features because some software is bad. There’s always bad software, innovation still happens.

I have an excellent theme engine and also choose my color themes so they match. I expect buttons that don’t look out of place.

ZanderBrown commented 3 years ago

What theme engine?

y0ast commented 3 years ago

Using https://aur.archlinux.org/packages/visual-studio-code-insiders-bin/

code-insiders --enable-features=UseOzonePlatform --ozone-platform=wayland

Works very well, with Sway as compositor.

frandieguez commented 3 years ago

Works great in GNOME 40 with wayland using the same procedure described b @y0ast

microsoft / vscode

Native wayland support with newest electron #109176