The terminal IME composition view appears on top of text sometimes and keeps moving while typing

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

162.96k stars 28.77k forks source link

The terminal IME composition view appears on top of text sometimes and keeps moving while typing #11334

Closed rebornix closed 6 years ago

rebornix commented 8 years ago

VSCode Version: 1.5.0-Insiders
OS Version: OSX

Steps to Reproduce:

Open Integrated Terminal
Switch to OSX's default Chinese IME
Type nihao and see the behavior.

imeinterminal

Found this issue while verifying #9822.

Tyriar commented 8 years ago

A fix to this will probably be too high risk due to the module refactor in xterm.js. Deferring to September since it's just a bit glitchy but should still work.

Tyriar commented 8 years ago

Fixing this related upstream issue may fix this https://github.com/sourcelair/xterm.js/issues/273

Tyriar commented 7 years ago

I believe this will be fixed by the fix in https://github.com/Microsoft/vscode/issues/13229, not yet confirmed though.

Tyriar commented 7 years ago

@rebornix this may be fixed, please verify. If not I'll need to learn how to use your IME :stuck_out_tongue:

rebornix commented 7 years ago

@Tyriar since the xterm-helper-textarea is positioned as absolute and seems right now we only generate left for it, the top value is always 0.

Tyriar commented 7 years ago

PR is out upstream

Tyriar commented 7 years ago

The commit broke the build and was reverted, waiting until code freeze is finished to add it back.

jrieken commented 7 years ago

Assuming Chinese IME is Pinyin Simplified I cannot get this to work. These are my steps

OS X, select Pinyin Simplified keyboard
in editor type ni, select first suggestion
in terminal type ni, select first suggestion, 🐛 it prompts to show all completions instead of inserting the character

oct-28-2016 10-16-55

bpasero commented 7 years ago

Since this is not labeled important, moving out to November.

Tyriar commented 7 years ago

@rebornix can you double check this?

rebornix commented 7 years ago

I don't run into the issue @jrieken had, but when I typed first character, like n, the composition view is missing but after I typed i, the composition view is shown.

Tyriar commented 7 years ago

Are you pressing tab to trigger the completion @jrieken?

jrieken commented 7 years ago

No. I press 1 to select the suggestion. The suggestion show up as I type

Tyriar commented 7 years ago

@rebornix can you still repro this on Mac?

rebornix commented 7 years ago

I can still reproduce this problem.

Tyriar commented 6 years ago

I can't see the original problem anymore but I do see the related https://github.com/xtermjs/xterm.js/issues/273 still which is tracked over there.