search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.43k stars 29.34k forks source link

Flake8 —format flag not working #113785

Closed rkpatel33 closed 3 years ago

rkpatel33 commented 3 years ago

Issue Type: Bug

It seem the format flag called by the flake8 linter is not working due to missing quotes.

In the "Problems" pane I see this command being run, and returning no issues even though there are many in my file:

> ~/.local/share/virtualenvs/albert-main-qSuxtnGi/bin/flake8 --config=setup.cfg --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s ~/Projects/albert/albert-main/lyfe/models.py
cwd: ~/Projects/albert/albert-main
##########Linting Output - flake8##########

If I run that command in my terminal inside VSCode, I get the following returning no matches:

~/.local/share/virtualenvs/albert-main-qSuxtnGi/bin/flake8 --config=setup.cfg --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s ~/Projects/albert/albert-main/lyfe/models.py  
zsh: no matches found: --format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s

If I add single quotes to this command, it works as expected:

~/.local/share/virtualenvs/albert-main-qSuxtnGi/bin/flake8 --config=setup.cfg --format='%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s' ~/Projects/albert/albert-main/lyfe/models.py
/Users/rishi/.local/share/virtualenvs/albert-main-qSuxtnGi/lib/python3.6/site-packages is in the MYPYPATH. Please remove it.
See https://mypy.readthedocs.io/en/latest/running_mypy.html#how-mypy-handles-imports for more info
1,1,D,D100:Missing docstring in public module
116,1,D,D102:Missing docstring in public method
319,1,D,D102:Missing docstring in public method
617,1,D,D102:Missing docstring in public method
762,1,D,D102:Missing docstring in public method
769,1,D,D102:Missing docstring in public method
773,1,D,D102:Missing docstring in public method
781,1,D,D102:Missing docstring in public method
813,1,D,D102:Missing docstring in public method
817,1,D,D102:Missing docstring in public method
...

This strikes me as a bug but not sure. I don't seen an obvious way to override this as if I set the flag manually, it still get's overridden when called by the linter.

VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:30:02.420Z) OS version: Darwin x64 19.6.0

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|32.00GB (8.59GB free)| |Process Argv|--crash-reporter-id e3539aef-fd5a-499f-9dbf-a0a9c0532fe4| |Screen Reader|no| |VM|0%|
Extensions (88) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|2.1.0 project-manager|ale|12.0.1 cform|aws|0.0.24 vscode-log-viewer|ber|0.11.1 vscode-tailwindcss|bra|0.5.6 better-toml|bun|0.3.2 solargraph|cas|0.21.1 npm-intellisense|chr|1.3.1 path-intellisense|chr|2.3.0 bracket-pair-colorizer|Coe|1.0.61 bracket-pair-colorizer-2|Coe|0.2.0 indent4to2|Com|0.1.2 vscode-github-actions|csc|0.10.0 transformer|dak|1.11.0 markdown-table-prettify|dar|3.2.0 vscode-eslint|dba|2.1.14 vscode-dash|dee|2.4.0 githistory|don|0.6.14 gitlens|eam|11.1.2 permute-lines|ear|1.1.0 tslint|eg2|1.0.44 vscode-npm-script|eg2|0.3.13 react-native-react-redux|EQu|2.0.6 vscode-github-notifications-bell|fab|2.3.1 macros|ged|1.2.1 vscode-pull-request-github|Git|0.22.0 gc-excelviewer|Gra|3.0.40 vscode-graphql|Gra|0.3.13 terraform|has|2.3.0 beautify|Hoo|1.5.0 vsc-space-block-jumper|jmf|1.2.2 nrql-language|joe|0.0.1 vscode-peacock|joh|3.9.1 chat|kar|0.35.0 vscode-home-assistant|kee|1.13.0 expand-region|let|0.1.4 restructuredtext|lex|142.0.0 procfile-support|log|0.0.1 git-graph|mhu|1.28.0 gitlab-mr-sync|mik|0.3.0 dotenv|mik|1.0.1 react-javascript-to-typescript-transform-vscode|moh|1.10.0 theme-monokai-pro-vscode|mon|1.1.18 vscode-scss|mrm|0.9.0 vscode-docker|ms-|1.9.0 python|ms-|2020.12.424452561 vscode-pylance|ms-|2020.12.2 jupyter|ms-|2020.12.414227025 remote-containers|ms-|0.154.1 remote-ssh|ms-|0.62.0 remote-ssh-edit|ms-|0.62.0 remote-wsl|ms-|0.52.0 vscode-remote-extensionpack|ms-|0.20.0 vsliveshare|ms-|1.0.3375 vsliveshare-audio|ms-|0.1.91 vsliveshare-pack|ms-|0.4.0 debugger-for-chrome|msj|4.12.11 debugger-for-edge|msj|1.0.15 vscode-fluentd|msy|0.0.4 sqltools|mtx|0.23.0 copy-file-name|nem|1.2.0 remote-github|niu|0.3.0 heroku-command|pko|0.0.8 quicktype|qui|12.0.46 subtle-brackets|raf|3.0.0 ruby|reb|0.27.0 vscode-yaml|red|0.13.0 vscode-gitweblinks|red|2.0.0 LiveServer|rit|5.6.1 code-settings-sync|Sha|3.4.3 markdown-preview-enhanced|shd|0.5.15 gitconfig|sid|2.0.1 vscode-fileutils|sle|3.4.2 sourcegraph|sou|1.1.0 guides|spy|0.9.3 code-spell-checker|str|1.10.2 hunspell|str|0.0.2 vscode-make|tec|1.0.2 vscode-lua|tri|0.12.4 es-quotes|vil|0.2.6 vscode-ruby|win|0.27.0 vscode-import-cost|wix|2.13.0 change-case|wma|1.0.0 JavaScriptSnippets|xab|1.8.0 ReactSnippets|xab|2.4.0 plsql-language|xyz|1.8.2 material-theme|zhu|3.9.12 html-css-class-completion|Zig|1.20.0
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 openlogontheside:30221877 python763:30178808 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 python504:30227505 vswsl492cf:30211402 wsl2promptcf:30224613 pythonvsdeb440:30237827 unusedprompt:30224610 folderexplorercf:30224615 openfilemenucf:30224648 pythonvsded773:30236629 pythonvspyt859:30239450 vsjup459:30237187 ```
mjbvz commented 3 years ago

/extPython