search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.18k stars 29.29k forks source link

workbench.externalUriOpeners protocol glob patterns don't work #115137

Open connor4312 opened 3 years ago

connor4312 commented 3 years ago

Testing #114962

mjbvz commented 3 years ago

My example was incorrect. The syntax we support is https://*. This is the same syntax supported for trusted domains

connor4312 commented 3 years ago

Cool, that works. Probably worth documenting in the setting -- the description is minimal right now.

Once documented I think this can be closed.

mjbvz commented 3 years ago

We provide hover intellisense with examples in the json editor:

Screen Shot 2021-01-26 at 12 05 00 PM

We will probably add a rich editor for these settings at some point too

I still think supporting https:* makes sense, although I am not sure if there is some reason why trusted domains don't support it

connor4312 commented 3 years ago

Oh, I see, I was looking on the setting itself rather than the key