search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.64k stars 29.04k forks source link

IME ON at Alt+` key, Focus ALT Menu #115810

Closed tatosan924812 closed 3 years ago

tatosan924812 commented 3 years ago

Issue Type: Bug

at version 1.53. I using USKeybord. When press Alt+` key to change IME mode at editor or find box, keybord focus move to menu bar.

If key press slow, is not focus menu. but when normaly speed, move focus menu.

I rollback to 1.52.1, here is no problem.

VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:34:46.910Z) OS version: Windows_NT x64 10.0.19042

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz (8 x 3599)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.95GB (8.79GB free)| |Process Argv|--crash-reporter-id 9d38bd2d-0e0c-4eb8-81b0-d07fb55194e8| |Screen Reader|no| |VM|0%|
Extensions (9) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|12.1.4 vscode-intelephense-client|bme|1.6.3 bracket-pair-colorizer|Coe|1.0.61 smarty|imp|0.3.0 svn-scm|joh|2.13.5 php-cs-fixer|jun|0.1.158 vscode-language-pack-ja|MS-|1.53.2 php-docblocker|nei|2.1.0 material-icon-theme|PKi|4.5.0
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30211401 pythonvsdeb440:30248342 pythonvsded773:30248341 pythonvspyt600cf:30251589 ```
alexdima commented 3 years ago

@tatosan924812 What keyboard layout are you using?

sbatten commented 3 years ago

I have the root cause and fix, this is related to our modifier key event listener. The keydown event for entering KanjiMode is imo erroneously labeled a repeat event. However, we can address this by only ignorning repeat events for modifier keys, more specifically I have limited this to only the Alt key as it is the only know case we need to ignore.