Extension contributed commands (non-codicons) seem to be missing

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

163.71k stars 29.09k forks source link

Extension contributed commands (non-codicons) seem to be missing #116168

Closed eamodio closed 3 years ago

eamodio commented 3 years ago

In this screenshot there are 2 missing icons -- 1 from the GHPR extension and 1 from GitLens

@joaomoreno I don't know if this has to do with your menu changes to SCM or not.

Maybe related (since it showed up at the same time), non-codicons in custom views are misaligned.

gjsjohnmurray commented 3 years ago

@eamodio is this 1.54 Insiders or 1.53 Stable?

jrieken commented 3 years ago

@sandy081 is this a dupe of the issue you had mentioned today?

eamodio commented 3 years ago

1.54-insiders (1.53 works fine)

sandy081 commented 3 years ago

@jrieken I guess not because it seems it is icon missing not the complete action. Anyway the new insiders have the fix (I mentioned in standup today), @eamodio Please check if it is fixed in latest?

eamodio commented 3 years ago

@sandy081 still broken in today's insiders.

sandy081 commented 3 years ago

Is the icon or action missing - I mean are you able to click and the action executes?

eamodio commented 3 years ago

In the SCM view, the action is there and works, just the icons are missing. While in the custom trees, the actions/icon is there, but the icons are misaligned

eamodio commented 3 years ago

@joaomoreno I did a git bisect and 02fddad16d9f147bbc3aaf97dbb6a0291fc68144 caused this. Still looking more into it.