microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.27k stars 28.57k forks source link

Can’t debug VS Code extensions on iPadOS PWA #118383

Open alefragnani opened 3 years ago

alefragnani commented 3 years ago

Steps to Reproduce:

  1. Open a VS Code extension on Codespaces
  2. Build the extension
  3. Open the Debug panel and click the Start/Play button
  4. The debugging starts and you see the debug toolbar, but no [Development ...] window/tab appears.

Tested opening Codespaces directly from Safari browser and via PWA (Add to Home Screen). Same issue.

Does this issue occur when all extensions are disabled?: Yes

Originally reported in #107386, which was closed as fixed, even tho I didn’t have success verifying myself back then. So, I suppose it’s probably a regression in recent releases.

Thank you

vscodebot[bot] commented 3 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

alefragnani commented 3 years ago

It’s not a duplicate of that. In fact, is a “reopening” of #107386.

alefragnani commented 3 years ago

I think this issue should receive the ios-ipados label too. cc @bpasero @isidorn

isidorn commented 3 years ago

Sounds like the issue is that the new tab does not get opened. @alefragnani are you sure this is still happening, since I added some code 1 month ago that detects if Safari blocked a new tab, and we would offer to the user to explicitly open a new tab?

alefragnani commented 3 years ago

Hi @isidorn ,

I just tested again, and the dialog appeared, but it is unstable. I mean, sometimes it works (opens the new tab), sometimes not.

I can't say for sure, but it seems it it only works on first run scenarios. This is why I think that:

I'm wondering how this new tab behavior will fit on PWA scenario, mostly because some of the iPadOS issues were fixed only on PWA scenarios.

Even with this unstable behavior, I'm really happy to see it is evolving. I'm eager to be able to use my iPad to develop my VS Code extensions.

Keep up the great work. Thanks!

isidorn commented 3 years ago

@alefragnani thanks for feedback. This is basically us fighting against Safari and their blocking behaviour. I am assigning to August so I give this a try on my iPad and then I can let you know if we can improve something here. I have to check the PWA experience.

isidorn commented 3 years ago

I just tried debugging from Codespaces and the new tab was consistently being opened for me. However for PWA this simply is not working, as you say PWA does not support multiple tabs and when a new instance of the PWA window gets opened it replaces the original one. So it seems like it is not possible to have multiple tabs / windows and thus it is impossible to debug Extensions in this setup.

I do not see how we could tackle this. Though I am open for ideas. Assigning to @weinand since he owns EH debugging and this is a limitation we should be aware of.

alefragnani commented 2 years ago

Hi, any news about this issue?

Is there anything I could do on my side (like a setting) to be able to use an iPad for VS Code extension development?

Thank you

isidorn commented 2 years ago

No updates from my side. @weinand might know more. fyi @TylerLeonhardt

weinand commented 2 years ago

No updates from my side either.

TylerLeonhardt commented 1 year ago

@connor4312 @roblourens are the new owners of the debug side of things. I just got assigned because it's iPad related.