search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.64k stars 29.05k forks source link

Change any theme color after tab.border in json will change to tab.border. #122167

Closed xpader closed 3 years ago

xpader commented 3 years ago

Issue Type: Bug

When use color picker to change theme color in settings.json after "tab.border" will always change "tab.border". For example: the content like:

            "editor.foreground": "#A9B7C6",
            "tab.activeBackground": "#242424",
            "tab.activeBorder": "#242424",
            "tab.border": "#323232",
            "tab.inactiveBackground": "#CCCCCC",
            "editorGroupHeader.tabsBackground": "#3B3B3C"

When the mouse hove on tab.inactiveBackground, and change the color in colorpicker, tab.inactiveBackgorund not changed, but tab.border changed, that strange.

vscode

VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:35:57.887Z) OS version: Windows_NT x64 10.0.19042

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: enabled
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.87GB (4.02GB free)| |Process Argv|--crash-reporter-id ce4a5459-74bc-4634-b970-5ffc6f4a7b98| |Screen Reader|no| |VM|0%|
Extensions (28) Extension|Author (truncated)|Version ---|---|--- vscode-laravel-goto|abs|0.4.2 codesnap|adp|1.3.2 project-manager|ale|12.1.0 laravel-extra-intellisense|ami|0.6.1 vscode-intelephense-client|bme|1.6.3 tabulous|bwi|1.2.0 npm-intellisense|chr|1.3.1 path-intellisense|chr|2.3.0 vs-phpclassgen|dam|0.1.1 gitlens|eam|11.4.1 clipboard-manager|Edg|1.4.2 vscode-todo-plus|fab|4.18.3 composer|ika|0.7.1 vscode-jetbrains-keybindings|isu|0.1.9 open-file-from-path|jac|1.3.4 twig-language-2|mbl|0.9.2 phpcopyreference|MDO|1.0.3 dotenv|mik|1.0.1 goto-next-previous-member|mis|0.0.5 remote-ssh|ms-|0.65.4 remote-ssh-edit|ms-|0.65.4 remote-wsl|ms-|0.54.6 vscode-remote-extensionpack|ms-|0.20.0 appidocsnippets|mya|0.1.20 php-docblocker|nei|2.1.0 vetur|oct|0.33.1 search-selection|tim|0.0.1 better-align|wwm|1.1.6 (1 theme extensions excluded)
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstry244:30276681 pythonvsdeb440:30248342 pythonvsded773:30248341 pythonvspyt875:30259475 pythonvsnew554cf:30291488 pythontb:30283811 vspre833cf:30267465 pythonptprofiler:30281270 vshan820cf:30276953 pythondataviewer:30285071 vscus158:30286553 ```
xpader commented 3 years ago

When I closed settings.json tab, and reopen it, the bug disappear.

rebornix commented 3 years ago

Similar issue https://github.com/microsoft/vscode/issues/131656

rebornix commented 3 years ago

It's very like sharing the same root cause as https://github.com/microsoft/vscode/issues/121897 , please check updates on that issue, thanks!