Version control icons became minuscule with latest update

ylefebvre commented 3 years ago

Issue Type: Bug

Go to Source Control tab and look at the icons for all source projects. The commit and other icons are tiny!

VS Code version: Code 1.56.0 (cfa2e218100323074ac1948c885448fdf4de2a7f, 2021-05-04T22:09:06.405Z) OS version: Windows_NT x64 10.0.19042

System Info

|Item|Value| |---|---| |CPUs|AMD Ryzen 7 3800X 8-Core Processor (16 x 3900)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|31.93GB (24.41GB free)| |Process Argv|--crash-reporter-id c140cd00-e08b-4c0a-8002-90bd79eae591| |Screen Reader|no| |VM|0%|

Extensions (7)

Extension|Author (truncated)|Version ---|---|--- php-debug|fel|1.14.12 php-intellisense|fel|2.3.14 php-pack|fel|1.0.2 fontsize-shortcuts|fos|1.5.0 vscode-edit-csv|jan|0.5.8 vscode-wordpress-hooks|joh|0.5.4 svn-scm|joh|2.13.5

A/B Experiments

``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 pythonvspyt602:30294772 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes516:30244333 pythonvspyt639:30291489 pythontb:30283811 pythonvspyt551:30291414 vspre833cf:30267465 pythonptprofiler:30281270 vsdfh931:30280409 vscnewfilehidden:30294815 vshan820:30294714 vscoreces:30290705 pythondataviewer:30285071 vscus158cf:30286554 vscgsv2:30294352 ```

gjsjohnmurray commented 3 years ago

Mine don't seem to have been affected:

Please post your screenshot.

mhutchie commented 3 years ago

This is also affecting users of Git Graph, which contributes a command to the scm/title menu.

Issue raised by a Git Graph user: https://github.com/mhutchie/vscode-git-graph/issues/502 (with screenshot)

deepnight commented 3 years ago

Hello, It happened to me with latest Vscode + GitGraph extension which adds an icon to the SCM bar. For some reason, the icon added by the GitHub Pull request extension isn't affected.

mhutchie commented 3 years ago

@deepnight,

I just had a look at the GitHub Pull Request Extension, they use a Visual Studio Code Octicon as the icon for the command (see here), as the Octicon collection contains icons for many common Git commands.

In contrast, Git Graph uses a SVG icon bundled in the extension, as the extension's icon is naturally not included in the Octicon collection. The SVG's used by the command that Git Graph contributes exactly follows the Visual Studio Code Command-icon-specifications.

mhutchie commented 3 years ago

For reference, I can't replicate it (even using a very similar system to @deepnight).

Version: 1.56.0 (user setup)
Commit: cfa2e218100323074ac1948c885448fdf4de2a7f
Date: 2021-05-04T22:09:06.405Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19041

Just a thought: Perhaps this is related to the screen's device pixel ratio. @deepnight, what is your screen resolution? (mine is 1920x1080)

mhutchie commented 3 years ago

I've been able to replicate this issue, for me it occurs when the SCM View contains multiple repositories.

The icon is tiny with multiple repositories:

The icon is the standard size with a single repository:

erclu commented 3 years ago

I just updated vscode to v1.56.0 and i'm having the same issue. My screen resolution is 1920x1080, same as yours @mhutchie .

These are the steps i followed:

open a folder containing a git repository
navigate to the source control view
if not already visible, toggle the source control repositories view by right clicking on the source control header.
result:

Alternatively:

open a folder containing multiple git repositories OR a multi-root workspace
navigate to the source control view
result:

modbw commented 3 years ago

I have the same issue with the GitGraph and SVN extension in a multi root workspace:

WESquad-oldmember commented 3 years ago

I can also reproduce the same issue with Gitmoji and GitGraph

heartacker commented 3 years ago

don't forget that action icon have the same problem.

mhutchie commented 3 years ago

I can confirm that the fix (included in the latest insiders release) has resolved the issue for the icons that were affected in the Git Graph extension (for me at least).

Version: 1.57.0-insider (user setup)
Commit: a19565da7dfc739fa26e36aae96113e19fe3806f
Date: 2021-05-07T17:19:03.737Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19041

microsoft / vscode

Version control icons became minuscule with latest update #123036