microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.63k stars 29.43k forks source link

[icon-themes] Support for globs in file associations (Icon themes) #12493

Open robertohuertasm opened 8 years ago

robertohuertasm commented 8 years ago

See vscode-icons #328

This will allow to support a very common scenario which is a filename with small variations depending on environments:

bpasero commented 8 years ago

@robertohuertasm works for me:

"files.associations": {
    "*{.prod.,.dev.,.}config": "xml"
}
robertohuertasm commented 8 years ago

@bpasero I think I didn't explain myself clearly so I've slightly changed the issue's title. I wasn't referring to that kind of file association but the one we discussed in vscode-icons #328.

bpasero commented 8 years ago

@robertohuertasm got it, reopening.

jing2si commented 8 years ago

+1

alyyasser commented 8 years ago

+1

AndrewKiri commented 8 years ago

+1

amamut commented 8 years ago

+1

yaSebastian commented 8 years ago

+1

echizenryoma commented 8 years ago

+1

xanathar commented 8 years ago

+1 Just to add a further scenario.. Unity supports only a limited number of assets; text files must be *.txt for example. So, again, if you have let's say Lua scripts inside, the easiest option to have Unity embedding them is to rename them *.lua.txt - it would be great if icons were aligned to them being lua scripts in disguise and not text files.

dreki commented 8 years ago

+1

smukkekim commented 8 years ago

+1

kristianmandrup commented 8 years ago

The latest fashion is to have tests co-located with the src, using a convention such as .test.js. Would be super helpful to be able to distinguish between regular application files and test files using custom icons!!

+1

aeschli commented 8 years ago

For '.test.js': That already should work, just add that to the extensions table. You can have both js, and test.js in there and we will take the icon of whatever extension whatever matches most.

aeschli commented 8 years ago

For the lua example, why not associate extension lua.txt with lua?

kristianmandrup commented 8 years ago

But the whole point is to have a specific test icon, to make it clear it is not a regular .js file. It is a special variant of js, but could be configured to be special variant for any language with test files...

I have tests and regular app files together, but want to be able to visually distinguish the files beyond having to mentally parse the file extension in the tree view. This is a common pattern now, since our tests tool can pick up test files in the src, so we don't need to have a separate /test or /spec folder with long require chains into the root /src folder which becomes a nightmare to maintain as you scale :o

My current vsicons config:

    { icon: 'spec', extensions: ['spec.js'], special: 'js' },
    { icon: 'test', extensions: ['test.js'], special: 'js' },
kristianmandrup commented 8 years ago

I added a PR, but just discovered new icons are not in zip.

https://github.com/robertohuertasm/vscode-icons/pull/409

amit-srivastava-007 commented 8 years ago

+1

kristianmandrup commented 8 years ago

@amit-srivastava-007 You are welcome to help out with my PR. I'm not a graphic designer and I don't know how to position the icons correctly (ie. centered, then lowered by one pixel).

GBora commented 8 years ago

+1

verbeeckjan commented 8 years ago

+1

johnmbaughman commented 8 years ago

+1

cmza commented 8 years ago

+1

jens1o commented 8 years ago

+1

mpgon commented 8 years ago

I would also like to associate ".html.tpl" to ".html"! +1

jozemlakar commented 8 years ago

+1

sleutho commented 7 years ago

+1

steals commented 7 years ago

+1

gigocabrera commented 7 years ago

+1

JBriggs666 commented 7 years ago

+1

jens1o commented 7 years ago

Some reaction from VS Code team?

FDMatthias commented 7 years ago

+1

elcin01x commented 7 years ago

+1

rem1niscence commented 7 years ago

+1

frederikdussault commented 7 years ago

+1

Kainax commented 7 years ago

+1

DanJ210 commented 7 years ago

I can't figure out how to change anything... All I would LOVE would being able to change the colors of folders to the bright blue :)

Thanks for the work!

robertohuertasm commented 7 years ago

@DanJ210 are you referring to vscode-icons #596? Please, refer to our repo for further instructions on how to customize your own icons.

karlfus commented 7 years ago

+1

rnemec commented 7 years ago

@aeschli looking forward to this - it will have big impact in VSC usability. I mean: "+1"

gardient commented 7 years ago

+1

deadcoder0904 commented 6 years ago

Hey guys any progress?

jens1o commented 6 years ago

@deadcoder0904 No, there isn't any.

rcalabro commented 6 years ago

+1

Dayw81 commented 6 years ago

+1

JohanG2012 commented 6 years ago

+1

deiga commented 6 years ago

Please stop commenting with '+1', GitHub has had support for reactions since March 10th 2016 (https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/)

Commenting without any substance doesn't add anything to the discussion.

kristianmandrup commented 6 years ago

@deiga Then why not close this issue?

deiga commented 6 years ago

@kristianmandrup Because the issue is not resolved?

Why would closing the issue be the solution instead of asking people to use GitHub Reactions?

@bpasero @robertohuertasm Do you know how this could be accomplished or do you know who would? I'd love to get this working, as it's tedious to everyday tell VSCode that my docker-compose.foo.yml is a docker-compose file and my Dockerfile.bar is a Dockerfile. And I'd love to help, but have no clue as to where to start.

jens1o commented 6 years ago

Do you know how this could be accomplished or do you know who would?

No, we don't. Currently, we need to write up every possible solution and then we concatenat them while building.