search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.65k stars 28.68k forks source link

strictBindCallApply ignored in some scenarios #126226

Closed eric-burel closed 3 years ago

eric-burel commented 3 years ago

Issue Type: Bug

Reproduced using Insiders as well Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. git clone https://github.com/VulcanJS/vulcan-next
  2. Open packages/react-ui/components/form/tests/Form.stories.tsx.
  3. Check the DefaultForm variable : it has type any, despite strictBindCallApply being true in both the root config and the nested config.

VS Code version: Code 1.55.2 (3c4e3df9e89829dce27b7b5c24508306b151f30d, 2021-04-13T09:37:02.931Z) OS version: Linux x64 5.4.0-74-generic

It seems related to the position of the file in the tree: when not nested and put at the root of a package, it works ok, but it stops being typed as soon as the file is nested.

I haven't yet reproduced on a simpler app however, with the same config. This might also be related to the number of files?

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-8500 CPU @ 3.00GHz (6 x 3000)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 1| |Memory (System)|27.27GB (8.99GB free)| |Process Argv|--disable-extensions . --no-sandbox --crash-reporter-id 12669a62-b055-4459-bcbf-f7183781f1d8| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|ubuntu| |XDG_CURRENT_DESKTOP|Unity| |XDG_SESSION_DESKTOP|ubuntu| |XDG_SESSION_TYPE|x11|
Extensions disabled
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 pythonvspyt602:30300191 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyt639:30300192 pythontb:30283811 pythonvspyt551:30311712 vspre833cf:30267465 pythonptprofiler:30281270 vshan820:30294714 pythondataviewer:30285071 vscus158cf:30286554 vscorehov:30309549 vscod805:30301674 binariesv517:30312825 ```
eric-burel commented 3 years ago

After more digging, this sounds like an instance of not being able to configure which tsconfig VS Code should use. strictBindCallApply is correctly handled, but that's my whole file that is ignored by TypeScript, so it falls back to VS code defaults config, which explains my issue.

need to include only my sources for the build, excluding storybook stories and tests, but I also need the Storybook stories and test to be included in the tsconfig to get the right behaviour in VS code. This would be solved by having a more liberal ts config just for vs code. https://github.com/microsoft/vscode/issues/12463