microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.55k stars 29.4k forks source link

Touchpad scrolling doesn't work #12637

Closed alexey-kozlenkov closed 7 years ago

alexey-kozlenkov commented 8 years ago

Suddenly touchpad scrolling stopped working.

Steps to Reproduce: 1) Add a lot of code yo see a scroll bar. 2) Try to scroll with 2-finger gesture - doesn't work;

Not sure about the reason of this behavior. I've been using VSCode for several hours, than I turned my laptop into a sleep mode. After waking it up back, VSCode no more responses on a touchpad scrolling (with 2 fingers).

I tried to reboot the system, no effect. I also tried to reinstall VSCode, but it seems like I haven't achieved complete removing (cause, for example, all my extensions were safe), so it didn't help too.

Have anyone also faced with such an issue or maybe there are some tips to do in order to solve this problem?

isidorn commented 8 years ago

Adding important to raise awarness and seems like a regression

alexey-kozlenkov commented 8 years ago

Actually, there is a kinda cure for this problem. The complete uninstall + deleting registry records for VS Code and then installing it back helped me.

It doesn't look like a solution, but helps to get back to work. This problem happened twice with me near the date I've posted this issue and since then VS Code works fine.

nathanielwarner commented 8 years ago

What registry records are there left over when uninstalling? I couldn't find any. Uninstalling and reinstalling did not solve the issue for me.

alexey-kozlenkov commented 8 years ago

@nathanielwarner Not sure where to find them manually in registry, I had used external tool (Uninstall Tool) to perform complete uninstalling (including registry records).

alexdima commented 8 years ago

AFAIK we had no changes in the scroll handling logic, but we did update to a newer electron version (that includes Chromium 52). In another thread @jhasse mentioned noticing issues with Chrome that went away with Chrome 54

It would be interesting to find out if Chrome 52 also suffers from this issue. We have the exact same scrolling code in the editor https://microsoft.github.io/monaco-editor/ so if anyone would like to try it and report here the findings, I would be thankful.

There are plenty of touchpads issues on Chromium: https://bugs.chromium.org/p/chromium/issues/list?can=2&q=touchpad

Are we hitting a known issue for them?

dgiagio commented 8 years ago

I can confirm this happens to me as well, XPS 15 with precision touchpad. Please let me know if there's anything I can do to help track this down. Thanks.

hchris28 commented 8 years ago

I also am experiencing this problem on an XPS 15, am happy to help track it down.

alexdima commented 8 years ago

In #13612, -- https://github.com/Microsoft/vscode/issues/13612#issuecomment-256181669 -- we have received confirmation that this was an issue with Chromium 52 that got fixed already in Chromium 54. We are now sitting on Electron 1.3.8 that is built on Chromium 52 and I am sorry that until we update, there is no workaround we can do on our side.

fyi @kieferrm @egamma @bpasero IMHO we should try moving quickly to Chromium 54 given all these trackpad issues. Also see #13612

bpasero commented 8 years ago

We cannot until Electron has updated to Chrome 54 which they only just started..

dgiagio commented 8 years ago

I'm wondering why this doesn't happen with Atom? Doesn't it use the same Electron version as VS Code?

bpasero commented 8 years ago

@dgiagio try Atom Beta to get the same Electron.

dgiagio commented 8 years ago

I'm using Atom 1.12.0, and according to this https://github.com/atom/atom/releases/tag/v1.12.0 it uses Electron 1.3.6 and Chrome 52. No problems with it so far.

bpasero commented 8 years ago

@dgiagio just wondering if our latest insider build changes anything for you. It now uses Chrome 53 instead of 52. You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

sp00ky commented 8 years ago

The preview (1.7.1) fixed the problem for me on my Asus Zenbook.

hchris28 commented 8 years ago

The preview (1.7.1) has not fixed the problem for me on my Dell XPS 15.

michyprima commented 8 years ago

The 1.8.0 preview still has the bug on my XPS 15.

dgiagio commented 7 years ago

1.7.1, 1.7.2 and 1.8.0 all still have the bug on XPS 15 with precision touchpad.

michyprima commented 7 years ago

If I can add something, scrolling is so fucked up on Chrome 55 I switched to Edge... I guess this will take time to get sorted. 👎

hchris28 commented 7 years ago

I can confirm also that 1.8.0 still has the bug on my XPS 15.

hchris28 commented 7 years ago

1.8.1 checking in, scrolling is still not working well.

alexey-kozlenkov commented 7 years ago

UPD

I've just figured out some magic. If I run VSCode as an administrator, then scrolling does not work. If I run VSCode just as it is, scrolling does work.

I have a Windows 10 Home Edition, for now version is: 10.0.14393 - build 14393

Hope it will help.


Happened with me again today. Last VSCode update was several days ago, but everything was fine right before the update till now.

conormdurkan commented 7 years ago

Scrolling extremely choppy and essentially unusable on version 1.81 with Dell XPS 15.

alexdima commented 7 years ago

Something I do on my Surface Book is to "restore" and then maximize the VS Code window. Somehow that makes it that two finger scrolling works smooth for me.

hchris28 commented 7 years ago

I have found that the restore/maximize trick works on my XPS 15 as well, but it doesn't "stick" and may need to be done periodically.

rcdmk commented 7 years ago

The restore/maximize doesn't work for my ASUS X555U.

I have another trick that does work as long as I keep focus on the VS code window:

  1. Tap with tree fingers, so Search/Cortana pannel shows up to the left of screen
  2. Swipe with two fingers over the VS code window and notice that the document does scroll

I'm on version 1.9.0 on Windows 10 with all drivers updated. I've noticed this issue on 1.7 that was when I bought this notebook.

Timvrakas commented 7 years ago

Still an issue on 1.11.0 on my XPS 15. Looks to be isolated to "Precision" Touchpads (used in both XPS 15 and MS Surface) Switching to windowed mode and back to full screen fixes the issue for a bit.

pendar747 commented 7 years ago

@Timvrakas I also confirm the same problem on my XPS 15 (Thanks for the temporary solution though)

bpasero commented 7 years ago

Todays VS Code insider build comes with Electron 1.6.x, would be interesting to hear if this update solves this issue for anyone: http://code.visualstudio.com/Download#insiders

hchris28 commented 7 years ago

XPS 15 checking in again, scrolling is still choppy on version 1.11.1

bpasero commented 7 years ago

@hchris28 our insiders release is version 1.12.x

hchris28 commented 7 years ago

Apologies.

michyprima commented 7 years ago

@bpasero 1.12 scrolling is still choppy on my XPS 15

bpasero commented 7 years ago

Any improvement or no change at all?

michyprima commented 7 years ago

not sure if there was an improvement but if there was we are talking about something nearly unnoticeable

Timvrakas commented 7 years ago

1.12.0 has no improvement here

On Mon, Apr 10, 2017 at 12:52 PM, michyprima notifications@github.com wrote:

not sure if there was an improvement but if there was we are talking about something nearly unnoticeable

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/12637#issuecomment-293026967, or mute the thread https://github.com/notifications/unsubscribe-auth/ACZe9NlNqAX0l6iXfJXdIEwnNDYiGzRsks5rumxRgaJpZM4KGkID .

-- Tim Vrakas "Failure to follow this advice may result in non-deterministic behavior."

zhengbli commented 7 years ago

No improvement in the latest insider build. Still have to reside the window every now and then to get around it.

Edit: My version:

image

alexdima commented 7 years ago

From reading through all the comments, I believe we should merge this issue and #13612.

Let's continue tracking in #13612, as that issue has the same number of upvotes, but more comments and more participants. I have also put together a wiki page that collects a summary of known workarounds to the scrolling problem at https://github.com/Microsoft/vscode/wiki/Known-issues