search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.2k stars 29.29k forks source link

macOS window controls aren't vertically centered on 1.59.0 with custom titlebar #130448

Closed eramdam closed 3 years ago

eramdam commented 3 years ago

Issue Type: Bug

Like the title says, it seems like 1.59 broke the alignment of the traffic lights on macOS when using the custom titlebar.

VS Code version: Code 1.59.0 (Universal) (379476f0e13988d90fab105c5c19e7abc8b1dea8, 2021-08-04T23:14:40.191Z) OS version: Darwin x64 20.6.0 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|2, 2, 2| |Memory (System)|32.00GB (4.80GB free)| |Process Argv|--crash-reporter-id 4c84f177-bf41-4757-bf36-b2507dfc741a --crash-reporter-id 4c84f177-bf41-4757-bf36-b2507dfc741a --crash-reporter-id 4c84f177-bf41-4757-bf36-b2507dfc741a| |Screen Reader|no| |VM|0%|
Extensions (56) Extension|Author (truncated)|Version ---|---|--- vscode-sievehighlight|adz|1.0.2 vscode-zipfs|arc|2.3.0 unique-lines|bib|1.0.0 docs-view|bie|0.0.9 better-toml|bun|0.3.2 bracket-pair-colorizer-2|Coe|0.2.1 mustache|daw|1.1.1 vscode-eslint|dba|2.1.23 vscode-dash|dee|2.4.0 gitlens|eam|11.6.0 vsc-material-theme|Equ|33.2.0 vsc-material-theme-icons|equ|1.2.2 vsc-material-theme-icons|equ|2.0.10 prettier-vscode|esb|8.1.0 vscode-projects-plus|fab|1.23.4 vscode-firefox-debug|fir|2.9.4 flow-for-vscode|flo|1.9.1 auto-rename-tag|for|0.1.8 applescript|idl|0.21.0 vscode-styled-components|jpo|1.6.6 syntax-project-pbxproj|mar|0.1.3 dotenv|mik|1.0.1 ecdc|mit|1.4.0 python|ms-|2021.8.1105858891 vscode-pylance|ms-|2021.8.0 jupyter|ms-|2021.8.1195043623 remote-ssh|ms-|0.65.7 remote-ssh-edit|ms-|0.65.7 remote-wsl|ms-|0.58.2 atom-keybindings|ms-|3.0.9 debugger-for-chrome|msj|4.12.12 material-icon-theme|PKi|4.9.0 vscode-commons|red|0.0.6 vscode-yaml|red|0.22.0 vscode-sort-json|ric|1.20.0 shebang-snippets|rpi|0.1.4 rust|rus|0.7.8 vs-code-prettier-eslint|rve|3.0.4 vscode-brewfile|sha|1.0.0 mdx|sil|0.1.0 svg-preview|Sim|2.8.3 fish-vscode|sky|0.2.1 move-ts|str|1.12.0 lua|sum|2.3.6 language-stylus|sys|1.11.0 ayu|tea|0.20.1 stylus-supremacy|thi|2.16.0 vscode-asl|Tho|1.0.0 html-preview-vscode|tht|0.2.5 ghosttext|tok|1.1.0 hammerspoon-snippets|vir|0.0.5 change-case|wma|1.0.0 open-in-github-desktop|wra|1.4.2 markdown-all-in-one|yzh|3.4.0 vscode-open-in-github|ziy|1.3.6 grammarly|znc|0.14.0 (3 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 pythonvspyt602:30300191 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyt639:30300192 pythontb:30283811 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 pythondataviewer:30285071 pythonvsuse255:30340121 vscod805:30301674 pythonvspyt200:30340761 vscextlangct:30333562 binariesv615:30325510 pythonvssor306:30344512 bridge0708:30335490 vstre464:30346472 bridge0723cf:30346311 ```
vscodebot[bot] commented 3 years ago

(Experimental duplicate detection) Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

eramdam commented 3 years ago

Oops, i didn't find the duplicated issue when searching 🙈