microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.75k stars 29.47k forks source link

Debugger points to wrong file after upgrade to 1.60.0 #132644

Closed krystianolech closed 3 years ago

krystianolech commented 3 years ago

Issue Type: Bug

Hi, I noticed that after upgrade to the newest version my debugger scripts start working incorrectly after upgrading to new version of vsocde.

The debugger script I use is responsible to open mocha tests written in typescript. It uses ts-node as transpiler so files are not compiled before running tests.
` { "type": "node", "request": "launch", "name": "Mocha tsc", "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha", "args": ["-r", "ts-node/register", "src/*/.test.ts"], "console": "integratedTerminal",

  "internalConsoleOptions": "neverOpen",
  "protocol": "inspector",
  "skipFiles": ["<node_internals>/**/*.js"]
}`

In the current version when I set up breakpoint it break in a virtual compiled file on incorrect line: Screenshot 2021-09-08 at 15 08 51

While in 1.59 It was pointing to the source file correctly: Screenshot 2021-09-08 at 15 17 32

What I noticed is that usage of reflect-metadata has an impact on it, as it works correctly in projects where I don't use it.

Here is a repository with minimal source code that reproduces issue: https://github.com/krystianolech/vscode-issue-132644

VS Code version: Code 1.60.0 (e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff, 2021-09-01T10:54:53.442Z) OS version: Darwin x64 20.6.0 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)| |GPU Status|2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|3, 3, 3| |Memory (System)|16.00GB (0.03GB free)| |Process Argv|--crash-reporter-id 8a7267e1-1a43-4f53-8977-59c6c2c75859| |Screen Reader|yes| |VM|0%|
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspyt653:30270858 pythonvspyt602:30300191 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyt639:30300192 pythontb:30283811 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 pythondataviewer:30285071 pythonvsuse255:30340121 vscod805:30301674 pythonvspyt200:30340761 vscextlang:30333561 binariesv615:30325510 vsccppwt:30329788 pythonvssor306:30344512 bridge0708:30335490 pygetstartedc2:30360494 bridge0723:30353136 pythonf5test824:30361777 pythonvspyt187:30362782 pydsgsc2:30361791 vscus224cf:30358040 vssid140:30363603 ```
connor4312 commented 3 years ago

/duplicates https://github.com/microsoft/vscode-js-debug/issues/1100

See my comment on there for a resolution