search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.66k stars 28.68k forks source link

Expose Keymap command in Keyboard Shortcuts toolbar #132677

Closed digitarald closed 8 months ago

digitarald commented 3 years ago

Usertesting showed that keymap extensions are not easy to discover due to a mix of issues. Users have many different terms for them, don't know that they exist or don't look in the right places.

To improve organic discovery the idea here is similar to Turn on Settings Sync button in Settings, showing a Migrate your Keyboard Shortcuts from other Editors in the Keyboard Shortcuts page.

To focus on new users, it could be hidden when a user installed a keymap.

daviddossett commented 3 years ago

To clarify, would the command just bring up the filtered keymaps extensions view?

One possible option would be an additional icon added the toolbar e.g.

CleanShot 2021-09-09 at 13 18 39@2x

We don't yet have the right icon in codicons so consider the new icon a placeholder for now

digitarald commented 3 years ago

The command is workbench.extensions.action.showRecommendedKeymapExtensions (Preferences: Keymaps)

One possible option would be an additional icon added the toolbar e.g.

I am skeptical that am icon solves the discoverability problem. The UI is already pretty dense and an icon might just blend in with everything. Could we explore a non-primary labeled button as well?

daviddossett commented 3 years ago

I agree. Without changing the existing toolbar I can see that the commands can also feature a label. However I've never seen this used in VS Code so I'm not sure it's the right way to go.

I'll take a look at some other options and will report back.

CleanShot 2021-09-09 at 13 32 42@2x
daviddossett commented 3 years ago

Oh ok, I see what you're referring to now re: Settings Sync. Hadn't noticed this since it's always been on for me :)

CleanShot 2021-09-09 at 13 45 41@2x
daviddossett commented 3 years ago

Secondary button inline with search

CleanShot 2021-09-09 at 13 50 50@2x

With H1 + Secondary button

I realize this one is a bit of scope creep here. I'm actually curious how we're getting away without an H1 on this or similar pages. @misolori would you have any context there?

CleanShot 2021-09-09 at 13 50 58@2x
miguelsolorio commented 3 years ago

We tend to rely on the file tab as the "heading" for most of our single pages (settings, running extensions, etc.) and the extensions detail page is one of the exceptions of this:

image

digitarald commented 8 months ago

Closing for now as we lost traction on this.