github.dev: extension contributed terminals don't show up when welcome view is active

[Tyriar]

In a web extension register a terminal profile provider that creates a vscode.PseudoTerminal. When the terminal welcome view is active, creating a terminal doesnt replace the welcome view:

Clicking this

results in just this:

I can click on Move into editor are:

and that'll show the terminal as an editor and at that point the welcome view is gone and the terminal view works normally

[srivatsn]

This happens in vscode.dev/liveshare now. Repro:

1. Make sure the terminal was opened once before closing a session - so that it's focused when vscode initializes.
2. Now join a Liveshare session where terminal has been shared.

That terminal won't show up because the welcome view would have been rendered before the liveshare extension got a chance to create a terminal. This doesnt happen if the terminal wasn't already opened.

[meganrogge]

fixed with https://github.com/microsoft/vscode/pull/136327

[meganrogge]

to verify:

• run yarn watch-web && web
• install a web extension that contributes a terminal profile
• click the plus button
• the terminal should appear and not be covered by the welcome view

[rchiodo]

/verified