search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.08k stars 28.81k forks source link

Support MS Edge's "edge-enhance-text-contrast" flag #137013

Open monoblaine opened 2 years ago

monoblaine commented 2 years ago

I've always avoided Chromium based software because of the blurry font rendering issue that has existed since GDI font rendering support was dropped years ago.

Thankfully, months ago, Microsoft fixed the issue in Chromium Edge with the edge-enhance-text-contrast flag:

https://blogs.windows.com/msedgedev/2021/06/02/improving-font-rendering-in-microsoft-edge/

Are there any plans to incorporate that fix into VS Code?

vngmar commented 2 years ago

Very important. Bad font rendering (especially on Windows) is a persistent and annoying issue with VSCode.

TechnoSparks commented 2 years ago

Every time there is a new Insider release, I hope for this to be implemented. It's at the point where i am considering using vscode.dev in Edge

VSCodeTriageBot commented 1 year ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

VSCodeTriageBot commented 1 year ago

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

monoblaine commented 1 year ago

I just wanted to say (without expectation) that you guys would make me the happiest person in the world if GDI support was brought back. (an example: https://github.com/GTANAdam/GDIChromium)

TechnoSparks commented 4 months ago

After a year since this issue is created, it finally went to the backlog ... only to be no news since then.

However the platform stack have made significant changes. Chromium 124 has added the much needed improvements to the Skia font renderer, it now respects the Windows' ClearType settings. https://chromestatus.com/feature/6236420349100032

That means, when vscode upgrades its Electron version to version 30 it indirectly solves this issue because Electron 30 ships Chromium 124, and as such also has the edge-enhance-text-contrast improvements that was previously implemented in Microsoft Edge.

Here's a comparison on how much this helps with text clarity on non-HiDPI displays:

Chromium 124 Chromium 120 (current vscode)
image image
Screenshot taken from vscode.dev in Vivaldi 6.7 on Windows 11 (is Chrome/124). Screenshot taken from vscode on Windows 11 (is Chrome/120)

vscode-insiders is Chromium 122. Screenshots above are: - Font used is Iosevka - Taken on a screen with 1080p resolution at 100% scaling with RGB layout

TechnoSparks commented 2 months ago

I am disappointed. The latest insider version of today does not have the font contrast improvement despite using Electron version 30. This means vscode actually have its own font renderer or is augmenting Electron's, thus this problem is unique to vscode. Guess I'll code in vscode.dev paired with vscode-server forever then?

Serpent03 commented 2 months ago

No hope for this..? :(

VSCode in browser looks radically different, and way more aesthetically pleasing than the application.