search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.45k stars 28.63k forks source link

Consider adopting a new ini grammar #141632

Open alexr00 opened 2 years ago

alexr00 commented 2 years ago

We get our ini syntax highlighting grammar from textmate/ini.tmbundle. Upstream issue: textmate/ini.tmbundle#2

@alexr00

Hello, since I'm also facing this issue constantly (also with ' char) I've checked the linked repository and it seems that is completely abandoned - the last commit is from 9 years ago and none of the submitted PR's was merged. This indicates that the problem/bug might persist forever.

If the ini syntax highlighting grammar was taken from this repo a long time ago then why it can't be fixed/updated by VSCode team? Can you re-open this issue and suggest a new approach how to fix it?

Originally posted by @ALIENQuake in https://github.com/microsoft/vscode/issues/139531#issuecomment-1022557028

alexr00 commented 2 years ago

@ALIENQuake it's hard for a smallish team like the VS Code team to be experts in every language we want to provide syntax highlighting for, so we won't be updating the grammar ourselves. However, we've had several abandoned grammar repos in recent years that members of the community have offered well maintained alternatives for (https://github.com/microsoft/vscode/commit/a1481e3e2e51f833ce5001500f4b4559c5777cb7, https://github.com/microsoft/vscode/issues/115480, and https://github.com/microsoft/vscode/issues/140489). If the owner of a well maintained ini textmate grammar asks that we try using their grammar instead then I'd be happy to consider adopting it!

In the mean time maybe there is an extension you can install that will provide better syntax highlighting for your ini files. As a last resort, you can disable the built in ini extension too.

ALIENQuake commented 2 years ago

@alexr00 I have new code for ini grammar that fixes ' bug. Does having a separate repository is required of I could simply send PR?

alexr00 commented 2 years ago

@ALIENQuake a separate repository is required. Some evidence that the new grammar will continue to be maintained is also very helpful (for example, a history of maintaining the grammar as part of an extension).