search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.55k stars 29k forks source link

Tangle `searchEditor` <=> `search` #142723

Open bpasero opened 2 years ago

bpasero commented 2 years ago

I wonder if we should simply move all of searchEditor into search?

image

JacksonKearl commented 2 years ago

@roblourens what do you think? The dependencies tend to be from the search view being able to open its results in an editor and various search related commands delegating to the view or editor based on whatever is active.

roblourens commented 2 years ago

It seems like the search editor is a distinct thing with enough code that it deserves its own folder. Could we extract out a searchCommon or would it just be a ton of refactoring work?