Request feature "Integrated terminal"

[kkdai]

It would be great if vscode has integrated terminal feature refer vim or atom https://atom.io/packages/term3

I saw this suggestion pending in uservoice(https://visualstudio.uservoice.com/forums/293070-visual-studio-code/suggestions/7752357-integrated-terminal) and repost here since it has specific repo

[Tyriar]

After trying again on Windows 10 with the new cmd, it seems to work just fine. As such I think I'll make the default %COMSPEC% which points at cmd by default. This makes it consistent with the open in (external) terminal command. https://github.com/Microsoft/vscode/issues/6886

[builden]

in chinese system show confusiton code

Version 1.2.0 insider

[Tyriar]

@builden What does it show when you run the same command in the native terminal outside of vscode?

[builden]

@Tyriar

[Tyriar]

@builden thanks, looks like the CJK chars are stacked on top of each other. Looks like it was just filed here https://github.com/Microsoft/vscode/issues/7036

[builden]

@Tyriar Great have another question: { "key": "ctrl+`", "command": "workbench.action.terminal.toggleTerminal" }, this shortcut is invalidation

[Tyriar]

@builden what keyboard layout are you using?

[builden]

@Tyriar like this

[Tyriar]

@builden So the key next to 1 doesn't work? Works from the testing I've done on Mac/Windows/Linux using US keyboard layout (which seems to be the same).

[builden]

@Tyriar i change shortcut string can work fine

[builden]

@Tyriar I have find the reason, ctrl+` have used by other application

[Tyriar]

@builden was it cmder that's using the keybinding?

[builden]

@Tyriar It's my Chinese input application "QQ Pinyin"

[Tyriar]

@builden ah, I think that's pretty command for keybindings to break when an IME is active.

[builden]

@Tyriar I have closed the IME keybinding, but another person is hard to find which app have binded the command

[willin]

@Tyriar how to use in os x

{ "key": "ctrl+shift+t",          "command": "launcher.terminal" }

no use

[builden]

@Tyriar In Windows, I can't copy string from terminal page, I think this feature is necessary

[Tyriar]

@willin try this:

{ "key": "ctrl+shift+t", "command": "workbench.action.terminal.toggleTerminal" },

@builden polishing the copy and paste experience is planned for the June release https://github.com/Microsoft/vscode/issues/6451

[Tyriar]

Thanks everyone for your contributions! I'm going to lock the conversation to prevent pinging all the participants for smaller issues. If you find any other problems please check out the existing issue list and create a new one if necessary.

[Tyriar]

See https://github.com/Microsoft/vscode/issues/7302#issuecomment-225097257 for the proposed default keybindings used by the terminal.

[Tyriar]

You can see a glimpse of what's coming in v1.3.0 in the June test plan: https://github.com/Microsoft/vscode/issues/8222