search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.23k stars 28.56k forks source link

Terminal tabs: should reset the tab name to the default value when no name is provided #146796

Closed bpasero closed 1 month ago

bpasero commented 2 years ago 
  1) VSCode Smoke Tests (Electron)
       Terminal
         Terminal Tabs
           should reset the tab name to the default value when no name is provided:
     Error: Timeout: get element '.single-terminal-tab' after 20 seconds.
      at poll (D:\a\_work\1\s\test\automation\src\code.ts:120:10)
      at Code.waitForElement (D:\a\_work\1\s\test\automation\src\code.ts:264:10)
      at Terminal.assertTabExpected (D:\a\_work\1\s\test\automation\src\terminal.ts:191:5)
      at Terminal.assertSingleTab (D:\a\_work\1\s\test\automation\src\terminal.ts:126:3)
      at Context.<anonymous> (src\areas\terminal\terminal-tabs.test.ts:68:4)

Here are some builds (Windows, desktop):

And found actually one in browsers:

bpasero commented 2 years ago

Interestingly this test seems to flake more in the new playwright based desktop tests, but I was lucky to find a web case too.

bpasero commented 2 years ago

playwright-trace-1-should_reset_the_tab_name_to_the_default_value_when_no_name_is_provided.zip

deepak1556 commented 3 months ago

@meganrogge this test has failed again in a recent run https://dev.azure.com/monacotools/Monaco/_build/results?buildId=277305&view=logs&j=4801dce2-64f3-53d6-b366-d49a1977c639&t=d3816dfe-5f5f-5b74-f77f-0a43291213b6. Reopening for triage.

meganrogge commented 1 month ago

terminal panel never even opens 🤔

Image

meganrogge commented 1 month ago

/duplicate #216564