Closed bpasero closed 2 years ago
This is impossible for me to reproduce in an isolated sample. Check out https://github.com/bpasero/playwright-electron, it copies a lot of stuff we do in VSCode:
vscode-file
protocolipcRenderer.invoke
To run it just node index.js
and see how the URL is printed in the page.
@deepak1556 need your advice how to proceed, how can we instrument Electron app to figure out where the call is coming from?
//cc @pavelfeldman maybe you know if Playwright tampers with Electron startup somehow that could explain this. To clarify: we see a event.senderFrame.url
that is the empty string in a ipcMain.handle
invocation here.
I was able to reproduce the issue on Windows at least and filed https://github.com/electron/electron/issues/33800 for Electron team to look at, but it might be a playwright issue too.
Nevermind, I had a bug in my sample and I was not able to reproduce and I am running out of ideas. I think to proceed we would have to instrument Electron in a way to figure out why the URL is empty. Sam might a suggestion but I do not see any loading failures.
hello i'm be working in a project like this, The binaries for node electron and vscode all fail in my debootstrap chroot. i finally have systemd running.
I will start a project on my own fork, Nice work
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.
If you wonder what we are up to, please see our roadmap and issue reporting guidelines.
Thanks for your understanding, and happy coding!
While implementing the
ipcMain
validation, we ran into two issues:sender.url
being an empty string when usingplaywright
for testing