Github login vscode (turn on setting sync) many failures

stone2401 commented 2 years ago

Does this issue occur when all extensions are disabled?: Yes/No There's only one plug-in : Chinese (Simplified) (简体中文) Langua

VS Code Version: VSCode-1.67.0-insider and VSCodeSetup-1.66.2
OS Version: windows10 x64

Steps to Reproduce:

No error message is reported during the whole process, But I still can't log in
1. Account click turn on setting sync ------> sign in ---> Insiders and Stable(all try) ----> Singn in with github
2. The github sign in normal. ----> Redirection normal -----> Successfully jumped back to vscode ---> click open
3. But vscode is still not logged in ------> Tried many times ----> All failure
4. I'll take github Authentication and put it here, Are all the same

stone2401 commented 2 years ago

The Microsoft login is ok, but I want to use GitHub Copilot, So loginusing Gitthub

TylerLeonhardt commented 2 years ago

I've made some improvements in this space a couple days ago. Can you try insiders again?

TylerLeonhardt commented 2 years ago

/gifPlease

stone2401 commented 2 years ago

ok

isatsam commented 2 years ago

EDIT: I've got the Github desktop app and have not been able to log in from it either (similar symptoms to VSCode: redirect to browser, redirect back, app hangs on "signing in" forever), so I'm not sure that it's an error on VSCode behalf anymore. If it's fine I'm going to leave the original comment I wrote here.

I'm currently experiencing a similar issue in VSCode on Debian. Here's what I'm trying to do:

Profile icon in the bottom left corner > Sign in to Sync settings > Github > Log in the window that's opened in Firefox, success > Redirect to the authotised application > VSCode shows "Signing in to github.com / Source: GitHub Authentication (Extension)" in Notifications > Notification changes to "Cancelled". At the end VSCode is still not signed in.

vscode-output

Version info: Version: 1.66.2 Commit: dfd34e8260c270da74b5c2d86d61aee4b6d56977 Date: 2022-04-11T07:49:24.808Z Electron: 17.2.0 Chromium: 98.0.4758.109 Node.js: 16.13.0 V8: 9.8.177.11-electron.0 OS: Linux x64 5.10.0-14-amd64

Also: Debian 11 with KDE Plasma desktop 5.20.5, gnome-keyring 3.36.0

stone2401 commented 2 years ago

Screenshot_20220505_010635 Screenshot_20220505_010811

This is my error message，Looks like a request error

dtashlykov commented 2 years ago

I'm getting the same thing, Linux machine.

Unable to sign in to GitHub, authentication output:

[Info - 23:16:25.971] Reading sessions from keychain... [Info - 23:16:25.973] Getting sessions for user:email... [Info - 23:16:25.974] Got 0 sessions for user:email... [Info - 23:16:25.986] Getting sessions for all scopes... [Info - 23:16:25.986] Got 0 sessions for ... [Info - 23:16:30.119] Getting sessions for repo,workflow... [Info - 23:16:30.119] Got 0 sessions for repo,workflow... [Info - 23:16:31.254] Logging in for the following scopes: repo workflow

TylerLeonhardt commented 2 years ago

1.67 is out and has some fixes around falling back to other ways to log in. Can you all give this a go?

isatsam commented 2 years ago

1.67 is out and has some fixes around falling back to other ways to log in. Can you all give this a go?

The 127.0.0.1 redirect workaround worked flawlessly for me, thanks for the heads up!

vscodenpa commented 2 years ago

Hey @TylerLeonhardt, this issue might need further attention.

@stone2401, you can help us out by closing this issue if the problem no longer exists, or adding more information.

TylerLeonhardt commented 2 years ago

Closing this since there hasn't been any activity and the last comment said it's working again

microsoft / vscode

Github login vscode (turn on setting sync) many failures #147974