microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.57k stars 29.01k forks source link

Source Control tab auto refresh changes broken #149231

Closed TouqeerH closed 10 months ago

TouqeerH commented 2 years ago

Issue Type: Bug

Source control changes are not auto updating. I have to press Refresh icon for them to update.

VS Code version: Code 1.67.0 (57fd6d0195bb9b9d1b49f6da5db789060795de47, 2022-05-04T12:06:02.889Z) OS version: Windows_NT x64 10.0.22000 Restricted Mode: No Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2 Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1800)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|11.92GB (1.17GB free)| |Process Argv|--crash-reporter-id d0a57e2f-0a36-4ede-977a-d028684edf07| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|WSL: Ubuntu-20.04| |OS|Linux x64 5.10.16.3-microsoft-standard-WSL2| |CPUs|Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1799)| |Memory (System)|5.76GB (0.67GB free)| |VM|0%| |Item|Value| |---|---| |Remote|WSL: Ubuntu-20.04| |OS|Linux x64 5.10.16.3-microsoft-standard-WSL2| |CPUs|Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 1799)| |Memory (System)|5.76GB (0.67GB free)| |VM|0%|
Extensions (33) Extension|Author (truncated)|Version ---|---|--- es7-react-js-snippets|dsz|4.4.3 vsc-material-theme|Equ|33.4.0 vsc-material-theme-icons|equ|2.3.1 auto-rename-tag|for|0.1.10 jupyter-keymap|ms-|1.0.0 remote-containers|ms-|0.234.0 remote-ssh|ms-|0.78.0 remote-ssh-edit|ms-|0.80.0 remote-wsl|ms-|0.66.2 vscode-remote-extensionpack|ms-|0.21.0 material-icon-theme|PKi|4.17.0 material-theme|zhu|3.13.25 vscode-intelephense-client|bme|1.8.2 path-intellisense|chr|2.8.0 vscode-svgviewer|css|2.0.0 vscode-eslint|dba|2.2.2 es7-react-js-snippets|dsz|4.4.3 gitlens|eam|12.0.6 vscode-html-css|ecm|1.12.2 vsc-material-theme|Equ|33.4.0 vsc-material-theme-icons|equ|2.3.1 prettier-vscode|esb|9.3.0 auto-rename-tag|for|0.1.10 copilot|Git|1.17.5850 vscode-pull-request-github|Git|0.42.0 implicit-parentheses|Jor|1.0.0 formate|Mik|1.2.1 jupyter-keymap|ms-|1.0.0 fix-json|oli|0.1.2 material-icon-theme|PKi|4.17.0 autoimport|ste|1.5.4 vscode-import-cost|wix|3.3.0 material-theme|zhu|3.13.25 (4 theme extensions excluded)
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 pythonvspyl392:30443607 pythontb:30283811 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805cf:30301675 pythonvspyt200:30340761 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 vsc1dst:30438360 pythonvs932:30410667 wslgetstarted:30449410 pythonvsnew555:30457759 vscscmwlcmt:30465135 cppdebug:30475216 ```
lszomoru commented 2 years ago

@TouqeerH, I see that you are using VS Code with WSL. Are you opening a folder/workspace that is hosted on the Windows file system (ex: /mnt/...) or a folder/workspace that is hosted on the Linux file system. As of right now, there is a known issue with WSL where file system event for files hosted on the Windows file system are not being delivered which the SCM viewlet relies on. Until the WSL team addresses this issue, the only workaround is to either store the files on the Linux file system, or to manually hit the refresh button.

pokey commented 2 years ago

I am seeing this bug intermittently as well

VS Code version: Code 1.71.0 (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:25:38.437Z) OS version: Darwin x64 21.5.0 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|5, 5, 5| |Memory (System)|32.00GB (0.02GB free)| |Process Argv|--crash-reporter-id 99d35f96-61a9-461b-a60d-f915d32f3eee| |Screen Reader|no| |VM|0%|
Extensions (90) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 Bookmarks|ale|13.3.1 andreas-talon|And|1.22.0 vscode-neovim-hacked|asv|0.0.85 All-Autocomplete|Ati|0.0.23 agda-mode|ban|0.3.11 markdown-checkbox|bie|0.3.2 markdown-mermaid|bie|1.15.2 mermaid-markdown-syntax-highlighting|bpr|1.4.1 vscode-tailwindcss|bra|0.8.6 turbo-console-log|Cha|2.5.1 path-intellisense|chr|2.8.1 regex|chr|0.4.0 doxdocgen|csc|1.4.0 vscode-eslint|dba|2.2.6 vscode-dash|dee|2.4.0 dendron-markdown-shortcuts|den|0.12.1 chmod|dle|1.1.1 githistory|don|0.6.19 xml|Dot|2.5.1 viml|dun|0.1.7 gitlens|eam|12.2.1 EditorConfig|Edi|0.16.4 prettier-vscode|esb|9.8.0 foam-vscode|foa|0.19.5 remotehub|Git|0.42.0 vscode-pull-request-github|Git|0.50.0 mdmath|goe|2.7.4 vscode-graphql|Gra|0.7.4 vscode-graphql-syntax|Gra|1.0.4 rest-client|hum|0.25.1 better-cpp-syntax|jef|1.15.19 cmake-language-support-vscode|jos|0.0.4 jq-syntax-highlighting|jq-|0.0.2 vscode-tree-sitter-query|jri|0.0.1 bash-ide-vscode|mad|1.14.0 syntax-project-pbxproj|mar|0.1.3 rainbow-csv|mec|2.4.0 git-graph|mhu|1.30.0 vscode-edits-history|mis|0.1.6 vscode-talonscript|mro|0.3.13 vscode-docker|ms-|1.22.1 vscode-dotnet-runtime|ms-|1.5.0 black-formatter|ms-|2022.5.12301009 isort|ms-|2022.3.12411008 python|ms-|2022.14.0 vscode-pylance|ms-|2022.8.50 jupyter|ms-|2022.8.1002431955 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.9 remote-containers|ms-|0.251.0 remote-ssh|ms-|0.84.0 remote-ssh-edit|ms-|0.80.0 cmake-tools|ms-|1.12.26 cpptools|ms-|1.12.4 cpptools-extension-pack|ms-|1.3.0 remote-repositories|ms-|0.20.0 vscode-github-issue-notebooks|ms-|0.0.119 vsliveshare|ms-|1.0.5705 vsliveshare-audio|ms-|0.1.91 vscode-react-native|msj|1.9.2 vscode-paste-image|mus|1.0.4 autodocstring|njp|0.6.1 angular-console|nrw|17.21.0 command-server|pok|0.8.2 cursorless|pok|0.26.421 parse-tree|pok|0.21.0 ruby|reb|0.28.1 LiveServer|rit|5.7.9 format-code-action|roh|0.1.0 multi-command|ryu|1.6.0 scala|sca|0.5.6 metals|sca|1.19.0 vscode-scheme|sjh|0.4.0 vscode-fileutils|sle|3.5.0 sourcery|sou|0.12.7 rewrap|stk|1.16.3 vscode-open-in-github|sys|1.17.0 tabnine-vscode|Tab|3.6.14 even-better-toml|tam|0.18.1 rest-book|tan|6.2.1 vscode-lua|tri|0.12.4 cmake|twx|0.0.17 commands|use|1.4.0 vscodeintellicode|Vis|1.2.24 vscodeintellicode-completions|Vis|1.0.18 vscode-icons|vsc|11.16.0 vscode-alternate-file|wil|0.3.1 vscode-ruby|win|0.28.0 JavaScriptSnippets|xab|1.8.0 (1 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30445987 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30557514 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vscaac:30438847 pylanb8912:30545647 vsclangdf:30486550 c4g48928:30535728 hb751961:30553087 dsvsc012cf:30540253 azure-dev_surveyone:30548225 i497e931:30553904 ```
lszomoru commented 1 year ago

@pokey, could you also please answer this question? Thanks!

pokey commented 1 year ago

@pokey, could you also please answer this question? Thanks!

I'm on a Mac, so I don't think that question applies to me, unless I'm misunderstanding?

lszomoru commented 1 year ago

@pokey, in case you are able to reproduce it would be great to create a recording (https://gifcap.dev) to investigate further.

pokey commented 1 year ago

To be honest, I'm not seeing this much anymore. Maybe @TouqeerH is able to reproduce it reliably?

lszomoru commented 1 year ago

@pokey, thanks for the update. I will go ahead and close this issue for now. @TouqeerH, please feel free to reopen the issue in case you are still able to reproduce it. Thanks!

pokey commented 1 year ago

This issue seems to have reappeared after I got a new MacBook. It does not happen consistently, and switching applications does seem to trigger a refresh. Which makes it impossible to record a GIF, unfortunately, because when I switch to my GIF recorder and back to VSCode it will have refreshed

I don't seem to be able to reopen this issue

lszomoru commented 1 year ago

@pokey, I went ahead and re-opened the issue for you, but in order for me to investigate the issue it would be great if you could narrow down a set of steps that you can use to reproduce the issue. Then, we can collect some additional information order to try to track down the root cause. Thanks!

pokey commented 1 year ago

Thank you. So far I haven't been able to identify a consistently reproducible case; seems to be pretty intermittent. I'll try my best to come up with something though

pokey commented 1 year ago

It seems to be happening fairly consistently right now. Is there some specific info I can provide to help you debug this one? Fwiw if I focus another application and then focus VSCode again, it refreshes

lszomoru commented 1 year ago

@pokey, apologies for not getting back to you on this. Assuming that you are still able to reproduce this issue consistently you can enable trace logging as described in this wiki and share the file watcher logs as well as the contents of the git output window. Hopefully that will help us further investigate the issue. Thanks!

vscodenpa commented 1 year ago

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

pokey commented 1 year ago

Here is the requested information. In the following, I deleted a character and then saved a file, and the git view still displayed no changed files. Here was the requested output during that time:

Debug console

log.ts:401 TRACE [File Watcher (parcel)] [CHANGED] /Users/pokey/src/cursorless/packages/cursorless-vscode/src/scripts/populateDist/transformPackageJson.ts
log.ts:401 TRACE [File Watcher (parcel)]  >> normalized [CHANGED] /Users/pokey/src/cursorless/packages/cursorless-vscode/src/scripts/populateDist/transformPackageJson.ts

Git output panel

2023-04-04 15:16:47.708 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-04-04 15:16:47.750 [info] > git ls-tree -l 48f7592058a72addf24559d33a275f6a8f88e71e -- packages/cursorless-vscode/src/scripts/populateDist/transformPackageJson.ts [41ms]
2023-04-04 15:16:47.750 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2023-04-04 15:16:47.752 [trace] Operation start: HashObject (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-04-04 15:16:47.784 [info] > git hash-object -w --stdin [32ms]
2023-04-04 15:16:47.816 [info] > git config --get commit.template [29ms]
2023-04-04 15:16:47.829 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) refs/heads/pokey/automatically-generate-activation-events refs/remotes/pokey/automatically-generate-activation-events [38ms]
2023-04-04 15:16:47.919 [info] > git status -z -uall [88ms]
2023-04-04 15:16:47.920 [trace] Operation end: HashObject (blocking: false, readOnly: false; retry: false; showProgress: true)
2023-04-04 15:16:47.921 [trace] Operation start: Diff (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-04-04 15:16:47.964 [info] > git diff f7d0728008b5434df774eec623d8068595417713 f8eb4ba0d76b444e2e784d1186e412f4c067b721 [43ms]
2023-04-04 15:16:47.964 [trace] Operation end: Diff (blocking: false, readOnly: true; retry: false; showProgress: true)
2023-04-04 15:16:49.118 [debug] [wt] Change: /Users/pokey/src/cursorless/packages/cursorless-vscode/src/scripts/populateDist/transformPackageJson.ts

It would be great if you could reopen this issue. Thank you for your help

pokey commented 1 year ago

@lszomoru any update on this one?

lszomoru commented 1 year ago

@pokey, apologies for not getting back to you on this until now. From the data that you have shared it seems that the file-system even has fired by VS Code, and it has reached the git extension (last line). I just looked at the code and noticed that the "Source Control" view will not automatically refresh if you have the git.autorefresh setting disabled. Could you check whether that is set in your user/remote settings? Thank you!

lszomoru commented 10 months ago

Closing this issue due to inactivity.