search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.51k stars 28.65k forks source link

Adopt custom hovers in view header toolbars #150884

Open TylerLeonhardt-alt opened 2 years ago

TylerLeonhardt-alt commented 2 years ago

Testing #150557

Recording 2022-05-31 at 10 06 16

When I press Alt after these hovers are displayed, they disappear (and cause File to be selected). This is confusing due to difference of behavior.

This is @TylerLeonhardt's alt account on Linux

Tyriar commented 2 years ago

We have talked about this problem and I think the current plan is that we will move towards the custom hover everywhere. Moving to @sbatten as this is specifically about view headers.

sbatten commented 2 years ago

I think an adoption of custom hovers here would be an adoption for all action/toolbars, but maybe there is a flag. Is the recommendation to go ahead with this change?

bpasero commented 7 months ago

I think this should cover all action bars, not just in view headers to be consistent. It seems unpractical to ask every user of action bars to pass down the IHoverDelegate. We will only play catch-up game for users forgetting about this. For this, I would probably let the workbench set a default hover delegate on startup that is then being picked up by widgets in base automatically.