Maximizing the Integrated terminal clips part of the scrollback buffer, and doesn't increase visible buffer height.

[johncolvin-og]

Issue Type: Bug

I've only observed this bug on Windows.

1) Open the integrated terminal (should be unmaximized). 2) Run a command in the integrated terminal to produce output that grows beyond the terminal's visible height (i.e., so some output is hidden in the scrollback buffer). 3) Scroll up to note the [expected] output for comparison after the next step, then scroll back down to the bottom of the buffer. 4) Maximize the terminal via the "View: Toggle Maximized Panel" command.

Expected Behavior: The terminal grows such that the visible buffer height increases (i.e., lines of output that were previously above the viewport should become visible). No output shouldn't be clipped from the scrollback buffer.

Actual Behavior: The terminal grows, but the visible output doesn't. Empty lines are added below the cursor. Furthermore, scrolling up reveals that the scrollback buffer is missing lines.

VS Code version: Code - Insiders 1.68.0-insider (b7faf235467dd56e4a62e52e7f1cacf875b67261, 2022-06-07T18:33:43.014Z) OS version: Windows_NT x64 10.0.25131 Restricted Mode: No Remote OS version: Linux x64 5.4.0-110-generic

System Info

|Item|Value| |---|---| |CPUs|AMD Ryzen 9 5900HX with Radeon Graphics (16 x 3294)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|31.42GB (11.38GB free)| |Process Argv|--crash-reporter-id 254f34f7-7f90-48b6-a426-cc2e30f35a33| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|Container johns_spark-crypto-dev (johns_spark-crypto-dev) @ ssh://titan| |OS|Linux x64 5.4.0-110-generic| |CPUs|Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (40 x 3380)| |Memory (System)|187.49GB (86.23GB free)| |VM|0%|

Extensions (70)

Extension|Author (truncated)|Version ---|---|--- vscode-monokai-seti|adi|0.0.7 Bookmarks|ale|13.3.0 nugetpackagemanagergui|ali|2.0.2 aramoks-black|ara|1.2.10 vscode-neovim|asv|0.0.85 vscode-icontheme-nomo-dark|be5|1.3.6 markdown-preview-github-styles|bie|1.0.1 vscode-intelephense-client|bme|1.8.2 cmake-format|che|0.6.11 gitlens-insiders|eam|2022.6.705 EditorConfig|Edi|0.16.4 sweet-vscode-icons|Eli|0.0.1 moxer-icons|Equ|5.8.0 vsc-material-theme|Equ|33.4.0 vsc-material-theme-icons|equ|2.3.1 prettier-vscode|esb|9.5.0 mayukaithemevsc|Gul|3.2.2 material-color|guo|1.3.2 vscode-guid|hea|1.4.20 helium-icon-theme|hel|1.0.0 innosetup|idl|1.6.1 Ionide-fsharp|Ion|6.0.5 search-editor-apply-changes|jak|0.1.1 easy-icons|jam|0.3.1 jbockle-format-files|jbo|3.4.0 vscode-nuget-package-manager|jmr|1.1.6 vs-one-dark-theme|jor|0.0.5 vscode-simple-icons|Lau|1.16.0 vscode-clangd|llv|0.1.17 fish-ide|lun|0.4.0 vscode-boost-jam|mlo|0.0.2 mosmmy-icons-vscode|mos|0.1.1 vscode-docker|ms-|1.22.0 csharp|ms-|1.25.0 python|ms-|2022.7.11591004 vscode-pylance|ms-|2022.6.0 jupyter|ms-|2022.6.1001611018 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.8 remote-containers|ms-|0.238.1 remote-ssh|ms-|0.81.2022060215 remote-ssh-edit|ms-|0.80.0 remote-wsl|ms-|0.66.3 cmake-tools|ms-|1.10.5 cpptools|ms-|1.10.4 js-debug-nightly|ms-|2022.6.717 powershell-preview|ms-|2022.5.5 rose-pine|mvl|2.2.0 deepdark-material|Nim|3.3.0 origamid-next|ori|2.0.4 vscode-nuget-gallery|pat|0.0.24 material-icon-theme|PKi|4.18.0 resxpress|Pra|4.5.0 seti-icons|qin|0.1.3 vscode-xml|red|0.20.0 LiveServer|rit|5.7.5 multi-command|ryu|1.5.1 vscode-header-source|ryz|1.3.0 vscode-scss-formatter|sib|2.4.2 fish-vscode|sky|0.2.1 iodine-vscode|spl|0.0.1 vscode-field-lights|sve|0.0.11 cmake|twx|0.0.17 vscode-icons|vsc|11.12.0 vikings-icon-theme|wil|1.0.0 clang-format|xav|1.9.0 php-debug|xde|1.26.1 city-lights-icon-vsc|Yum|1.1.3 markdown-all-in-one|yzh|3.4.3 vscode-proto3|zxh|0.5.5 (5 theme extensions excluded)

A/B Experiments

``` vsliv695:30137379 vsins829:30139715 vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492cf:30256198 vslsvsres303:30308271 pythonvspyl392:30422396 pythontb:30258533 pythonptprofiler:30281269 vshan820:30294714 pythondataviewer:30285072 vscod805:30301674 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30404738 wslgetstarted:30449409 vscscmwlcmt:30465136 cppdebug:30492333 pylanb8912cf:30496797 vsclangdf:30492506 ```

[meganrogge]

/duplicate #134448

[vscodenpa]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!