Go To Source Definition UX improvements

[andrewbranch]

Following up on TypeScript’s new Go To Source Definition command (d851ea5d49b0ec89b98765d9e0084c25f2ff5031), I want to track some editor-side UX improvements:

• Can we replace the error notification for “no source definitions found” with an inline message similar to Go To Definition?

  

• Can we somehow indicate when a result is a guess? This is already returned in the protocol response via an unverified property, but it is never surfaced to the user. When multiple locations are returned, maybe we could add something to the peek locations UI:

  

  (Note: the unverified flag is also sometimes set in normal Go To Definition responses, so this request is not specific to Go To Source Definition.)

  When only one location is returned, maybe a notification would suffice, but I would love design input on this.

[mjbvz]

@jrieken Any thoughts on these? I think we'd have to implement these in core

[jrieken]

Can we somehow indicate when a result is a guess? This is already returned in the protocol response via an unverified property, but it is never surfaced to the user.

There is currently no way to express that but it reminds me of https://github.com/microsoft/vscode/issues/74237 which is about adding a kind-property to references/locations. That would allow us to classify/filter/etc...

Can we replace the error notification for “no source definitions found” with an inline message similar to Go To Definition?

No sure how "go to source" is implemented but in case it is using the editor.action.goToLocations-command than a "no-results-message" can be passed