microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.69k stars 29.07k forks source link

Ctrl-R should not be handled by codium if a terminal window has focus #152681

Closed muellert closed 2 years ago

muellert commented 2 years ago

Does this issue occur when all extensions are disabled?: No

When in a terminal window, I would like to use Ctrl-R to search my history. However, this gets intercepted by Codium, which tries to assemble a "chord". The problem does not occur when I have disabled all my extensions, but I haven't yet been able to pinpoint what the exact reason for this problem is.

VS Code version: VSCodium 1.68.1 (30d9c6cd9483b2cc586687151bcbcd635f373630, 2022-06-16T00:18:08.407Z) OS version: Linux x64 5.10.0-15-amd64 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 3370)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|3, 3, 2| |Memory (System)|31.03GB (1.65GB free)| |Process Argv|--ms-enable-electron-run-as-node| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|undefined| |XDG_CURRENT_DESKTOP|undefined| |XDG_SESSION_DESKTOP|undefined| |XDG_SESSION_TYPE|tty|
Extensions (102) Extension|Author (truncated)|Version ---|---|--- terraform|4op|0.2.1 better-comments|aar|3.0.0 Bookmarks|ale|13.0.1 vscode-sqlite|ale|0.14.1 arepl|alm|2.0.3 aws-toolkit-vscode|ama|1.39.0 gitflow-actions-sidebar|ard|0.5.0 vscode-django|bat|1.8.0 npm-intellisense|chr|1.4.2 path-intellisense|chr|2.8.0 gitignore|cod|0.7.0 bracket-pair-colorizer-2|Coe|0.1.4 vscode-database-client2|cwe|5.3.7 vscode-ssh|cwe|1.7.6 vscode-markdownlint|Dav|0.47.0 vscode-eslint|dba|2.2.2 ansible-vault|dho|0.1.3 xml|Dot|2.5.1 es7-react-js-snippets|dsz|4.4.3 vscode-html-css|ecm|1.13.0 EditorConfig|Edi|0.16.6 texlab|efo|4.1.0 vscode-npm-script|eg2|0.3.11 LogFileHighlighter|emi|2.8.0 vsc-material-theme|Equ|33.5.0 vsc-material-theme-icons|equ|2.3.1 prettier-vscode|esb|9.5.0 vscode-open-in-npm|fab|1.0.4 php-debug|fel|1.22.0 php-intellisense|fel|2.3.14 php-pack|fel|1.0.2 shell-format|fox|7.0.1 vscode-python-config|fra|1.1.1 phoityne-vscode|gat|0.0.29 html-slim-scss-css-class-completion|gen|1.7.8 codetogether|gen|2022.2.0 gitlab-workflow|Git|3.47.1 live-sass|gle|5.4.0 todo-tree|Gru|0.0.215 timing|Haa|2.7.1 terraform|has|2.21.1 haskell|has|2.2.0 test-adapter-converter|hbe|0.1.2 vscode-test-explorer|hbe|2.21.1 haskell-linter|hoo|0.0.6 rest-client|hum|0.24.6 kubernetes-snippets|ipe|0.1.9 shortcut-menu-bar|jer|3.0.4 vscode-peacock|joh|4.0.1 changelog-and-markdown-snippets|jos|1.2.1 language-haskell|jus|3.6.0 vscode-sshfs|Kel|1.25.0 saltstack|kor|0.0.9 vscode-python-test-adapter|lit|0.7.1 MagicPython|mag|1.1.1 VS-code-vagrantfile|mar|0.0.7 vscode-snippets-for-ansible|Mat|1.1.0 rainbow-csv|mec|2.4.0 php-namespace-resolver|Meh|1.1.8 dotenv|mik|1.0.1 mongodb-vscode|mon|0.9.3 vscode-docker|ms-|1.22.0 vscode-kubernetes-tools|ms-|1.3.10 pyright|ms-|1.1.239 anaconda-extension-pack|ms-|1.0.1 python|ms-|2022.8.0 jupyter|ms-|2022.5.1001610507 Go|ms-|0.14.3 live-server|ms-|0.2.12 vscode-typescript-tslint-plugin|ms-|1.2.2 vsliveshare|ms-|1.0.3968 debugger-for-chrome|msj|4.12.6 sqltools|mtx|0.23.0 vuejs-extension-pack|mub|1.2.1 pytest-fixtures|nic|0.2.2 autodocstring|njp|0.6.1 vetur|oct|0.35.0 indent-rainbow|ode|8.3.1 docthis|oou|0.8.2 openapi-designer|phi|0.3.0 material-icon-theme|PKi|4.18.1 material-product-icons|PKi|1.3.0 text-power-tools|qcz|1.33.0 inline-sql-syntax|quf|2.10.3 ansible|red|0.10.0 vscode-xml|red|0.20.0 vscode-yaml|red|0.11.0 shellman|Rem|5.6.0 LiveServer|rit|5.7.5 vscode-coverage-gutters|rya|2.10.1 jinjahtml|sam|0.17.0 git-autoconfig|shy|0.0.2 sourcery|sou|0.12.1 vscode-status-bar-format-toggle|tom|3.0.0 vscode-icons|vsc|11.12.0 git-ui|vsc|1.55.2 nodejs-devops-extension-pack|vym|0.0.12 salt-lint|war|0.1.0 saltstack-extension-pack|war|0.0.2 remote-oss|xab|0.0.1 JavaScriptSnippets|xab|1.8.0 vscode-surround|yat|1.1.2 (2 theme extensions excluded)

intercepted code --disable-extensions ode --disable-e debian$ shift+End => shift+[End] Home => [Home] shift+Home => shift+[Home] LeftArrow => [ArrowLeft] shift+LeftArrow => shift+[ArrowLeft] PageDown => [PageDown] shift+PageDown => shift+[PageDown] Layout info:

Developer: Toggle Keyboard Shortcuts Troubleshooting https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions Ctrl+R Ctrl+R is the default keyboard chord for

Steps to Reproduce:

  1. Open a terminal window.
  2. Type "Ctrl-R" and observe that, in the bottom, codium says that it wants more input.
Tyriar commented 2 years ago

If it doesn't happen when extensions are disabled you will need to figure out which one is causing it. You can check the extensions keybindings they set when installing them.

vscodenpa commented 2 years ago

This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the marketplace for VS Code. See also our issue reporting guidelines.

Happy Coding!

Tyriar commented 2 years ago

There is also "terminal.integrated.allowChords": false which is a nuclear approach