microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.28k stars 28.57k forks source link

Test Explorer: Filter is not reset if left blank and window reloaded #153328

Closed JustinGrote closed 2 years ago

JustinGrote commented 2 years ago

@connor4312 @amanasifkhalid

Related: https://github.com/microsoft/vscode/pull/147344 Issue Type: Bug

  1. Set a test explorer filter like 'test'
  2. Reload window
  3. Filter will be preserved
  4. Set filter to blank
  5. Reload
  6. Filter will incorrectly reset to 'test'

VS Code version: Code - Insiders 1.69.0-insider (173f4bea73601a31859372b409cac2c20fa91194, 2022-06-24T06:32:08.615Z) OS version: Windows_NT x64 10.0.22621 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|AMD Ryzen 7 4700U with Radeon Graphics (8 x 1996)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.36GB (6.39GB free)| |Process Argv|C:\\Users\\JGrote\\Projects\\HospiceGroups --crash-reporter-id 4453efaa-0821-4555-88e2-3de8bad9109e| |Screen Reader|no| |VM|0%|
Extensions (74) Extension|Author (truncated)|Version ---|---|--- go-outliner|766|0.1.20 vscode-color|ans|0.4.5 vscode-log-viewer|ber|0.12.2 markdown-mermaid|bie|1.14.2 markdown-preview-github-styles|bie|1.0.1 vscode-opennewinstance|chr|0.0.12 vscode-github-actions|csc|0.24.1 vscode-markdownlint|Dav|0.47.0 vscode-eslint|dba|2.2.2 dendron-paste-image|den|1.1.0 vscode-deno|den|3.12.0 vscode-generate-getter-setter|DSK|0.5.0 gitlens|eam|12.1.1 filter-lines|ear|1.0.0 EditorConfig|Edi|0.16.4 prettier-vscode|esb|9.5.0 auto-using|Fud|0.7.15 lintlens|ghm|3.0.3 copilot-nightly|Git|1.31.6196 remotehub|Git|0.34.0 vscode-pull-request-github|Git|0.44.0 gc-excelviewer|Gra|4.2.55 todo-tree|Gru|0.0.215 hcl|has|0.2.0 vscode-test-explorer|hbe|2.21.1 vscode-drawio|hed|1.6.4 change-case|hjd|1.0.2 Ionide-fsharp|Ion|6.0.6 Ionide-Paket|Ion|2.0.0 vscode-peacock|joh|4.0.1 roslynator|jos|4.1.1 chat|kar|0.35.0 csharpextensions|kre|1.7.0 regexp-preview|Lou|0.1.5 vscode-preview-ansi|lus|0.1.2 regionfolder|map|1.0.17 git-graph|mhu|1.30.0 vscode-html-format|moh|0.0.4 azure-pipelines|ms-|1.205.0 vscode-bicep|ms-|0.7.4 vscode-docker|ms-|1.22.0 blazorwasm-companion|ms-|1.1.0 csharp|ms-|1.25.0 vscode-dotnet-runtime|ms-|1.5.0 remote-containers|ms-|0.240.0 remote-ssh|ms-|0.83.2022062315 remote-ssh-edit|ms-|0.80.0 remote-wsl|ms-|0.66.3 azure-account|ms-|0.10.1 js-debug-nightly|ms-|2022.6.2417 powershell-preview|ms-|2022.6.2 remote-repositories|ms-|0.12.0 test-adapter-converter|ms-|0.1.6 vscode-typescript-next|ms-|4.8.20220626 vsliveshare|ms-|1.0.5625 vsliveshare-audio|ms-|0.1.91 vscode-drawio-plugin-mermaid|nop|0.1.5 indent-rainbow|ode|8.3.1 docthis|oou|0.8.2 vscode-jest|Ort|4.6.0 pester-test|psp|2022.3.3 vscode-thunder-client|ran|1.16.5 vscode-commons|red|0.0.6 vscode-yaml|red|1.8.0 vscode-zipexplorer|sle|0.3.1 even-better-toml|tam|0.16.4 vscode-inline-values-powershell|Tyl|0.0.6 errorlens|use|3.5.1 vscode-icons|vsc|11.12.0 codetour|vsl|0.0.58 gistfs|vsl|0.4.1 gitdoc|vsl|0.0.8 gitmoji-vscode|Vtr|1.0.9 better-align|wwm|1.1.6
A/B Experiments ``` vsliv695:30137379 vsins829:30139715 vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30422396 pythontb:30258533 pythonptprofiler:30281269 vshan820:30294714 pythondataviewer:30285072 vscod805:30301674 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30404738 wslgetstarted:30449409 vscscmwlcmt:30465136 cppdebug:30492333 pylanb8912cf:30496797 vsclangdf:30492506 ```
connor4312 commented 2 years ago

Duplicates https://github.com/microsoft/vscode/issues/150120

JustinGrote commented 2 years ago

@connor4312 apparently I suck at searching! thanks.