microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.64k stars 29.04k forks source link

Dark theme shows dark blocks below text #154980

Closed guycnicholas closed 2 years ago

guycnicholas commented 2 years ago

Issue Type: Bug

When using the dark theme(s) "Visual Studio Dark" and "Visual Studio 2019 Dark" there are black areas below the end of the text in the file.

image

VS Code version: Code 1.69.1 (b06ae3b2d2dbfe28bca3134cc6be65935cdfea6a, 2022-07-12T08:21:51.333Z) OS version: Darwin x64 21.5.0 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2300)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled| |Load (avg)|3, 2, 2| |Memory (System)|32.00GB (0.13GB free)| |Process Argv|--crash-reporter-id 8a8708a2-857f-4160-b1d7-75d09a14ed9d| |Screen Reader|no| |VM|0%|
Extensions (50) Extension|Author (truncated)|Version ---|---|--- logcat|abh|0.0.7 android-dev-ext|ade|1.3.2 project-manager|ale|12.6.0 npm-intellisense|chr|1.4.2 bracket-pair-colorizer|Coe|1.0.62 vscode-eslint|dba|2.2.6 fileheadercomment|doi|0.0.5 vscode-npm-script|eg2|0.3.28 flow-for-vscode|flo|2.1.0 gc-excelviewer|Gra|4.2.55 todo-tree|Gru|0.0.215 duk-debug|Har|0.5.6 rest-client|hum|0.25.0 vscode-hexdump|ili|1.8.2 vscode-peacock|joh|4.0.1 mdhelper|jos|0.0.11 sublime-babel-vscode|jos|0.2.10 vscode-position|jtr|1.1.2 vscode-docker|ms-|1.22.1 csharp|ms-|1.25.0 vscode-edge-devtools|ms-|2.1.0 python|ms-|2022.10.0 vscode-pylance|ms-|2022.7.20 jupyter|ms-|2022.6.1101950301 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.8 remote-containers|ms-|0.241.3 azure-account|ms-|0.11.0 cpptools|ms-|1.10.8 vscode-js-profile-flame|ms-|1.0.4 vscode-typescript-next|ms-|4.8.20220711 vsliveshare|ms-|1.0.5641 vsliveshare-audio|ms-|0.1.91 vsliveshare-pack|ms-|0.4.0 debugger-for-chrome|msj|4.13.0 debugger-for-edge|msj|1.0.15 vscode-code-outline|pat|0.2.1 java|red|1.8.0 json-to-js|ren|0.2.0 bash-debug|rog|0.3.9 code-spell-checker|str|2.3.0 vscode-stylelint|sty|1.2.2 vscodeintellicode|Vis|1.2.22 vscode-java-debug|vsc|0.42.0 vscode-java-dependency|vsc|0.20.0 vscode-java-pack|vsc|0.24.0 vscode-java-test|vsc|0.35.2 vscode-maven|vsc|0.36.0 vscode-icons|vsc|11.13.0 vscode-import-cost|wix|3.3.0
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonvspyt551cf:30345471 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 vsc1dst:30438360 pythonvs932:30410667 wslgetstarted:30449410 vscscmwlcmt:30465135 cppdebug:30492333 vscaac:30438847 vsclangdc:30486549 ```
guycnicholas commented 2 years ago

What's weirder is that if I add enough blank lines and then position the cursor at the bottom, the black section moves up. image

drewgaze commented 2 years ago

same issue, exact same settings on a mac and a windows machine and I only get this problem on my mac. It occurs across multiple themes.

EDIT: This fixed it for me: https://code.visualstudio.com/updates/v1_40#_disable-gpu-acceleration

noelforte commented 2 years ago

Can confirm this bug is reproducible on my machine. My system specs are as follows:

System info: CPUs | Apple M1 Max (10 x 24) -- | -- GPU Status | 2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled Load (avg) | 4, 4, 4 Memory (System) | 32.00GB (0.31GB free) Process Argv | --crash-reporter-id e59cebd3-2c94-44e2-9067-cc8b383c00ac Screen Reader | no VM | 0%
Enabled extensions: Extension | Author (truncated) | Version -- | -- | -- Bookmarks | ale | 13.3.0 copy-relative-path | ale | 0.0.2 astro-vscode | ast | 0.19.4 shell-syntax | bma | 1.0.3 vscode-fish | bma | 1.0.29 npm-intellisense | chr | 1.4.2 systemd-unit-file | coo | 1.0.6 vscode-eslint | dba | 2.2.6 EditorConfig | Edi | 0.16.4 prettier-vscode | esb | 9.5.0 gc-excelviewer | Gra | 4.2.55 todo-tree | Gru | 0.0.215 rest-client | hum | 0.25.0 gruvbox-material-icon-theme | Jon | 1.1.5 git-graph | mhu | 1.30.0 fluent-icons | mig | 0.0.17 dotenv | mik | 1.0.1 vscode-apache | mrm | 1.2.0 remote-ssh | ms- | 0.84.0 remote-ssh-edit | ms- | 0.80.0 remote-wsl | ms- | 0.66.3 wordcount | ms- | 0.1.0 vsliveshare | ms- | 1.0.5641 vsliveshare-audio | ms- | 0.1.91 vsliveshare-pack | ms- | 0.4.0 vscode-yaml | red | 1.8.0 vscode-sort-json | ric | 1.20.0 nunjucks | ron | 0.3.1 gruvbox-material | sai | 6.5.0 linter-xo | sam | 3.9.0 vue-vscode-extensionpack | sdr | 0.2.0 vue-vscode-snippets | sdr | 3.1.1 vscode-fileutils | sle | 3.5.0 code-spell-checker | str | 2.3.0 sass-indented | syl | 1.8.22 language-stylus | sys | 1.16.0 even-better-toml | tam | 0.16.4 write-good-linter | tra | 0.1.4 errorlens | use | 3.5.1 vscodeintellicode | Vis | 1.2.22 volar | Vue | 0.38.5 vscode-jumpy | wma | 0.3.1 JavaScriptSnippets | xab | 1.8.0 txt-syntax | xsh | 0.2.0 mcmeta | xTe | 0.0.1 markdown-all-in-one | yzh | 3.4.3
A/B Experiments: ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonvspyt551:30345470 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 vsc1dst:30438360 pythonvs932:30410667 wslgetstarted:30449410 vscscmwlcmt:30465135 cppdebug:30492333 vsclangdc:30486549 ```
dbeckwith commented 2 years ago

Also seeing this.

Screen Shot 2022-07-12 at 4 18 08 PM

Disabling hardware acceleration fixed it.

I also found this old issue that seems like the same thing.

gjsjohnmurray commented 2 years ago

/duplicate of #152816

vscodenpa commented 2 years ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!