search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.18k stars 29.29k forks source link

Stage change with non UTF-8 file show all special characters as changes #155658

Open izacsc opened 2 years ago

izacsc commented 2 years ago

Issue Type: Bug

  1. Create a non UTF-8 file ( e.g. windows 1252 ) in a git repository with special characters such as á, ã, ç, etc...
  2. Make changes in some lines in this file.
  3. Use the UI to stage one line.
  4. All 'special' characters are now marked as changes and shown as characters with encoding problems ( UTF-8 characters in a windows 1252 file )

VS Code version: Code 1.69.2 (3b889b090b5ad5793f524b5d1d39fda662b96a2a, 2022-07-18T16:12:52.460Z) OS version: Windows_NT x64 10.0.18362 Restricted Mode: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.88GB (6.17GB free)| |Process Argv|--crash-reporter-id 894f54ae-c2f3-4c75-bfc8-7f4ac5dc9e16| |Screen Reader|no| |VM|0%|
Extensions (29) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|13.3.1 npm-intellisense|chr|1.4.2 vscode-eslint|dba|2.2.6 xml|Dot|2.5.1 gitlens|eam|12.1.2 vscode-npm-script|eg2|0.3.28 vscode-engpro-extension|eng|1.7.3 prettier-vscode|esb|9.5.0 remotehub|Git|0.39.2022071901 vscode-test-explorer|hbe|2.21.1 search-node-modules|jas|1.3.0 angular-file-changer|joh|0.0.4 vscode-peacock|joh|4.0.1 advpl-unit-test|Kil|0.1.0 advpl-vscode|Kil|0.14.11 dotenv|mik|1.0.1 azure-repos|ms-|0.15.2022071901 live-server|ms-|0.2.12 remote-repositories|ms-|0.17.2022071901 test-adapter-converter|ms-|0.1.6 vsliveshare|ms-|1.0.5641 vscode-jest|Ort|4.6.0 vscode-commons|red|0.0.6 vscode-yaml|red|1.9.1 angular-cli|seg|0.0.19 code-spell-checker|str|2.3.1 code-spell-checker-portuguese-brazilian|str|2.0.7 vscodeintellicode|Vis|1.2.22 JavaScriptSnippets|xab|1.8.0
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 vsc1dst:30438360 pythonvs932:30410667 wslgetstarted:30449410 vscscmwlcmt:30465135 cppdebug:30492333 pylanb8912cf:30529770 vsclangdc:30486549 ```
izacsc commented 2 years ago

Code_qxit0nqW5q

izacsc commented 2 years ago

Any updates on this? It seems that the new merge editor also has the same problem.