microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.14k stars 29.28k forks source link

Introduce command palette overlay focus #157142

Open carloscuesta opened 2 years ago

carloscuesta commented 2 years ago

Description of the problem

Hey! ๐Ÿ‘‹๐Ÿผ

I recently switched from Atom to VSCode a few weeks ago since the deprecation was announced. In the transition process I realised something that made Atom a bit more easy to use when working with the command palette

Here's how the UI looks when the command palette is open in VSCode.

Screenshot 2022-08-04 at 19 28 19

I find this pattern a bit confusing since there's not a clear focus to the command palette when I'm using it, I can get distracted by other things in the UI while I'm writing a command or trying to open a file.

Suggested solution

I think that focusing the command palette when is open, creates a better user experience and a focus to the UI you're interacting with. If we compare observe the behaviour in Atom, an overlay with opacity is introduced to the UI improving the focus prioritising the visibility of the command palette.

Screenshot 2022-08-04 at 19 33 15

Additional context

I think we can introduce a new setting in order to enable this new feature, giving the users the flexibility to decide if they want it or not, something like:

{
  "workbench.commandPalette.overlayFocus": Boolean,
}

Can be related with https://github.com/microsoft/vscode/issues/115641

carloscuesta commented 2 years ago

Hey @TylerLeonhardt do you need to triage this? ๐Ÿ‘€

vscodenpa commented 2 years ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa commented 2 years ago

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!