search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.31k stars 28.9k forks source link

window-appicon should be aligned to activity bar #157239

Open KunalTanwar opened 2 years ago

KunalTanwar commented 2 years ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. Open VS Code
  2. Set "window.menuBarVisibility": "toggle" and "workbench.layoutControl.enabled": false
  3. See Sidebar
  4. You notice that window-appicon is not aligned with icons below i.e. product icons (because width of the product icons is 48x48px whereas width of window-appicon is 35px

Before (when width is 35px)

BEFORE

After (setting to 48px wide)

AFTER

miguelsolorio commented 2 years ago

@sbatten thoughts on this? I don't think we ever intentionally tried to align the product icon. my only concern is it makes the product icon look like it's part of the activity bar instead of the title bar.

sbatten commented 2 years ago

I feel like we discussed this before and decided against, we went with a "native"-ish positioning. Though, if I look at some in-box modern apps on Windows (that have the icon, since many don't), there does seem to be more padding on the left in many cases. That being said, I feel this is primarily motivated by "looking good", so if it accomplishes that goal, I'm fine with it.