There is no color customization option for layout controls in the hover state

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

164.89k stars 29.52k forks source link

There is no color customization option for layout controls in the hover state #157785

Open pouyakary opened 2 years ago

pouyakary commented 2 years ago

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.0
OS Version: macOS Ventura Version 13.0 Beta (22A5295i)

Layout controls have no ways to be customized in colors. I tried to check other themes and I found no example where they were custom colored. The main colors are the title bars:

but then there are no colors when the buttons are hovered:

sbatten commented 2 years ago

@daviddossett do we have precedent for having specific theme keys at this level? I am not aware of that.

daviddossett commented 2 years ago

These pick up the toolbar.hoverBackground color which is used all over VS Code, including this title bar. Try adding this to your settings.json to see them change.

"workbench.colorCustomizations": {
   "toolbar.hoverBackground": "#ff0000",
}

We don't have specific colors just for the title bar buttons.

pouyakary commented 2 years ago

@daviddossett thanks a lot. Can you please also have foreground color customization? I volunteer for adding it if you show me where I should dig into.

daviddossett commented 2 years ago

@sbatten are these layout icons not using icon.foreground on purpose?

sbatten commented 2 years ago

not on purpose in the sense that we shouldn't change it lol. before the CC, I just made everything use the title bar foreground for consistency and that color changes based on window focus. but if icon foreground is the correct key, we can pick that up instead. but it might look strange in some themes imo.

daviddossett commented 2 years ago

I just made everything use the title bar foreground for consistency and that color changes based on window focus

This is a good point. We may actually instead need to reconsider the overlap between command center and titlebar colors. It's a bit tangled at the moment.

I saw that I could indeed change the layout colors via titlebar.activeForeground: