files don't save or get marked dirty

[af4jm]

Type: Bug

1. open a file
2. edit the file

Expected result: file gets the dot indicating it's "dirty" Actual result since 1.70.0: 50/50 whether that will happen or not... in the cases when it doesn't, Save does nothing

Restarting VS Code will show the file as dirty, and usually will also allow the file to be saved, but about 80% of the time restarting VSCode again will reopen the file showing as dirty, and trying to save it again will show a Conflict where both before & after are identical (e.g there is no conflict)

I know that's several different bugs, but since they're all related I don't even know how to separate them... #157902 was caused by the same update... I really need to get off of Electron based software, since it's not possible to use without spending at least 50% of your time working around instabilities

VS Code version: Code 1.70.2 (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:35:13.448Z) OS version: Windows_NT x64 10.0.22000 Modes:

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 x 1800)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|31.89GB (21.65GB free)| |Process Argv|--file-uri file:///c%3A/src/AF4JM.code-workspace --crash-reporter-id 06338080-eec2-498d-98e0-cf3111dc1cde| |Screen Reader|no| |VM|0%|

Extensions (109)

Extension|Author (truncated)|Version ---|---|--- vscode-icalendar|af4|1.0.1 vscode-m3u|af4|1.0.0 vscode-caniuse|aga|0.5.0 case-change|Aka|1.0.2 rtf|ale|2.5.1 vscode-sqlite|ale|0.14.1 swagger-viewer|Arj|3.1.2 azurite|Azu|3.18.0 spellright|ban|3.0.90 armview|ben|0.4.6 markdown-checkbox|bie|0.3.2 markdown-emoji|bie|0.3.0 markdown-footnotes|bie|0.0.7 markdown-mermaid|bie|1.14.3 markdown-yaml-preamble|bie|0.1.0 vscode-tldr|bmu|1.0.0 mermaid-markdown-syntax-highlighting|bpr|1.4.1 npm-intellisense|chr|1.4.2 gitignore|cod|0.9.0 disableligatures|Coe|0.0.10 sql-teradata|con|0.3.0 vscode-markdownlint|Dav|0.47.0 jshint|dba|0.11.0 vscode-eslint|dba|2.2.6 rushcore|Dev|1.0.2 rushnav|Dev|1.0.2 githistory|don|0.6.19 xml|Dot|2.5.1 escaping-characters|drp|1.0.0 vscode-babel-coloring|dza|0.0.4 EditorConfig|Edi|0.16.4 vscode-macros|EXC|1.4.0 git-project-manager|fel|1.8.2 scriptcsRunner|fil|0.1.0 vscode-firefox-debug|fir|2.9.8 vscode-npm|fkn|3.3.0 shell-format|fox|7.2.2 macros|ged|1.2.1 matlab|Gim|2.3.1 vscode-pull-request-github|Git|0.48.1 gc-excelviewer|Gra|4.2.55 vscode-favorites|how|1.10.2 rest-client|hum|0.25.1 Ionide-fsharp|Ion|7.1.0 path-autocomplete|ion|1.20.2 mediawiki|jak|2.1.0 anki|jas|1.2.6 markdown-katex|jef|0.1.4 nuget-reverse-package-search|jes|0.1.68 vscode-nuget-package-manager|jmr|1.1.6 vscode-peacock|joh|4.1.0 gpg|jva|0.1.2 docomment|k--|0.1.31 vscode-liquid-snippets|kil|2.0.3 gnuplot|mam|1.0.5 markdown-shortcuts|mdi|0.12.0 openapi-lint|mer|1.2.0 azure-pipelines|ms-|1.208.0 vscode-azureappservice|ms-|0.24.3 vscode-azurefunctions|ms-|1.7.4 vscode-azureresourcegroups|ms-|0.5.5 vscode-azurestaticwebapps|ms-|0.11.2 vscode-azurestorage|ms-|0.14.2 vscode-azurevirtualmachines|ms-|0.6.2 vscode-bicep|ms-|0.9.1 vscode-cosmosdb|ms-|0.19.2 vscode-docker|ms-|1.22.1 csharp|ms-|1.25.0 vscode-dotnet-runtime|ms-|1.5.0 data-workspace-vscode|ms-|0.2.2 mssql|ms-|1.15.0 sql-bindings-vscode|ms-|0.2.1 sql-database-projects-vscode|ms-|0.17.2 python|ms-|2022.12.1 vscode-pylance|ms-|2022.8.30 jupyter|ms-|2022.7.1102252217 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.9 vscode-ai|ms-|0.16.0 vscode-ai-remote|ms-|0.16.0 remote-containers|ms-|0.245.1 remote-ssh|ms-|0.84.0 remote-ssh-edit|ms-|0.80.0 remote-wsl|ms-|0.66.3 vscode-remote-extensionpack|ms-|0.21.0 azure-account|ms-|0.11.1 azurecli|ms-|0.5.0 hexeditor|ms-|1.9.8 live-server|ms-|0.2.13 mono-debug|ms-|0.16.3 powershell|ms-|2022.7.2 vscode-node-azure-pack|ms-|1.0.0 azurerm-vscode-tools|msa|0.15.7 debugger-for-edge|msj|1.0.15 language-liquid|nei|0.1.1 bib|phr|0.3.0 vscode-commons|red|0.0.6 vscode-yaml|red|1.9.1 r|REd|2.5.2 kuskus-kusto-language-server|ros|1.0.26 kuskus-kusto-syntax-highlighting|ros|1.1.20 vscode-zipexplorer|sle|0.3.1 addDocComments|ste|0.0.8 msbuild-project-tools|tin|0.4.6 vscodeintellicode|Vis|1.2.22 nanoid-generator|vk-|0.1.2 vscode-icons|vsc|11.15.0 JavaScriptSnippets|xab|1.8.0 t4-support|zbe|0.5.0

A/B Experiments

``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonvspyt551cf:30345471 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30410667 wslgetstarted:30449410 cppdebug:30492333 pylanb8912:30545647 vsclangdf:30486550 c4g48928:30535728 d7fjc500:30543455 dsvsc012:30540252 azure-dev_surveyone:30548225 ```

[af4jm]

2 additional notes...

• I just had 1 case where I had to reboot the PC, then save & conflict resolve 1 more time to stop it from marking a file dirty on restarting VSCode
• I've already tried deleting my entire AppSettings/Roaming/VSCode folder, except for user settings, keyboard shortcuts, & snippets...no effect

[gjsjohnmurray]

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your 100+ extensions.

[sslupsky]

I am seeing random git related issues with 1.70.2 as well. In my case, I have noticed files appear "dirty" in the source control extension when git status says the repo is clean. In another case the repo shows one dirty file and git status says there are two dirty files.

[bpasero]

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[VSCodeTriageBot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[af4jm]

just duplicated it in the latest VSCode with all extensions disabled... tried it in Insiders with no extensions installed and it does not happen, at least not with the files that it consistently happens with... 2 other things that are correlated to this issue that I hadn't noticed to mention above...

1. it consistently happens or not with the same files over & over again
2. when the issue happens, not only does the file not get marked dirty, problems don't get yellow squiggles either (not even in the scroll area)

[af4jm]

I can't confirm, but I suspect this bug should've been filed against the Markdown language server instead of VSCode as a whole... is that a separate repo???

[af4jm]

this seems to be resolved with 1.72.0... files that consistently exhibited the strange behavior have been normal since that update