Settings access with @ext:* does not take "order" into account

[McSodbrenner]

Type: Bug

Accessing the extension settings via "@ext:*" (e.g. @ext:eamodio.gitlens) does not take into account the "order" key that can be specified in the package.json of an extension under "contributes.configuration.properties". Instead, it is sorted alphabetically. But if you filter the search results by the keys/namespace of the configuration parameters (e.g. "gitlens.") it will sort correctly. My expectation would be that the "order" key is also taken into account when calling via "@ext:*".

VS Code version: Code 1.70.1 (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:08:33.642Z) OS version: Windows_NT x64 10.0.22000 Modes: Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i3-8130U CPU @ 2.20GHz (4 x 2208)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|7.91GB (0.93GB free)| |Process Argv|--crash-reporter-id f99464a5-8822-46d7-a621-d6395d9680b9| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|WSL: Ubuntu| |OS|Linux x64 5.10.16.3-microsoft-standard-WSL2| |CPUs|Intel(R) Core(TM) i3-8130U CPU @ 2.20GHz (4 x 2207)| |Memory (System)|3.79GB (3.40GB free)| |VM|0%|

Extensions (17)

Extension|Author (truncated)|Version ---|---|--- numbered-bookmarks|ale|8.3.1 vscode-intelephense-client|bme|1.8.2 jsonviewer|cci|1.2.3 yaml-preview|dai|0.0.1 vscode-eslint|dba|2.2.6 gitlens|eam|12.1.2 vs-code-xml-format|fab|0.1.5 todo-tree|Gru|0.0.215 better-open-editors|McS|1.1.1 vscode-duplicate|mrm|1.2.1 vscode-scss|mrm|0.10.0 vscode-language-pack-de|MS-|1.70.8170921 remote-ssh|ms-|0.84.0 remote-wsl|ms-|0.66.3 vscode-remote-extensionpack|ms-|0.21.0 hexeditor|ms-|1.9.8 vetur|oct|0.36.0

A/B Experiments

``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492cf:30256860 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonvspyt551:30345470 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30542924 vsaa593:30376534 pythonvs932:30410667 wslgetstarted:30449410 cppdebug:30492333 pylanb8912:30545647 vsclangdc:30486549 c4g48928:30535728 d7fjc500:30543455 dsvsc012:30540252 azure-dev_surveyonecf:30548226 ```

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[McSodbrenner]

Also affects the version 1.70.2 .

[McSodbrenner]

The problem no longer exists in 1.84.2... magical! :)

[no-identd]

@rzhao271: out of curiosity, would you happen to know which commit(s) fixed this/whether a fix for some different issue happened to fix this as well?

[rzhao271]

@no-identd In 1.84, the Settings editor orders results by the table of contents by default, which also closes issues such as this one.

However, some search results have gotten worse, so I'm considering reverting that change, which will regress this issue again. I can make it so that if the query only contains @ext that the results are ordered by table of contents, though.

@McSodbrenner feel free to comment on the following issue if you disagree with the proposed revert or have more thoughts on when the extensions should be sorted by the order key during a search: https://github.com/microsoft/vscode/issues/197773