microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.88k stars 29.52k forks source link

Find Dialogue #159174

Open scottlapoint opened 2 years ago

scottlapoint commented 2 years ago

Hello.

I wasn't able to locate this request or functionality (if it exists, so I apologize if it's already there)

I have a vision impairment and need to have things relatively bigger to work. VS Code has made my life a heck of a lot easier and I wish it existed back in the 90s when I started my career.

That being said there is only one area I was hoping that can be improved.

I find the FIND dialogue box too small and on a big monitor, being up in the upper right sometimes I literally have to stand up to look at it.

I am hoping you can either, allow to make the box MOVEABLE or CENTERED, and an option to make it bigger (aside from increasing the whole work bench size).

I also noticed the new FIND dialogue on the TREE VIEW which is a welcome addition, would it be possible to have it at the TOP of the TREE VIEW ALL THE TIME as an option, there is enough space there that it could exist without having to invoke it. (also an option to make that bigger as well)

Also allow the FILTER selection state to be remembered, I have to turn it on each time I close the FIND box.

Thanks !

rebornix commented 2 years ago

@scottlapoint thanks for your detailed feedback, they are very valuable. Currently we only support resizing the find widget in the edtior (drag the vertical bar on the left border of the find widget to resize) but we don't support move the find widget, like what you can do with the debug toolbar. It makes good sense to me.

@joaomoreno can help answer the questions about the Tree/List view find widget. cc our A11y champ @isidorn .

isidorn commented 2 years ago

@scottlapoint great feedback, this is super useful! Let me try to answer:

  1. Allowing the find widget to be moved horizontally like the debug toolbar makes sense to me
  2. I would not allow the find widget to increase size for now. Ideally zooming in the whole workbench helps here, and I would not want that we have specific zooming capability per UI element
  3. Preserving filter state in tree find makes sense. @joaomoreno let me know if you would like a new issue for this
  4. Preserving tree find across reloads makes sense. @joaomoreno what do you think? @rebornix why don't we preserve the editor find across reloads?
scottlapoint commented 2 years ago

Thanks for the responses! I had no idea the main editor find element was resizable -- must have missed it, so that works, but the buttons stay on the far right which is still a reach to get to at times. -- perhaps the buttons could be moveable to the right as well as an option OR even better allowing the find box to be moved to the bottom of the screen as an option?

Screen Shot 2022-08-31 at 10 12 34 AM

And here I was suggesting the find dialogue be static at the very top of the tree pane no need to show hide it all the time since there is enough space there to have it stay all the time (you could still hide it if you don't want to see it)

Screen Shot 2022-08-31 at 10 15 41 AM

isidorn commented 2 years ago

@scottlapoint yup. Your second suggestion should be covered by my point 4 from above. It would stay visible as long as you do not explicitly close it.