Cleanup / remove `_tarballProxyEndpoints` - Githubissues

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

162.52k stars 28.65k forks source link

Cleanup / remove `_tarballProxyEndpoints` #162109

Closed bpasero closed 1 year ago

bpasero commented 1 year ago

We should either make this an official API or find an alternative and remove it from the embedder API:

https://github.com/microsoft/vscode/blob/835d39cfac9ede6c7c90678c8d6c3d4d0171ed6d/src/vs/workbench/browser/web.api.ts#L181-L185

joyceerhl commented 1 year ago

To summarize:

We have this option _tarballProxyEndpoints that is currently in core and part of the web api
It doesn't look like it's going away anytime soon
We have a way to clean it up by moving knowledge of it to the embedders rather than keeping it in core

Action items:

[x] Register new command _remotehub.getTarballProxyEndpoints in embedders
- [x] vscode.dev (fyi @joaomoreno)
- [x] github.dev (fyi @jkeech)
[x] Ensure both embedders' changes are deployed
[x] Adopt this command in RemoteHub
[ ] Remove knowledge of old options in embedders, RemoteHub, and core