microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.48k stars 28.65k forks source link

Ligature malfunction #163059

Closed FernandoB5757 closed 1 year ago

FernandoB5757 commented 1 year ago

Type: Bug

I have installed 3 types of fonts to be able to use ligatures, I have enabled the ligatures, and restarted visual studio code multiple times, but still the ligatures do not show up.

VS Code version: Code 1.72.0 (64bbfbf67ada9953918d72e1df2f4d8e537d340e, 2022-10-04T23:20:39.912Z) OS version: Windows_NT x64 10.0.22621 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|11.81GB (4.87GB free)| |Process Argv|--crash-reporter-id 5641a19f-9623-4302-85d2-c6c93ce23191| |Screen Reader|no| |VM|22%|
Extensions (35) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 codesnap|adp|1.3.4 laravel-extra-intellisense|ami|0.6.2 laravel-blade-spacer|aus|2.1.3 color-assist|axm|0.1.2 vscode-intelephense-client|bme|1.8.2 path-intellisense|chr|2.8.1 laravel-goto-view|cod|1.3.7 jquerysnippets|don|0.0.1 vscode-html-css|ecm|1.13.1 EditorConfig|Edi|0.16.4 prettier-vscode|esb|9.9.0 vue-format|feb|0.1.8 auto-rename-tag|for|0.1.10 gitkraken-authentication|git|1.0.3 todo-tree|Gru|0.0.215 html-tag-wrapper|hwe|0.2.3 dotenv|mik|1.0.1 laravel-goto-components|nao|1.2.0 vetur|oct|0.36.0 laravel-blade|one|1.32.0 laravel-extension-pack|one|1.1.0 laravel5-snippets|one|1.15.0 material-icon-theme|PKi|4.21.0 vscode-css-peek|pra|4.2.0 laravel-artisan|rya|0.0.28 vscode-blade-formatter|shu|0.18.2 css-auto-prefix|spo|0.1.7 laravel-goto-controller|ste|0.0.15 volar|Vue|1.0.0 JavaScriptSnippets|xab|1.8.0 php-debug|xde|1.28.0 php-pack|xde|1.0.3 html-css-class-completion|Zig|1.20.0 php-intellisense|zob|1.0.11 (2 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vsclangdf:30486550 c4g48928:30535728 dsvsc012cf:30540253 azure-dev_surveyone:30548225 i497e931:30553904 pyindex848:30577860 fc301958:30573243 ```
IllusionMH commented 1 year ago

/needsMoreInfo

What exact fonts have you installed? What are your actual settings related to font and ligatures? Which combinations you are trying?

VSCodeTriageBot commented 1 year ago

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

FernandoB5757 commented 1 year ago

I have Fira Code, JetBrains Mono and Cascadia Code installed. These are my settings in settings.json: { "editor.fontFamily": "Jetbrains Mono", "editor.fontLigatures": true } I have tried putting the 3 fonts together, or separately each one of them. The problem is that when I installed them it worked, but when I closed visual, and opened it again the ligatures disappeared.

ArturoDent commented 1 year ago

For Fira Code at least you need more info in your settings about which "stylistic sets' you want, see for example: https://stackoverflow.com/q/58965575/836330

So you might end up with something like this

  "editor.fontFamily": "Fira Code",  
  "editor.fontLigatures":"'zero', 'ss02', 'ss03', 'ss04', 'ss05', 'calt'",

The stylistic sets available are listed at the Fira Code download pages.

alexdima commented 1 year ago

@FernandoB5757 Have you tried uninstalling the fonts, restarting the machine and then reinstalling the fonts? I've noticed that sometimes fonts don't get picked up on Windows until a restart.

FernandoB5757 commented 1 year ago

For Fira Code at least you need more info in your settings about which "stylistic sets' you want, see for example: https://stackoverflow.com/q/58965575/836330

So you might end up with something like this

  "editor.fontFamily": "Fira Code",  
  "editor.fontLigatures":"'zero', 'ss02', 'ss03', 'ss04', 'ss05', 'calt'",

The stylistic sets available are listed at the Fira Code download pages.

I tried, I reinstalled the font, and I put that configuration, and it didn't work. I'm starting to think it's a Windows 11 bug.

ArturoDent commented 1 year ago

I am on Windows 11. Did you reboot Windows after installing Fira Code, and check to see what exactly that font is called in your Fonts app. You did precisely follow the Fira Code installation instructions at https://github.com/tonsky/FiraCode/wiki/Installing#windows ?

FernandoB5757 commented 1 year ago

@ArturoDent, I uninstalled the font, and installed it following the instructions, I restarted my device and it didn't work, I already checked my fonts in my control panel and it is installed, even in word the font appears. It also happens that in the vs console, they have a different font: image

IllusionMH commented 1 year ago

Terminal one looks like generic fallback to Times New Roman. Are you sure font named "Fira Code" and not like "Fira Code Retina" in your case?

You can test in browser by changing font-face property in DevTools. And by checking exact name in Windows Settings for Fonts

FernandoB5757 commented 1 year ago

I solved the problem, I installed the font for all users and it worked. Thanks to all.