search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.06k stars 29.23k forks source link

The change flag lights up when the IME input is not yet finalized. #164351

Open guttyon opened 2 years ago

guttyon commented 2 years ago

Does this issue occur when all extensions are disabled?: Yes

version: 1.72.2 (user setup) commit: d045a5eda657f4d7b676dedbfa7aab8207f8a075 Electron: 19.0.17 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Windows_NT x64 10.0.22000 Sandboxed: No

The change flag lights up when the IME input is not yet finalized. Animation The image above shows when one character is entered into the Japanese IME and cancelled with the ESC key. The change flag lights up when a single character is entered. After canceling the input with the ESC key, the change flag remains lit. I think it is wrong that the change flag lights up when the text has not been changed.

guttyon commented 2 years ago

There is also the problem of canceling IME input, which results in an empty operation in undo/redo.

alexdima commented 2 years ago

Right now, whenever doing IME, we will immediately modify the text buffer, even before IME is confirmed. This allows other UI elements, such as the suggest widget, or vscode extensions, to react immediately.

I am not convinced of doing something very special for IME here. Also the file is dirty when not using IME and pressing for example A and then pressing Backspace. In other words, the dirty flag is not text buffer content based.

guttyon commented 2 years ago

Thank you for your comments.

I felt uncomfortable because the operation in IME is different compared to the editor in visual studio. Of course, it doesn't have to be the same.

Currently, the suggest widget does not show up while using the IME. If it did appear, both the IME's suggest window and vscode's suggest widget would appear and operation would be impossible.

What about my second comment about the problem during undo/redo?

vs-code-engineering[bot] commented 1 month ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vs-code-engineering[bot] commented 1 week ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!