October 2022 Endgame

[rebornix]

• 10//24 Code freeze for the endgame
• 10/28 Endgame done
• 11/02 Expected release date (this may change)

Monday

• [x] Check that all queries in this issue use the current milestone @rebornix
• [x] Run OSS tool @rebornix
• [x] Update links in the Endgame notebooks to point to new milestone @rebornix
• [x] Code freeze at 5pm PT
• [x] Ensure we have a green build on all platforms at 5pm PT
• [x] 🔖All closed feature-requests either have a verification-needed or on-testplan label
• [x] Create test plan items following the template here by 6pm PT
• [x] Update your availability for testing here - https://vscode-tools.azurewebsites.net/team-manifest team
  • [x] Update availability of testers in vacation. Double check N/A testers. @rebornix

Tuesday

• [x] Test plan items assigned (using https://vscode-tools.azurewebsites.net/test-plan-items)
  • Run the tool multiple times to balance load if test items come in later and assignments are already made
  • Assigned to you
• [x] Test build starts at 7am CET
• [x] Test plan ready by 8am CET
• [x] 🔖Testing
• [x] 🔖Verification needed

Wednesday

• [x] 🔖Testing
• [x] Remind team members to assign issues that they intend to fix to the current milestone
• [x] Fixing (self-assigned, milestone assigned)
• [x] 🔖Verification needed

Thursday

• [x] Fixing (self-assigned, milestone assigned, no need for PR or review)
  • Increased scrutiny sets in due to testing being completed. Fixes pose a much higher risk
  • Move issues to the next month that can be deferred
• [x] 🔖Verification needed
• [x] 🔖Verification

Friday

• [x] Build a stable build to ensure stable build is green @rebornix
• [x] Pause scheduled insider builds @rebornix
• Satellite modules/npm packages ready, version updated, smoke tested
  • [ ] yo generator @aeschli
  • [x] js-debug @connor4312
  • [x] Debug Adapter Protocol @connor4312
  • [x] vscode-debugadapter-node @roblourens
  • [x] Mock Debug @roblourens
  • [ ] custom data for html/css @aeschli
• [x] Only candidate issues are open and assigned to 🔖milestone
• [ ] All issues 🔖verified
• [x] All open PRs on the milestone 🔖merged or deferred
• [x] Branch code to release/<x.y> after all expected fixes are in (latest 5PM PST) @rebornix
• [x] Branch distro to release/<x.y> after all expected fixes are in (latest 5PM PST) @rebornix
• [x] Branch vscode.dev to release/<x.y> after all expected fixes are in (latest 5PM PST) owner
• [x] Localization: Run Update VS Code Branch build with release/* as the VS Code Branch parameter (it's the default so you shouldn't have to change anything) @rebornix
• [x] Announce main is open for business @rebornix
• [x] Fixing (PR + review required once branched - major bugs only - to be discussed in stand-up meeting, labeled as candidate)
• [ ] All release notes updated
  • release notes are collected in a file named v<Major>_<Minor>.md in this repo directory
  • [x] @aeschli
  • [x] @alexdima
  • [x] @alexr00
  • [x] @andreamah
  • [ ] @bpasero
  • [x] @chrmarti
  • [ ] @connor4312
  • [x] @dbaeumer
  • [ ] @deepak1556
  • [ ] @egamma
  • [ ] @hediet
  • [x] @isidorn
  • [ ] @joaomoreno
  • [x] @joyceerhl
  • [ ] @jrieken
  • [ ] @kieferrm
  • [x] @lramos15
  • [ ] @lszomoru
  • [x] @meganrogge
  • [x] @mjbvz
  • [x] @rebornix
  • [x] @roblourens
  • [x] @rzhao271
  • [ ] @sandy081
  • [x] @sbatten
  • [x] @tylerleonhardt
  • [ ] @tyriar
  • [x] @weinand
• [x] Acknowledge pull requests in release notes. We acknowledge PRs from outside the team. We have improved the tooling so that the @rebornix can generate the pull request acknowledgment for all repositories at once. @rebornix
  • [ ] debug-adapter-protocol, inno-updater, jsonc-parser, language-server-protocol, lsif-node, vscode, vscode-codicons, vscode-css-languageservice, vscode-debugadapter-node, vscode-dev-containers, vscode-docs, vscode-emmet-helper, vscode-eslint, vscode-extension-samples, vscode-generator-code, vscode-hexeditor, vscode-html-languageservice, vscode-js-debug, vscode-js-debug-companion, vscode-js-profile-visualizer, vscode-jshint, vscode-json-languageservice, vscode-languageserver-node, vscode-livepreview, vscode-loader, vscode-lsif-extension, vscode-node-debug, vscode-node-debug2, vscode-pull-request-github, vscode-recipes, vscode-references-view, vscode-textmate, vscode-vsce
• [x] Acknowledge issue trackers from the community @chrmarti
• [x] Add notable fixes to the release notes all
• When done fixing/verifying and there are changes since last build at the end of day PT
  • [x] Build and manually release Insider from release/<x.y> @rebornix

Friday/Monday

• [x] Polish release notes redmond
• [x] Fixing (only critical bugs - no string changes)

Monday - Wednesday

• [x] 🔖milestone issues
• [x] 🔖candidate issues
• [x] Polish release notes redmond
• [x] Cherry-pick hand-picked and reviewed changes to release/<x.y> @rebornix
• [x] Build Insider from release/<x.y> @rebornix
• [x] Manually release Insider @rebornix
• [x] Build stable for all platforms as new candidate issues come in @rebornix
• [ ] Documentation updated
  • [x] @aeschli
  • [x] @alexdima
  • [x] @alexr00
  • [x] @andreamah
  • [ ] @bpasero
  • [x] @chrmarti
  • [ ] @connor4312
  • [x] @dbaeumer
  • [ ] @deepak1556
  • [ ] @egamma
  • [ ] @hediet
  • [x] @isidorn
  • [ ] @joaomoreno
  • [x] @joyceerhl
  • [ ] @jrieken
  • [x] @kieferrm
  • [x] @lramos15
  • [ ] @lszomoru
  • [x] @meganrogge
  • [x] @mjbvz
  • [x] @rebornix
  • [x] @roblourens
  • [x] @rzhao271
  • [ ] @sandy081
  • [x] @sbatten
  • [x] @tylerleonhardt
  • [x] @tyriar
  • [x] @weinand
• [x] Run scripts/test-documentation.sh|bat and add file or fix issues if there are new colors that are not documented. @rebornix

Note: The Insiders build needs to be in the wild for 24 hours before we can enter the last phase of the endgame. @rebornix

Wednesday/Thursday - Expected release day (this may change)

• [x] Build stable for all platforms @rebornix
• [x] Sanity check of installable bits (server instructions)
  • [x] Windows 32 bit
  • [x] signed installer 32-bit @mjbvz
  • [x] signed user installer 32-bit @mjbvz
  • [x] zip 32-bit @roblourens
  • [x] server 32-bit @roblourens
  • [x] Windows 64 bit @roblourens
  • [x] signed installer 64-bit
  • [x] signed user installer 64-bit
  • [x] zip 64-bit
  • [x] server 64-bit
  • [x] Windows ARM64 @sbatten
  • [x] signed installer ARM64
  • [x] signed user installer ARM64
  • [x] zip ARM64
  • [x] macOS
  • [x] Intel + Universal @roblourens
  • [x] Apple Silicon + Universal @kieferrm
  • [x] Linux x64
  • [x] deb @rebornix
  • [x] rpm owner
  • [x] archives @rebornix
  • [x] snap (sudo snap install --classic --dangerous <file>.snap) owner
  • [x] Linux server owner
  • [x] x64 @roblourens
  • [x] x64 Alpine
  • [x] ARM32 @roblourens
  • [x] ARM64
  • [x] ARM64 Alpine
• [x] Publish website @gregvanl
• [x] Publish to stable @rebornix
• [x] Trigger the vscode.dev Deploy pipeline for the prod deployment target. Request approval from another team member at the necessary step. @rebornix
• [x] Create an official release @rebornix
  • [x] Create a tag (make sure you pull the release branch first): git tag <x.y.z>
  • [x] Push the tag: git push origin <x.y.z>
  • [x] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Also change the relative links for the key highlight list items to absolute links Example
• [x] Twitter announcement @chrisdias
• [x] Enable scheduled insider builds @rebornix
• [x] Bump up the version in package.json on main - @rebornix
• [x] Publish @types/vscode @rebornix
• [x] Close the milestone on GitHub @rebornix
• [x] Create next milestone and ensure that it has a due date. The created milestone and its due date will be automatically synced across our repos @rebornix
• [x] If no Patch Tuesday release is planned, let the Updates team know of that fact (CSEClientPatching@microsoft.com) @rebornix
• [ ] If a recovery build is needed, proceed to https://github.com/microsoft/vscode/wiki/Endgame-Recovery-Template or https://github.com/microsoft/vscode-internalbacklog/wiki/Patch-Tuesday-Release-Endgame-Template/ @rebornix

[lorand-horvath]

@rebornix I've been noticing a bit of confusion regarding the "version" property in https://github.com/microsoft/vscode/blob/main/package.json during the phase before releasing a new version. So, for example during Monday-Wednesday before the planned release 1.73 this week Wednesday, we see "version": "1.73.0" for the main branch, but in fact it should be "1.74.0", since the main branch has already been worked on with commits belonging to 1.74 (November release)

Wouldn't it be more logical to switch the main branch version to 1.74 immediately after the release/1.73 branch was created (Friday last week, AFAICT) and just before work begins on 1.74?

If this change were done, you wouldn't need the Bump up the version in package.json on main entry anymore for Wednesday/Thursday.

[rebornix]

@lorand-horvath thanks for the reminder and it makes good sense to bump version in the main branch right after we create the release branch.

[lorand-horvath]

@rebornix Looks like it didn't work as expected: https://github.com/microsoft/vscode/commit/447e61a31fc36ad3c14e7776973b290826c9c40a

[joaomoreno]

It should've worked. It will work from now on: https://github.com/microsoft/vscode/pull/165132